From: "Clément Léger" <clement.leger@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Allan Nielsen <allan.nielsen@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register()
Date: Mon, 28 Mar 2022 08:26:42 +0200 [thread overview]
Message-ID: <20220328082642.471281e7@fixe.home> (raw)
In-Reply-To: <Yj4MIIu7Qtvv25Fs@lunn.ch>
Le Fri, 25 Mar 2022 19:38:24 +0100,
Andrew Lunn <andrew@lunn.ch> a écrit :
> On Fri, Mar 25, 2022 at 06:22:30PM +0100, Clément Léger wrote:
> > In order to support software node description transparently, add fwnode
> > support with fwnode_mdiobus_register(). This function behaves exactly
> > like of_mdiobus_register() function but using the fwnode node agnostic
> > API. This support might also be used to merge ACPI mdiobus support
> > which is quite similar to the fwnode one.
> >
> > Some part such as the whitelist matching are kept exclusively for OF
> > nodes since it uses an of_device_id struct and seems tightly coupled
> > with OF. Other parts are generic and will allow to move the existing
> > OF support on top of this fwnode version.
>
> Does fwnode have any documentation? How does a developer know what
> properties can be passed? Should you be adding a
>
> Documentation/fwnode/bindings/net/mdio.yaml ?
>
> Andrew
Hi Andrew,
Actually, fwnode is an abstraction for various firmware nodes such as
ACPI, device-tree and software nodes. It allows to access properties,
child and other attributes transparently from these various nodes but
does not actually defines how they should describe the hardware. If
there is specific hanling to be done, node type can be checked using
is_acpi_node(), is_of_node() and so on.
I think it is still needed to document the bindings for each node type.
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
next prev parent reply other threads:[~2022-03-28 7:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 17:22 [net-next 0/5] add fwnode based mdiobus registration Clément Léger
2022-03-25 17:22 ` [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register() Clément Léger
2022-03-25 18:38 ` Andrew Lunn
2022-03-28 6:26 ` Clément Léger [this message]
2022-03-28 13:03 ` Andrew Lunn
2022-03-28 13:27 ` Clément Léger
2022-03-28 14:12 ` Andrew Lunn
2022-03-28 14:41 ` Clément Léger
2022-03-26 2:52 ` kernel test robot
2022-03-26 2:52 ` kernel test robot
2022-03-25 17:22 ` [net-next 2/5] net: mdio: of: use fwnode_mdiobus_* functions Clément Léger
2022-03-25 18:32 ` Andrew Lunn
2022-03-28 7:53 ` Clément Léger
2022-03-25 17:22 ` [net-next 3/5] net: mdiobus: fwnode: avoid calling of_* functions with non OF nodes Clément Léger
2022-03-25 17:22 ` [net-next 4/5] net: mdiobus: fwnode: allow phy device registration " Clément Léger
2022-03-25 17:22 ` [net-next 5/5] net: mdio: mscc-miim: use fwnode_mdiobus_register() Clément Léger
2022-03-26 2:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328082642.471281e7@fixe.home \
--to=clement.leger@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).