From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4B1C433F5 for ; Mon, 28 Mar 2022 13:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243308AbiC1Nkf (ORCPT ); Mon, 28 Mar 2022 09:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237976AbiC1Nka (ORCPT ); Mon, 28 Mar 2022 09:40:30 -0400 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C6B1E13F1C; Mon, 28 Mar 2022 06:38:49 -0700 (PDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 22SDJU00005431; Mon, 28 Mar 2022 08:19:30 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 22SDJSov005423; Mon, 28 Mar 2022 08:19:28 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 28 Mar 2022 08:19:28 -0500 From: Segher Boessenkool To: Arnd Bergmann Cc: Benjamin =?iso-8859-1?Q?St=FCrz?= , Andrew Lunn , linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, Linus Walleij , Dave Hansen , linux-pci , Robert Moore , Harald Welte , Alim Akhtar , "H. Peter Anvin" , wcn36xx@lists.infradead.org, Pkshih , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , ACPI Devel Maling List , linux-edac@vger.kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-rdma , Gregory CLEMENT , "Rafael J. Wysocki" , Russell King - ARM Linux , Krzysztof Kozlowski , Jason Gunthorpe , Ingo Molnar , Chas Williams <3chas3@gmail.com>, "open list:HID CORE LAYER" , Jakub Kicinski , pabeni@redhat.com, Len Brown , mike.marciniszyn@cornelisnetworks.com, Robert Richter , Andrew Donnellan , kvalo@kernel.org, linuxppc-dev , "open list:GPIO SUBSYSTEM" , loic.poulain@linaro.org, Borislav Petkov , Bjorn Helgaas , Thomas Gleixner , Mauro Carvalho Chehab , Linux Media Mailing List , Simtec Linux Team , Linux ARM , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , Karsten Keil , Tony Luck , Nicolas Pitre , gregkh , Dmitry Torokhov , linux-wireless , Linux Kernel Mailing List , David Miller , James Morse , Networking , Frederic Barrat , Sebastian Hesselbarth , Pali =?iso-8859-1?Q?Roh=E1r?= , Bartosz Golaszewski Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers Message-ID: <20220328131928.GH614@gate.crashing.org> References: <20220326165909.506926-1-benni@stuerz.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote: > On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. > > The change looks fine, but the comment looks misplaced, as enum initializers > are not c99 feature. Yes, it is from C89/C90. > Also, the named array and struct intializers have been > supported by gnu89 for a long time and widely used in the kernel, so it's > not a recent change even for the others. GCC supports this since 1998. There was a syntax different from C99 designated initializers (".ans = 42") before (namely, "ans: 42"). 1998 is long enough ago for all intents and purposes now of course ;-) Segher