From: Fabien Parent <fparent@baylibre.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board
Date: Mon, 28 Mar 2022 16:41:07 +0200 [thread overview]
Message-ID: <20220328144107.ed4xwzuiezzixqrx@radium> (raw)
In-Reply-To: <94d231cf-ce4c-22f5-b9af-41ae68f1e659@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 4180 bytes --]
On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote:
> Il 27/03/22 22:03, Fabien Parent ha scritto:
> > Add basic device-tree for the MT8195 Demo board. The
> > Demo board is made by MediaTek and has a MT8195 SoC,
> > associated with the MT6359 and MT6360 PMICs, and
> > the MT7921 connectivity chip.
> >
> > The IOs available on that board are:
> > * 1 USB Type-C connector with DP aux mode support
> > * 1 USB Type-A connector
> > * 1 full size HDMI RX and 1 full size HDMI TX connector
> > * 1 uSD slot
> > * 40 pins header
> > * SPI interface header
> > * 1 M.2 slot
> > * 1 audio jack
> > * 1 micro-USB port for serial debug
> > * 2 connectors for DSI displays
> > * 3 connectors for CSI cameras
> > * 1 connector for a eDP panel
> > * 1 MMC storage
> >
> > This commit adds basic support in order to be able to boot.
> >
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> > v2:
> > * remove empty i2c nodes
> > * remove empty spi node
> > * remove unused pcie pinctrls
> > * fixup node nodes to not contains underscore
> > * rename mt6360 pmic node
> > * move mmc1 node right after mmc0 node
> > * use generic node name for gpio-keys
> > * uniformize pinctrl node names
> >
> > arch/arm64/boot/dts/mediatek/Makefile | 1 +
> > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++
> > 2 files changed, 448 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> >
>
> ..snip..
>
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > new file mode 100644
> > index 000000000000..d94b4e01159a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > @@ -0,0 +1,447 @@
>
> ..snip..
>
> > +
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > + input-name = "gpio-keys";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&gpio_keys_pins>;
> > +
> > + key-0 {
>
> key-volup is more descriptive, can you please change that?
Which review should I follow, yours or the one from Krzysztof? Because both reviews are contradictory
>
> > + gpios = <&pio 106 GPIO_ACTIVE_LOW>;
> > + label = "volume_up";
> > + linux,code = <KEY_VOLUMEUP>;
> > + wakeup-source;
> > + debounce-interval = <15>;
> > + };
> > + };
> > +};
> > +
>
> ..snip..
>
> > +
> > +&pmic {
> > + interrupt-parent = <&pio>;
> > + interrupts = <222 IRQ_TYPE_LEVEL_HIGH>;
>
> I would instead use interrupts-extended here:
>
> interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
Thanks, it will be fixed in v3.
>
> > +};
> > +
> > +&i2c6 {
> > + clock-frequency = <400000>;
> > + pinctrl-0 = <&i2c6_pins>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +
> > + mt6360: pmic@34 {
> > + compatible = "mediatek,mt6360";
> > + reg = <0x34>;
> > + interrupt-controller;
> > + interrupt-parent = <&pio>;
> > + interrupts = <101 IRQ_TYPE_EDGE_FALLING>;
>
> Same here
Thanks, it will be fixed in v3.
>
> > + interrupt-names = "IRQB";
> > +
>
> ...snip...
>
> > +
> > +&pio {
> > + mmc0_default_pins: mmc0-default-pins {
> > + pins-cmd-dat {
> > + pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>,
> > + <PINMUX_GPIO125__FUNC_MSDC0_DAT1>,
> > + <PINMUX_GPIO124__FUNC_MSDC0_DAT2>,
> > + <PINMUX_GPIO123__FUNC_MSDC0_DAT3>,
> > + <PINMUX_GPIO119__FUNC_MSDC0_DAT4>,
> > + <PINMUX_GPIO118__FUNC_MSDC0_DAT5>,
> > + <PINMUX_GPIO117__FUNC_MSDC0_DAT6>,
> > + <PINMUX_GPIO116__FUNC_MSDC0_DAT7>,
> > + <PINMUX_GPIO121__FUNC_MSDC0_CMD>;
> > + input-enable;
> > + drive-strength = <MTK_DRIVE_6mA>;
> > + bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
> > + };
> > +
> > + pin-clk {
>
> This is supposed to be "pins-clk", not "pin-clk"... same for all the other
> instances of the "pin-".
There is only one pin in that node, so it should be singular, no?
>
> Before pushing patches upstream, please run dtbs_check, as these are all
> mistakes that will be pointed out by that.
>
> Regards,
> Angelo
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-28 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220327200312.3090515-1-fparent@baylibre.com>
2022-03-27 20:03 ` [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board Fabien Parent
2022-03-28 14:57 ` Krzysztof Kozlowski
2022-03-27 20:03 ` [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board Fabien Parent
2022-03-28 13:47 ` AngeloGioacchino Del Regno
2022-03-28 14:41 ` Fabien Parent [this message]
2022-03-28 14:50 ` AngeloGioacchino Del Regno
2022-03-28 15:02 ` Krzysztof Kozlowski
2022-04-01 14:13 ` Mattijs Korpershoek
2022-03-27 20:03 ` [PATCH v2 3/4] arm64: defconfig: enable MT6359 regulator driver Fabien Parent
2022-03-27 20:03 ` [PATCH v2 4/4] arm64: defconfig: enable some mt6360 PMIC drivers Fabien Parent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328144107.ed4xwzuiezzixqrx@radium \
--to=fparent@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).