From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71759C433EF for ; Mon, 28 Mar 2022 23:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbiC1XB7 (ORCPT ); Mon, 28 Mar 2022 19:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbiC1XB4 (ORCPT ); Mon, 28 Mar 2022 19:01:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5078240BD; Mon, 28 Mar 2022 16:00:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A1D660C7D; Mon, 28 Mar 2022 23:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3525AC340EC; Mon, 28 Mar 2022 23:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648508412; bh=7C2zg81KqOPL2oH4kK0Qvprda9/Ao9Mc247z5u2Vhek=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=id0zVO7sDGlf9kZ37Xmm3W2vqP4HQ6Nx8BFmzlf4pK6cRRawvVWJCRhrc3WJNQMmh 8SOk/4153l4fNYchqGmpNIONa/WBdWeU4990FXm9guej0rDqzS9iEzvY+65EM9+lF0 unKhwrNDWDnyZzteKKXNhgify24sUvSS53oLSQZB9zhUBGVzjDdwOa16AtYHA1ajsC IZ+M/d07et278qpc3m+o6Ktug8tnQj22mWvN+V27xXBemHIaBEoo8LEptb/CxnSX1x BFIsO3SC4BJn7nwKjY6AmpfbKqlxi1acp12QXdt8Wfu0I7PAdeNXN/55GQMsRqok2n oMzCyPpL42emg== Date: Mon, 28 Mar 2022 16:00:10 -0700 From: Jakub Kicinski To: Michael Walle Cc: Guenter Roeck , Andrew Lunn , Xu Yilun , Tom Rix , Jean Delvare , Heiner Kallweit , Russell King , "David S . Miller" , Paolo Abeni , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 0/2] hwmon: introduce hwmon_sanitize() Message-ID: <20220328160010.73bd2a47@kernel.org> In-Reply-To: References: <20220328115226.3042322-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2022 00:50:28 +0200 Michael Walle wrote: > > No, it isn't the easiest solution because it also modifies a hwmon > > driver to use it. > > So that leaves us with option 1? The next version will contain the > additional patch which moves the hwmon_is_bad_char() from the include > to the core and make it private. That will then need an immutable > branch from netdev to get merged back into hwmon before that patch > can be applied, right? If anything immutable branch from hwmon that we can pull, because hwmon is the home of the API, and netdev is just _a_ consumer. Either way I think you can post the patch that adds the new helper for review.