From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA5AC4707A for ; Wed, 30 Mar 2022 12:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346588AbiC3MFS (ORCPT ); Wed, 30 Mar 2022 08:05:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345638AbiC3Lyv (ORCPT ); Wed, 30 Mar 2022 07:54:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E552C261980; Wed, 30 Mar 2022 04:51:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3643D61625; Wed, 30 Mar 2022 11:51:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8C0C3410F; Wed, 30 Mar 2022 11:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648641090; bh=AI9DrVufi3MdEFjnhzkWMRlWnmYNO4xCFAbfcOkWUqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sJ8iFL6rZ3tgBNeWRTz6YvBDsSijUiE9d4QuwQvUCRrvXkQT6PKZvOb/QkQiQJzsv rXPorXimSTSqza6Ogup3ABTcyfaCfwY/8+qOFHN+rYi2Mr1+ru06fjNVb/fUjZQDRV c/tIRBCEmqDASEYnekopDlr1CY/KofQOj8ukDpk7hWY977v490XHysVvpLEvOrdZ1A boiyvskz4lk47RRkfRSF5R6BZ51oSNp6GEK3y6+j5MPsVm6riNx4Lu6Pdk1x5CFhzQ wrixzL3mjvYULBMQ36T0ayjkspPUraRy7sgg56KDkxLUdN2wen4InKhsFXUH4xJWGj ykEu9yZiTWV/g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peiwei Hu , Sean Young , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 04/37] media: ir_toy: free before error exiting Date: Wed, 30 Mar 2022 07:50:49 -0400 Message-Id: <20220330115122.1671763-4-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220330115122.1671763-1-sashal@kernel.org> References: <20220330115122.1671763-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peiwei Hu [ Upstream commit 52cdb013036391d9d87aba5b4fc49cdfc6ea4b23 ] Fix leak in error path. Signed-off-by: Peiwei Hu Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/ir_toy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/ir_toy.c b/drivers/media/rc/ir_toy.c index 1aa7989e756c..7f394277478b 100644 --- a/drivers/media/rc/ir_toy.c +++ b/drivers/media/rc/ir_toy.c @@ -429,7 +429,7 @@ static int irtoy_probe(struct usb_interface *intf, err = usb_submit_urb(irtoy->urb_in, GFP_KERNEL); if (err != 0) { dev_err(irtoy->dev, "fail to submit in urb: %d\n", err); - return err; + goto free_rcdev; } err = irtoy_setup(irtoy); -- 2.34.1