From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A94C38A06 for ; Wed, 30 Mar 2022 12:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347881AbiC3MHy (ORCPT ); Wed, 30 Mar 2022 08:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345964AbiC3LzR (ORCPT ); Wed, 30 Mar 2022 07:55:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E6EF2BB09; Wed, 30 Mar 2022 04:53:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE912615F5; Wed, 30 Mar 2022 11:53:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B69AC340F2; Wed, 30 Mar 2022 11:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648641211; bh=FQRiQeUNTgPPO1qTi6G4foPwMZKkCOTAKwzoD7oiqEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XSigm/6ACwNwxwiSg4vsXlmO9jgQT3QTUvXZNnQelw6KwOsWrG2xV3UGo1SHluVA0 BDmySoyLhtQ06pfDcE8rgksjar/ez908wCkEIkq7plbMxiIgtXWwTHgrQfYAwNG9pD wCBmg49pDiVi4DD5Ejzm+BfQb1lCz5njEmLjuaLxN4YHjnR+vtmgaEqTaFXzpz2Eia kkP6/xqwFA1eSmWBjR8RdCc/EH/s8kHbZkFiRGY1jtdCgsybdjcycfcXH/7n1gqEti HJWm3qb9jal4LVKSm2Q+4DFRL2uWjbI89ZxpYTelfbm5FiUlgfZfPmIk0i721vW3Be L0/gLn4DHCBsA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavel Skripkin , =?UTF-8?q?Maximilian=20B=C3=B6hm?= , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 18/22] media: Revert "media: em28xx: add missing em28xx_close_extension" Date: Wed, 30 Mar 2022 07:52:59 -0400 Message-Id: <20220330115303.1672616-18-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220330115303.1672616-1-sashal@kernel.org> References: <20220330115303.1672616-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin [ Upstream commit fde18c3bac3f964d8333ae53b304d8fee430502b ] This reverts commit 2c98b8a3458df03abdc6945bbef67ef91d181938. Reverted patch causes problems with Hauppauge WinTV dualHD as Maximilian reported [1]. Since quick solution didn't come up let's just revert it to make this device work with upstream kernels. Link: https://lore.kernel.org/all/6a72a37b-e972-187d-0322-16336e12bdc5@elbmurf.de/ [1] Reported-by: Maximilian Böhm Tested-by: Maximilian Böhm Signed-off-by: Pavel Skripkin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/em28xx/em28xx-cards.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index 06da08f8efdb..2edeca200925 100644 --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -4036,11 +4036,8 @@ static void em28xx_usb_disconnect(struct usb_interface *intf) em28xx_close_extension(dev); - if (dev->dev_next) { - em28xx_close_extension(dev->dev_next); + if (dev->dev_next) em28xx_release_resources(dev->dev_next); - } - em28xx_release_resources(dev); if (dev->dev_next) { -- 2.34.1