From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA3BC433FE for ; Thu, 31 Mar 2022 08:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbiCaIqp (ORCPT ); Thu, 31 Mar 2022 04:46:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232754AbiCaIqn (ORCPT ); Thu, 31 Mar 2022 04:46:43 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2D1415470B for ; Thu, 31 Mar 2022 01:44:56 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id e5so22775359pls.4 for ; Thu, 31 Mar 2022 01:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FhzVk64/NIKLiS6pp8Z+fT0Y8xwvGEYa4togIdcxYYk=; b=ICBYDrTFxqntrrzWD538RHzkmhMUsTzyv8yva1vHpjOl+YFBDVbFwBje833t9zn6P8 3j7TUXzWqkE5OqOEDv+Ro7X6yWpWauix2c6xy+27ct0rU5OGE4NDrtIR6tCLFRYD7MsS Yl0sB0YFPzFjbS1sKuGTu3rM3FmHrSR8Wlj6IbV9KhArk049TgxIG+C45ipjmk+pI4xe RV085hborc+M1cMQsuS6kDLJ/NotgzoQ/d7m/lPWdvJiCdKPenouT6TjtEzT8j7iANp3 rfcglmQqodsjwDcIhX14MvBi9Xvjym8BFG4eLTMJvgjQrYDeUT8h7hYCYP9YKA3Hucq0 w78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FhzVk64/NIKLiS6pp8Z+fT0Y8xwvGEYa4togIdcxYYk=; b=Q688Y4e1x+RHqNw7dGsqPmBrcCpDN6kkwPMmpcfK9LHthzfB4FF2Zu8HaQjq1mbP6T hRiwBNMkq3AcFNqXYdGXEXf+uPNF/Ed3HB2ELNJ4Efar93bCrPvkzxX7LnK0MiCfPViP y0ldP+cltJzv89QH5i8B3GgiTK/VQngogYc3u+DHNGvURym0n7Px1SbL8wA8fDKuY8Cv ZyV2CVlKDZAXfbdv+ReBqSjcLhXnJjicrW9Q9/WTaM6urR6B6D2rDQITCRYX85hkh9O0 m/LlAeN7TqNwFAcK6Ij552GrGOKKxVu5CQh/ZIRxRJdsvKJDW6B8FicvvLFKlJO0b012 Hqmg== X-Gm-Message-State: AOAM530zpNDSNA9lvYPFkVkb1QHoYT6G01+Z0G4uusQWss7qZakaYtmc awvB6Fm2B7zpfG88si/LZe76uw== X-Google-Smtp-Source: ABdhPJxEgHNxbaBHgr6g0EY3covUtA2BOdBzQiZbu1mOXIgyyHZcL0mejNKkNTKFFiawEVFB6rciJw== X-Received: by 2002:a17:902:b692:b0:151:5474:d3ee with SMTP id c18-20020a170902b69200b001515474d3eemr40081273pls.139.1648716296426; Thu, 31 Mar 2022 01:44:56 -0700 (PDT) Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id l2-20020a056a0016c200b004f7e3181a41sm27899760pfc.98.2022.03.31.01.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 01:44:55 -0700 (PDT) Date: Thu, 31 Mar 2022 14:14:53 +0530 From: Viresh Kumar To: Xiaomeng Tong Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] opp: use list iterator only inside the loop Message-ID: <20220331084453.jlmuilvg3n3ve27t@vireshk-i7> References: <20220331083018.31995-1-xiam0nd.tong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331083018.31995-1-xiam0nd.tong@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is V3 and not V2. You need to be careful to update them for every single version of patch you send. On 31-03-22, 16:30, Xiaomeng Tong wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate dedicated pointer variable [1]. > > In this case, use a new variable 'iter' as the list iterator, while > use the old variable 'new_dev' as a dedicated pointer to point to the > found entry. And BUG_ON(!new_dev);. > > [1]: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > > Signed-off-by: Xiaomeng Tong > --- > > changes since v1: > - use BUG_ON(!new_dev); instead of return; (Viresh Kumar) > > v1: https://lore.kernel.org/lkml/20220331015818.28045-1-xiam0nd.tong@gmail.com/ > > --- > drivers/opp/debugfs.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Looks good now. I will apply it in few days. -- viresh