From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF3AC433F5 for ; Sat, 2 Apr 2022 05:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353836AbiDBFZZ (ORCPT ); Sat, 2 Apr 2022 01:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240281AbiDBFZS (ORCPT ); Sat, 2 Apr 2022 01:25:18 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2082.outbound.protection.outlook.com [40.107.21.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50412D54; Fri, 1 Apr 2022 22:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eI0rl9q3EZ1uZkYvXNhqpzE9aAxrkBe34IWRR6iJiGmof6UT3V+yrgKHZfmsUdXN+oN38X4uGjoIVVQCFKuEO+clXorv3+aAZKiUH6ykRkA4zn39hDA5KId21GQq5NNPgXq1eVhL3anuwru4ZaHWSkVr8+eHOmAnws5B7iPdcGpGpsZnDB924lItRd5kYn7XIBG4w78qSIYnpaEaU+f7h4OEaZzLP/2y3/9PJIepEjylvri5+sdZWgNO8IDVBZhphEOqMmjKskD8acw2rTZnVXWQ5FaK+2igVb9wpRMTLYtkgrIjlokpj1IJl/2Bs5NTA/p1aSKbCpRlO8uSAzb1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OBQV+Ohgw4rC2MFsKm8LEhBcWsWoUQRtJKI3LqPqGIg=; b=SOlgyZG89Q6jJ2uhT8cjkPJeRstpU7BWXxI4dTOtkLlOyqDuxuqTPS/bCcPN9dX3pVnkYRWGxIp+mAmbHzYfnniPDflMjHz+j7/RssyZlqeOZL0bSssefTerBTQJaNguOvRmqhbE8EBIGxbvzJvwYNdKhMhAt3JUthB9G86y9UamT4XLoV6Ee6StvVYffESw4NAwTUVp2xksuhCTvxsdbN5X1fY9TXUu8kvxE2uEnzr8mb39fnMTkXXSI2okZo3779PPiYkcymR3EjIwRXMs9OhjnRmydL6nOUpx/7rrA6UizXXY+TRiXyuJCdGImFdoXUgLULzWPhbP7QLTg0VrLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OBQV+Ohgw4rC2MFsKm8LEhBcWsWoUQRtJKI3LqPqGIg=; b=PLQ4SsJXBYneDqcbydEbFu4+bE9CHv4DLzD1BuS3xuB4wCwQiFr3M3ke5eQPfxzcT0g5kQ7qsx5JxAeMdkN5o3iiKLwQLzXE2qvA6DUvdDtrT/cy6Ljb/XS/X9ZJiejz46lZAzrOs7wLb1OfdwgffmGZoAiWPXpheQrwXCEHoio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PAXPR04MB8750.eurprd04.prod.outlook.com (2603:10a6:102:20c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sat, 2 Apr 2022 05:23:23 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387%9]) with mapi id 15.20.5123.030; Sat, 2 Apr 2022 05:23:23 +0000 From: Liu Ying To: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm, robert.foss@linaro.org Subject: [PATCH v6 resend 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() Date: Sat, 2 Apr 2022 13:24:47 +0800 Message-Id: <20220402052451.2517469-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220402052451.2517469-1-victor.liu@nxp.com> References: <20220402052451.2517469-1-victor.liu@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI2P153CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::19) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8e59d9e-c2aa-4a94-cbbe-08da1468e839 X-MS-TrafficTypeDiagnostic: PAXPR04MB8750:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m/fpQx1VkOIGpS0qoxkCM+4jgz2N4GavVVxgCx/T4mKOs0Q4ISIxW+5J8QnrvZjHbt5UaBpAAzawoSHjcQc8+5xUGEiauV0VERmVex816/tJcVfK89aAOkBZ+W8LE1t8tEBVXCJ1+4mehrRo9wp/+3HiIa9emZaxT+Wrk1yXrpujjsGpAjLBRoLWPm4RsnbG1By4Vkk75xXpBrTo6F6dluveP5eC8wZjNx1vu5z4YrE26du1rFF/K/53KfqVEJjgEdile6D9X3IkuOhK1U4wHITa0ea2IOmgzhVrd2+PXv/Q9IoJLNaX4nUS8DoIf6gAd3c7eJjp4TqAa5qZQAoIsnvWjEP/xD1AJZywsCU1UHrbvje77xb78FbAJPXVEkolFKg0Pd0KpXWdQi+KqtrpPl9dpSpcdwlqSHBDg000HJUfZ7DkT0/dpLxNJK8foBFwl2Mkzkn3AOQ2cPOFunX9s0ULaHQwCdUZfOfXEi+W83LMlSwnNeY5A1tNBfqpQFhp7YfB0n/aehZ4zRbKEQQm64fSKbquS//WKg5K2oZaUTZvwHOoepkf4Sfey7zhBym1q31XEbaDe4o1sbsBD4WeQpN+phYRa4mL08f056up/+syLgcBJHZEVP1eWh1OX0l+oe2o9syk/jJyODQUDGWyuX9OzoppgQmxtkNVo1FxnGuZ9swHGkt2j3CTiQMr2ZATW/D/jh147JZfEes8jjP7Sg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6486002)(83380400001)(316002)(6512007)(52116002)(186003)(26005)(6666004)(6506007)(1076003)(2616005)(508600001)(7416002)(8936002)(86362001)(38100700002)(5660300002)(38350700002)(2906002)(66476007)(66946007)(4326008)(8676002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVByOGV1REErVjgwTm1tREo5SlFPK1E2U0VENmMxQUxYL2daM2FJTnVlem4x?= =?utf-8?B?ZEsyWXdvSHZTejFvRTlRZHoySS96NHBRUVgvZUpKVkNqMkY5NUdUUTk2L3Rm?= =?utf-8?B?dlpNbmRiRE51T0l2TEpUTWVqekZ0WEJxNTBvcEFVT3VqZkloSkJuV0hncjJL?= =?utf-8?B?bnRsSmtRTlRWV2JqSG1SVGxYYUdLRzVNeHdpSDJScTFBaDk5dFU3NlhseEly?= =?utf-8?B?c1BZSDJralVVVGpDa0FCQnB6WGE3bVlMUzdWVk5XaHpRWEpiWnFHZk1JWGpW?= =?utf-8?B?dmQ5bzJnbDZyR2hGU1paY1lQR1duUWNjNEpFNmx4Q2pQb1N0YnpCa0lKRVBi?= =?utf-8?B?ZThtbkc4aFRSbjZjMUVuY2ViRHVjc0V3VzRnWVI4K1dpbDdBZms1T3hkeTJz?= =?utf-8?B?aEJDTkNudWJkNkQzY0EvUThTL200V1RnRUpVWlR5M1d3UXFqTkhNNll5ZytH?= =?utf-8?B?elU3OUdYZituNXI1RWhOajdYcHNFdmg0TFZHN1FnRnJxRlBDODNDRlowOU9W?= =?utf-8?B?a2JPZVpGa1crbWlQUmZsczQ1TFJ3SFY4UDQ5bGZQaHcvb3hGcGRuK0h4dFRv?= =?utf-8?B?L2VLbjdWMHVXMUMvR1pxdmJaOGs2cU81eW1JbVo4L1lNSjkxVWpsQ3FhSytx?= =?utf-8?B?V1pzRDVxUXkrRlR0TkN1UkNlckpSVE9SbS9IaSsva1JNQnNsQXcrVE00Vzhp?= =?utf-8?B?QXJINnNCWlQxVVpDeEp4d1B5NFNnMnBLWExTNDB5K1lUWllZS1hBK2l0MEVh?= =?utf-8?B?clRiMDgyaWFnVGdscEFvNzNiSi9Xd0RYVStNSXJGemJEY1RMWGxNVklqSEl1?= =?utf-8?B?YUkvbU5LT0t0eWRiUWNxNGhPT3lXMCt3VU5odnBscEpiMVQ3c3V5OUw1S0M1?= =?utf-8?B?MkNUUFp6K3VsWFVuUVloNWE2YmQ3dytPRkFwUWlyUGhYaU1yc05jSVFodmlh?= =?utf-8?B?RUhzQzhNcnFwSUtmNWJRcFdpbjVSMGczS3dRR1RNUDgwcVdtcE82QzNmZSsy?= =?utf-8?B?b3dzOHI4UzdldWlxL0phb28wOGZTVG9GVGgrYnpFRE5kTnJvTlZmaG5XZ3NX?= =?utf-8?B?bUNmeEpRMHJ1UWpIR1lSa0tKaU9IUHBpb21YSWI0VExWUVkvMVAxU0E5Qk93?= =?utf-8?B?RXRSV0FDMnJCazBCWXZvdjlOK0NlZDFONnBkMjAzY2VtbjVQcWNTY0UrYW90?= =?utf-8?B?L2dsMEQ1bzJ3RitKNnBQcmFRS1JVaTRlMHBzb3B0SFpLeUFtaHRXR2piaHZt?= =?utf-8?B?WWh2eldEUDBLbEd6ZlBDeFBQT0RjdGlsZWI5Mjd1a2xieGtxQWQwWkNSNXVq?= =?utf-8?B?TzlpZ25oOHV2RlFzYVlEQS95c2RRbDRTK01Tc3gzbUdIL3lSYVIrVXBBaEdm?= =?utf-8?B?bEN2WVkvMHE4cVoxcHNqZU5VRDhiaVhiWmJHVkgzdmV1UlJ5aGxzQ0h0WWdi?= =?utf-8?B?ZkZiVG9Ba2VUb2NoSWJsQWZlYjdmQmxkQk43VkM0eTJVUzdmc0VXZTZZU05a?= =?utf-8?B?aDJjR29OcHl5aisyd29BaEdjTm0rYjN3aFNPR3JLOHcwUitBZk1JaWRxNXdh?= =?utf-8?B?SDNPeVh5OUdRdk9RME5aY3Z5ME00R2llWERsR05za2tjVDV1VmVvejBGOXNr?= =?utf-8?B?ZmxOZDRXdlJadjkxSmVrYVhyNVVQOHluQm9CeU5GRUl1VjFqcVhPZmhUbWVW?= =?utf-8?B?TXhCTFVPSDRUSnNWSU1xNHBrODkyYThkSExjaWliZnl2Y2ZHcEVuNXY5N2ly?= =?utf-8?B?YlVCdS9NUE1kbmFLcm02aEhPMlNYMEdteUIrZlE4bUQxdnFOT0Z3ZTNIWGF2?= =?utf-8?B?RVlPNllWb00wM0dRdlk1TUh3OFk4WG44QjhKQTZMMnM1S1ZQK0NyZVlBSkhU?= =?utf-8?B?Myt6dEJoKzZVNVdCRnhrWU5ISHRReDM2QXpUbmgvVWU3OVlqYTQ3YXlGU0R0?= =?utf-8?B?QThWZkpjL3ZieVFzV25FckZnZmw2dDdpUVErSTRpbkJMU0t1b2t4SWFaOGda?= =?utf-8?B?TWRmclVTdjNTbHVZT1YxelRtRHA4RTZMTG0ralhOZVhCZElFVDVmM3ZaaGV5?= =?utf-8?B?QlJQNmxub0NobkZSd0tFUFVaNnNHZkFqZFltQXROWFFTTHdDYXVmK0NhZy91?= =?utf-8?B?ZC92MlhscGlRd0dNTXV0aTd3WXhONUNVOElKbUtrMGY2SWNiZFBKRitpb3hO?= =?utf-8?B?TUFwOHNDNThaN3RhenA0bXpaTitoeUxNS2UxWjhsTjkyTWtJNjllSHNnY0ow?= =?utf-8?B?bFpkWFpQZkF5RTIwWUpiUWFpczdZdm1kbFh0V0VMSVkvYVVaVmxoVzBCVFBS?= =?utf-8?B?WHF4ckVBYXlncUo5TENabGJDTjh3ZTZMWW1kKzI5SVJSR29oWWxudz09?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8e59d9e-c2aa-4a94-cbbe-08da1468e839 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:23:23.4258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qVdg6uXkeef2iRHM7HVNZiVicbW1A3f3cXzBwQBca2y3nAnb6BLZRe4IOn6RhHSMHfDcUuhoLNzKK2xEhRECMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8750 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase the series upon v5.17-rc1. * Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi bridge driver due to the rebase. * Drop Guido's R-b tag due to the rebase. * Resend with Andrzej's and Jernej's mail addressed updated. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * Add Guido's R-b tag. drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index a7389a0facfb..5fbfc68a46a5 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -673,6 +673,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi) return ret; } + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); + if (ret < 0) { + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret); + goto uninit_phy; + } + ret = phy_configure(dsi->phy, phy_cfg); if (ret < 0) { DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret); -- 2.25.1