From: Jason Gunthorpe <jgg@nvidia.com>
To: Guo Zhengkui <guozhengkui@vivo.com>
Cc: Mustafa Ismail <mustafa.ismail@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Yishai Hadas <yishaih@nvidia.com>,
"open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA"
<linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
zhengkui_guo@outlook.com
Subject: Re: [PATCH linux-next v2] RDMA: simplify if-if to if-else
Date: Mon, 4 Apr 2022 10:56:09 -0300 [thread overview]
Message-ID: <20220404135609.GA2911054@nvidia.com> (raw)
In-Reply-To: <20220331130525.14750-1-guozhengkui@vivo.com>
On Thu, Mar 31, 2022 at 09:05:25PM +0800, Guo Zhengkui wrote:
> @@ -632,7 +632,7 @@ static int handle_join_req(struct mcast_group *group, u8 join_mask,
> kfree(req);
> ref = 1;
> group->state = group->prev_state;
> - } else
> + } else {
> group->state = MCAST_JOIN_SENT;
> }
This doesn't compile.
Jason
prev parent reply other threads:[~2022-04-04 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 13:08 [PATCH linux-next] RDMA: simplify if-if to if-else Guo Zhengkui
2022-03-30 11:02 ` Leon Romanovsky
2022-03-30 11:06 ` Haakon Bugge
2022-03-30 11:32 ` Leon Romanovsky
2022-03-30 12:26 ` Haakon Bugge
2022-03-30 12:56 ` Leon Romanovsky
2022-03-31 3:03 ` Guo Zhengkui
2022-03-31 9:05 ` Leon Romanovsky
2022-03-31 13:05 ` [PATCH linux-next v2] " Guo Zhengkui
2022-03-31 13:58 ` Saleem, Shiraz
2022-04-04 13:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404135609.GA2911054@nvidia.com \
--to=jgg@nvidia.com \
--cc=guozhengkui@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
--cc=yishaih@nvidia.com \
--cc=zhengkui_guo@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).