From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Make headphone work on Huawei Matebook D15
Date: Tue, 5 Apr 2022 15:48:16 +0200 [thread overview]
Message-ID: <20220405154816.5cfdc49c@coco.lan> (raw)
In-Reply-To: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com>
Em Tue, 5 Apr 2022 11:00:44 +0200
Hans de Goede <hdegoede@redhat.com> escreveu:
> Hi,
>
> On 4/5/22 10:44, Mauro Carvalho Chehab wrote:
> > At Huawei Matebook D15 two different GPIOs are used to control the output:
> > - gpio0 controls the speaker output;
> > - gpio1 controls the headphone output.
> >
> > Changing both at the same time cause spurious events that are mis-interpreted
> > as input events, causing troubles on apps. So, a delay is needed before turning
> > on such gpios.
> >
> > With this patch, plugging a headphone causes a jack event to trigger the speaker
> > supply, powering down the speaker and powering up the headphone output.
> > Removing the headphone also triggers the power supply, powering up the speaker
> > and powering down the headphone.
> >
> > Mauro Carvalho Chehab (2):
> > ASoC: Intel: sof_es8336: support a separate gpio to control headphone
> > ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio
>
> There is something weird with the patches here, at least for me in Thunderbird
> both patches show up as nameless attachments to emails with empty bodies.
Weird... I tested here on Thunderbird (Fedora 35), reading it from the ML
and they opened ok here.
There *is* an issue on such patches though: they ended using my past
e-mail :-)
I'll re-send those with your ack using the right SoB/From
mchehab@kernel.org.
>
> After saving the attachments the patches look good to me, so:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Thanks!
Regards,
Mauro
next prev parent reply other threads:[~2022-04-05 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 8:44 [PATCH v2 0/2] Make headphone work on Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-05 8:44 ` [PATCH v2 1/2] ASoC: Intel: sof_es8336: support a separate gpio to control headphone Mauro Carvalho Chehab
2022-04-05 14:57 ` Pierre-Louis Bossart
2022-04-05 15:37 ` Mauro Carvalho Chehab
2022-04-05 8:44 ` [PATCH v2 2/2] ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio Mauro Carvalho Chehab
2022-04-05 9:00 ` [PATCH v2 0/2] Make headphone work on Huawei Matebook D15 Hans de Goede
2022-04-05 13:48 ` Mauro Carvalho Chehab [this message]
2022-04-05 13:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405154816.5cfdc49c@coco.lan \
--to=mchehab@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).