From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4BBC433FE for ; Wed, 6 Apr 2022 16:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238037AbiDFQsg (ORCPT ); Wed, 6 Apr 2022 12:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238377AbiDFQrq (ORCPT ); Wed, 6 Apr 2022 12:47:46 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9342747D93E; Wed, 6 Apr 2022 07:10:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6D8EECE23F3; Wed, 6 Apr 2022 14:10:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10884C385A1; Wed, 6 Apr 2022 14:10:06 +0000 (UTC) Date: Wed, 6 Apr 2022 10:10:05 -0400 From: Steven Rostedt To: Greg Kroah-Hartman Cc: Guenter Roeck , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, slade@sladewatkins.com, Sasha Levin Subject: Re: [PATCH 5.10 000/599] 5.10.110-rc1 review Message-ID: <20220406101005.25d1f915@gandalf.local.home> In-Reply-To: References: <20220405070258.802373272@linuxfoundation.org> <20220406010749.GA1133386@roeck-us.net> <20220406023025.GA1926389@roeck-us.net> <20220405225212.061852f9@gandalf.local.home> <20220405230812.2feca4ed@gandalf.local.home> <20220405232413.6b38e966@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Apr 2022 10:26:15 +0200 Greg Kroah-Hartman wrote: > Wait, no, I did catch this! And I sent you a "FAILED" email about it, 4 > of them: > https://lore.kernel.org/r/164905985821176@kroah.com > https://lore.kernel.org/r/16490598521299@kroah.com > https://lore.kernel.org/r/1649059845215213@kroah.com > https://lore.kernel.org/r/16490598398133@kroah.com > as the commit applied, but broke the build: Yes, I know, that's how I knew it was an issue ;-) > > But I didn't drop the offending commit, I should have done that. Correct. Oh, so I guess it got in because it applied, but broke the build. Thus, your scripts catch when a Fixes does not apply, but doesn't handle the "broken build / boot" case? > > I'll go and drop the offending commit here, if you could submit both of > them as working backports to stable@vger if/when you want them queued up > there, that would be great. The patch that got backported only fixes an issue with new events (hence why I did not mark it for stable). If those events are not backported, there's no reason to backport this one. -- Steve