From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405ABC433FE for ; Thu, 7 Apr 2022 12:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245439AbiDGMur (ORCPT ); Thu, 7 Apr 2022 08:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232249AbiDGMuc (ORCPT ); Thu, 7 Apr 2022 08:50:32 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9245692D38 for ; Thu, 7 Apr 2022 05:48:32 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id r13so7679188wrr.9 for ; Thu, 07 Apr 2022 05:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kVP0DeosChaP4vnFzIKGWwoOlpAbwuSOyH45+/mZoL0=; b=WJ+kAroNj7E7A5y908A71aFJJj+nAvEUf4Ay0YLozhvoTHYxB902LFt2Od7TY10Wl4 MDtb0HNH2KI/aBYiddHdz1k5GRwnn5f0NxSBI/KuW8tYFoLP3fb7MV7vZs4Os7EQarFN Dgs0YtQuP/Xuvpln1PFj/fDipk+nDKU5ckItz0m02ENbvnF8DuxySx8L9k9muCsMTORC AOsHmomnvr2/rP0bfrxp7bPq9QSMKEOoWHbW/JLLg0fQjhDOgJu/5bKzY34INCmn6LgK cUnRng5ayAzLyosP4ozBSF4L8uDB0FEaAlbbZiozeQWVnCoBO1Oa7znXd0VU+IHOEkvq tevg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kVP0DeosChaP4vnFzIKGWwoOlpAbwuSOyH45+/mZoL0=; b=rDjawmT1n7X3StXOrgeaLvze3fTARfQRMU4U0PVgtJGeq8sOS016wZH0yO50Tvjr9s Y0E3u27/vhmpQpMEnpMXIg0uSOy/FVst3STHF4vpXZfx8jmBsRh9KbLTTqDjQ6gtRTj6 rkZD80A0kxshWbmJCWcr7Fs789o+u/sbTctLveZY02YdTGmndaKdqj31JXZx0ytJFSnX d3S3y5yZMIb7WGI8uJosKebODeYsnRAeg8gOg0+WmOJdOUeEs4yVD+C//PeUW4db8Za/ nb9b959piLNzP0DP7h4FmeyA0TwN53hkRagmVx7vysNyXQJV94QcZ5CJ+A3ss6rrz+Lp BQpw== X-Gm-Message-State: AOAM530AUJ+NtncoCj30dtbBlprIuq4tcQfltWJBBs+OlACr1B1p4RMM 8fXB7fpjWslvFWDl3Nm7mpQ= X-Google-Smtp-Source: ABdhPJwcz9vVn9c0DLHAhAgTiD1FsFIPhhJ34CoOVsuCWnlvNQU1WIQX8uuwY6ONIZ02Z+NbDhdpng== X-Received: by 2002:adf:d1e3:0:b0:204:7e76:8a70 with SMTP id g3-20020adfd1e3000000b002047e768a70mr11019097wrd.580.1649335711115; Thu, 07 Apr 2022 05:48:31 -0700 (PDT) Received: from alaa-emad ([197.57.231.245]) by smtp.gmail.com with ESMTPSA id n23-20020a05600c3b9700b0038b7c4c0803sm8172229wms.30.2022.04.07.05.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 05:48:30 -0700 (PDT) From: Alaa Mohamed To: outreachy@lists.linux.dev Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, eng.alaamohamedsoliman.am@gmail.com Subject: [PATCH v4] staging: rtl8712: remove unnecessary parentheses Date: Thu, 7 Apr 2022 14:48:17 +0200 Message-Id: <20220407124817.7714-1-eng.alaamohamedsoliman.am@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reported by checkpatch: Remove unnecessary parentheses around structure field references Signed-off-by: Alaa Mohamed --- Changes in v2: - Edit commit subject - Edit commit message - Fix the same check in more lines - Remove space before '.skey' in "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86. --- Changes in v3: return the space before '.skey' in "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86 --- Changes in v4: edit commit message to be clearer. --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index 3b6926613257..f1e352b7f83e 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta, (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len)); if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */ memcpy(psta->tkiptxmickey. skey, - &(param->u.crypt.key[16]), 8); + ¶m->u.crypt.key[16], 8); memcpy(psta->tkiprxmickey. skey, - &(param->u.crypt.key[24]), 8); + ¶m->u.crypt.key[24], 8); padapter->securitypriv. busetkipkey = false; mod_timer(&padapter->securitypriv.tkip_timer, jiffies + msecs_to_jiffies(50)); @@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev, u32 ht_ielen = 0; char *p; u8 ht_cap = false; - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network; u8 *prates; @@ -1494,7 +1494,7 @@ static int r8711_wx_set_enc(struct net_device *dev, u32 keyindex_provided; struct NDIS_802_11_WEP wep; enum NDIS_802_11_AUTHENTICATION_MODE authmode; - struct iw_point *erq = &(wrqu->encoding); + struct iw_point *erq = &wrqu->encoding; struct _adapter *padapter = netdev_priv(dev); key = erq->flags & IW_ENCODE_INDEX; @@ -1589,8 +1589,8 @@ static int r8711_wx_get_enc(struct net_device *dev, { uint key; struct _adapter *padapter = netdev_priv(dev); - struct iw_point *erq = &(wrqu->encoding); - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); + struct iw_point *erq = &wrqu->encoding; + struct mlme_priv *pmlmepriv = &padapter->mlmepriv; union Keytype *dk = padapter->securitypriv.DefKey; if (!check_fwstate(pmlmepriv, _FW_LINKED)) { @@ -1670,7 +1670,7 @@ static int r871x_wx_set_auth(struct net_device *dev, union iwreq_data *wrqu, char *extra) { struct _adapter *padapter = netdev_priv(dev); - struct iw_param *param = (struct iw_param *)&(wrqu->param); + struct iw_param *param = (struct iw_param *)&wrqu->param; int paramid; int paramval; int ret = 0; @@ -1964,7 +1964,7 @@ static int r871x_get_ap_info(struct net_device *dev, return -EINVAL; data[32] = 0; - spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL); + spin_lock_irqsave(&pmlmepriv->scanned_queue.lock, irqL); phead = &queue->queue; plist = phead->next; while (1) { @@ -1974,7 +1974,7 @@ static int r871x_get_ap_info(struct net_device *dev, if (!mac_pton(data, bssid)) { netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n", (u8 *)data); - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); return -EINVAL; } @@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev, } plist = plist->next; } - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL); + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); if (pdata->length >= 34) { if (copy_to_user((u8 __user *)pdata->pointer + 32, (u8 *)&pdata->flags, 1)) -- 2.35.1