From: Dongliang Mu <dzm91@hust.edu.cn>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: Dongliang Mu <mudongliangabcd@gmail.com>,
syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr
Date: Fri, 8 Apr 2022 13:22:06 +0800 [thread overview]
Message-ID: <20220408052207.209856-1-dzm91@hust.edu.cn> (raw)
From: Dongliang Mu <mudongliangabcd@gmail.com>
In f2fs_is_valid_blkaddr, if type is DATA_GENERIC_ENHANCE or
DATA_GENERIC_ENHANCE_READ, it invokes WARN_ON(1) not matter
blkaddr is in the range or not.
Fix this by removing WARN_ON.
Note that, syzbot patch testing does not incur any further issues
Reported-by: syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
fs/f2fs/checkpoint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index f5366feea82d..521498b2dd8c 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -158,7 +158,6 @@ static bool __is_bitmap_valid(struct f2fs_sb_info *sbi, block_t blkaddr,
f2fs_err(sbi, "Inconsistent error blkaddr:%u, sit bitmap:%d",
blkaddr, exist);
set_sbi_flag(sbi, SBI_NEED_FSCK);
- WARN_ON(1);
}
return exist;
}
@@ -196,7 +195,6 @@ bool f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi,
f2fs_warn(sbi, "access invalid blkaddr:%u",
blkaddr);
set_sbi_flag(sbi, SBI_NEED_FSCK);
- WARN_ON(1);
return false;
} else {
return __is_bitmap_valid(sbi, blkaddr, type);
--
2.25.1
next reply other threads:[~2022-04-08 5:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 5:22 Dongliang Mu [this message]
2022-04-09 0:27 ` [PATCH] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr Chao Yu
2022-04-09 1:34 ` Dongliang Mu
2022-04-09 3:46 ` Chao Yu
2022-04-09 6:42 ` Dongliang Mu
2022-04-11 3:09 ` [f2fs-dev] " Chao Yu
2022-04-11 5:06 ` Dongliang Mu
2022-04-11 6:14 ` Eric Biggers
2022-04-11 9:53 ` Chao Yu
2022-04-12 9:25 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408052207.209856-1-dzm91@hust.edu.cn \
--to=dzm91@hust.edu.cn \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).