From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE59C433EF for ; Fri, 8 Apr 2022 05:44:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235012AbiDHFq4 (ORCPT ); Fri, 8 Apr 2022 01:46:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234938AbiDHFqt (ORCPT ); Fri, 8 Apr 2022 01:46:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1BD381115A for ; Thu, 7 Apr 2022 22:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649396686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ECU0ZzpjTJbsqM/06UoyAixb0uPdjMhcy626dlK3x2E=; b=bz7FeliUPUe4kgyyYvcGVdeT0ccw3b8xLaWco+7Vocq2ecfBFQQ28lgRMNoKl3K1knl6U3 ZBgzP29tKxtrOeMdICbYbsYmO1H+otfV5dHJbkqmFRTjQLsJVW9Hf4Ei86TY6SsbDlwXC4 f38d5fDBLFmCtVkISVXwWmit7PcdlPs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-214-C99I_CuvODqQgjWAZRPPNg-1; Fri, 08 Apr 2022 01:44:39 -0400 X-MC-Unique: C99I_CuvODqQgjWAZRPPNg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9CDDF80159B; Fri, 8 Apr 2022 05:44:33 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.40.208.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 912AC401475; Fri, 8 Apr 2022 05:44:30 +0000 (UTC) Date: Fri, 8 Apr 2022 07:44:24 +0200 From: Stefano Brivio To: Greg Kroah-Hartman , Jaehee Park Cc: =?UTF-8?B?SsOpcsO0bWU=?= Pouiller , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Alison Schofield Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif Message-ID: <20220408074424.6e862f3f@elisabeth> In-Reply-To: References: <20220408032349.GA2132476@jaehee-ThinkPad-X1-Extreme> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg, On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman wrote: > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote: > > > > [...] > > > > @@ -61,7 +63,6 @@ struct wfx_dev { > > =20 > > struct wfx_vif { > > struct wfx_dev *wdev; > > - struct ieee80211_vif *vif; =20 >=20 > You need to test this on real hardware. For an outreachy-first-task, > this is not a good one at all. We discussed about this on the outreachy list, and I suggested, as Jaehee also mentioned, that maybe somebody (J=C3=A9r=C3=B4me?) with the har= dware could give it a try. It looks a bit difficult but it also looks almost correctly done now. :) > Also this code is no longer in drivers/staging/ Please work on the > netdev mailing list as I can not take these changes anymore. Yeah, missed by a couple of days... Jaehee, the list is actually linux-wireless for this one: https://wireless.wiki.kernel.org/en/developers/mailinglists And the tree (my bad for mentioning net-next earlier) is actually wireless-next: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/ --=20 Stefano