From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: song@kernel.org
Cc: guoqing.jiang@linux.dev, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, rgoldwyn@suse.com,
stable@vger.kernel.org, xiam0nd.tong@gmail.com
Subject: Re: [PATCH v2] md: fix an incorrect NULL check in sync_sbs
Date: Fri, 8 Apr 2022 16:39:35 +0800 [thread overview]
Message-ID: <20220408083935.25816-1-xiam0nd.tong@gmail.com> (raw)
In-Reply-To: <CAPhsuW6S=PJsgVR=OkObMvs9uJ2QA3LFe+ZH8XtEyKRFh7XxHA@mail.gmail.com>
On Thu, 7 Apr 2022 17:36:48 -0700, Song Liu wrote:
> On Mon, Mar 28, 2022 at 1:11 AM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
> >
> > The bug is here:
> > if (!rdev)
> >
> > The list iterator value 'rdev' will *always* be set and non-NULL
> > by rdev_for_each(), so it is incorrect to assume that the iterator
> > value will be NULL if the list is empty or no element found.
> > Otherwise it will bypass the NULL check and lead to invalid memory
> > access passing the check.
> >
> > To fix the bug, use a new variable 'iter' as the list iterator,
> > while using the original variable 'pdev' as a dedicated pointer to
>
> s/pdev/rdev/
>
Have fixed it in PATCH v3, please check it. Thank you.
>
> > point to the found element.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 2aa82191ac36c ("md-cluster: Perform a lazy update")
>
> "Fixes" should use a hash of 12 characters (13 given here). Did
> checkpatch.pl complain about it?
Have fixed it in PATCH v3, please check it. Thank you.
--
Xiaomeng Tong
prev parent reply other threads:[~2022-04-08 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:11 [PATCH v2] md: fix an incorrect NULL check in sync_sbs Xiaomeng Tong
2022-04-08 0:36 ` Song Liu
2022-04-08 8:39 ` Xiaomeng Tong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408083935.25816-1-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=guoqing.jiang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).