* [PATCH] perf tools: Fix perf's libperf_print callback
@ 2022-04-08 13:26 Adrian Hunter
2022-04-09 15:16 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Hunter @ 2022-04-08 13:26 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, linux-kernel
eprintf does not expect va_list as the 4th parameter.
Use veprintf because it does.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 2f6b67189b42..6aae7b6c376b 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
static int libperf_print(enum libperf_print_level level,
const char *fmt, va_list ap)
{
- return eprintf(level, verbose, fmt, ap);
+ return veprintf(level, verbose, fmt, ap);
}
int main(int argc, const char **argv)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: Fix perf's libperf_print callback
2022-04-08 13:26 [PATCH] perf tools: Fix perf's libperf_print callback Adrian Hunter
@ 2022-04-09 15:16 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-04-09 15:16 UTC (permalink / raw)
To: Adrian Hunter; +Cc: Jiri Olsa, linux-kernel
Em Fri, Apr 08, 2022 at 04:26:25PM +0300, Adrian Hunter escreveu:
> eprintf does not expect va_list as the 4th parameter.
> Use veprintf because it does.
You forgot to add this:
Fixes: 428dab813a56ce94 ("libperf: Merge libperf_set_print() into libperf_init()")
Please consider doing it next time.
Thanks, applied.
- Arnaldo
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/perf.c b/tools/perf/perf.c
> index 2f6b67189b42..6aae7b6c376b 100644
> --- a/tools/perf/perf.c
> +++ b/tools/perf/perf.c
> @@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
> static int libperf_print(enum libperf_print_level level,
> const char *fmt, va_list ap)
> {
> - return eprintf(level, verbose, fmt, ap);
> + return veprintf(level, verbose, fmt, ap);
> }
>
> int main(int argc, const char **argv)
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-09 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 13:26 [PATCH] perf tools: Fix perf's libperf_print callback Adrian Hunter
2022-04-09 15:16 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).