From: "Paul E. McKenney" <paulmck@kernel.org>
To: Hillf Danton <hdanton@sina.com>
Cc: Kalesh Singh <kaleshsingh@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] EXP rcu: Move expedited grace period (GP) work to RT kthread_worker
Date: Sat, 9 Apr 2022 08:56:12 -0700 [thread overview]
Message-ID: <20220409155612.GO4285@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220409071740.6024-1-hdanton@sina.com>
On Sat, Apr 09, 2022 at 03:17:40PM +0800, Hillf Danton wrote:
> On Fri, 8 Apr 2022 10:53:53 -0700 Kalesh Singh wrote
> > Thanks for the discussion everyone.
> >
> > We didn't fully switch to kthread workers to avoid changing the
> > behavior for users that dont need this low latency exp GPs. Another
> > (and perhaps more important) reason is because kthread_worker offers
> > reduced concurrency than workqueues which Pual reported can pose
> > issues on systems with a large number of CPUs.
>
> A second ... what issues were reported wrt concurrency, given the output
> of grep -nr workqueue block mm drivers.
>
> Feel free to post a URL link to the issues.
The issues can be easily seen by inspecting kthread_queue_work() and
the functions that it invokes. In contrast, normal workqueues uses
per-CPU mechanisms to avoid contention, as can equally easily be seen
by inspecting queue_work_on() and the functions that it invokes.
Please do feel free to take a look.
If taking a look does not convince you, please construct some in-kernel
benchmarks to test the scalability of these two mechanisms. Please note
that some care will be required to make sure that you are doing a valid
apples-to-apples comparison.
Thanx, Paul
next prev parent reply other threads:[~2022-04-09 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 4:57 [PATCH v2] EXP rcu: Move expedited grace period (GP) work to RT kthread_worker Kalesh Singh
2022-04-08 10:21 ` Joel Fernandes
2022-04-08 15:25 ` Paul E. McKenney
2022-04-08 15:39 ` Steven Rostedt
2022-04-08 15:58 ` Paul E. McKenney
2022-04-08 21:27 ` Steven Rostedt
2022-04-08 10:42 ` Joel Fernandes
2022-04-08 14:34 ` Paul E. McKenney
2022-04-08 14:41 ` Joel Fernandes
2022-04-08 15:34 ` Paul E. McKenney
2022-04-08 17:14 ` Joel Fernandes
2022-04-08 17:39 ` Paul E. McKenney
2022-04-08 17:53 ` Kalesh Singh
2022-04-08 21:42 ` Steven Rostedt
2022-04-08 22:06 ` Kalesh Singh
[not found] ` <20220409071740.6024-1-hdanton@sina.com>
2022-04-09 15:56 ` Paul E. McKenney [this message]
[not found] ` <20220413113711.1263-1-hdanton@sina.com>
2022-04-13 14:07 ` Paul E. McKenney
2022-04-13 17:21 ` Joel Fernandes
2022-04-13 18:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409155612.GO4285@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=hdanton@sina.com \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).