From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0B7C433EF for ; Sat, 9 Apr 2022 11:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241657AbiDILlT (ORCPT ); Sat, 9 Apr 2022 07:41:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238441AbiDILlP (ORCPT ); Sat, 9 Apr 2022 07:41:15 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BEAD6565 for ; Sat, 9 Apr 2022 04:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649504348; x=1681040348; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=f4JJrb0SZ08czHL0/SY43nKxcE+oJ/SvBU95M3SBJ4k=; b=oAthf0AZZ5T8QT/aa2ArhOzP5J/VRxnt82WY4kZLX02igvOVbLwgTfBf kqMeTDaEFNLNC3A52mTCU1KJKNmqG3tRN+DKbTkV5G/Up0YxiJtwm+RfP Wv5lC22WRbfRCh5Ys+/fhYa8sBFh2NyYi7i1Xr4ALbMN4kNTFkGWXeEq1 OOj4UtYHwO2LZsJEOzhYfKNmOdSOPVGQ4KJr86vCujgQXTHusUqSYyXsG CVBDfeJDGszEHNzXCO28Y09FM9LjqaOkJZCeLQROWbbaQ0vbltrTMc9MP MebaWP8wZHSLjAJla/jDqWKe3RO1QNcqLJe2xaNH3sPY8CTnz39csi+mk w==; X-IronPort-AV: E=McAfee;i="6400,9594,10311"; a="260636922" X-IronPort-AV: E=Sophos;i="5.90,247,1643702400"; d="scan'208";a="260636922" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2022 04:39:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,247,1643702400"; d="scan'208";a="653707027" Received: from lkp-server02.sh.intel.com (HELO 7e80bc2a00a0) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 09 Apr 2022 04:39:03 -0700 Received: from kbuild by 7e80bc2a00a0 with local (Exim 4.95) (envelope-from ) id 1nd9Ql-00017t-2O; Sat, 09 Apr 2022 11:39:03 +0000 Date: Sat, 9 Apr 2022 19:38:55 +0800 From: kernel test robot To: Miaohe Lin , akpm@linux-foundation.org Cc: kbuild-all@lists.01.org, mike.kravetz@oracle.com, shy828301@gmail.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com, minchan@kernel.org, apopple@nvidia.com, dave.hansen@linux.intel.com, o451686892@gmail.com, jhubbard@nvidia.com, peterx@redhat.com, naoya.horiguchi@nec.com, mhocko@suse.com, riel@redhat.com, osalvador@suse.de, david@redhat.com, sfr@canb.auug.org.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linmiaohe@huawei.com Subject: Re: [PATCH 4/4] mm/migration: fix potential pte_unmap on an not mapped pte Message-ID: <202204091914.psVO4TrI-lkp@intel.com> References: <20220409073846.22286-5-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409073846.22286-5-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miaohe, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] [also build test ERROR on linus/master v5.18-rc1 next-20220408] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/A-few-cleanup-and-fixup-patches-for-migration/20220409-154028 base: https://github.com/hnaz/linux-mm master config: powerpc64-randconfig-r015-20220408 (https://download.01.org/0day-ci/archive/20220409/202204091914.psVO4TrI-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/73a982570cc62313c55cc5cbc2dd7acf40601474 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Miaohe-Lin/A-few-cleanup-and-fixup-patches-for-migration/20220409-154028 git checkout 73a982570cc62313c55cc5cbc2dd7acf40601474 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): arch/powerpc/mm/hugetlbpage.c: In function 'follow_huge_pd': >> arch/powerpc/mm/hugetlbpage.c:537:25: error: too few arguments to function '__migration_entry_wait' 537 | __migration_entry_wait(mm, ptep, ptl); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from arch/powerpc/mm/hugetlbpage.c:20: include/linux/swapops.h:233:13: note: declared here 233 | extern void __migration_entry_wait(struct mm_struct *mm, pte_t *ptep, | ^~~~~~~~~~~~~~~~~~~~~~ vim +/__migration_entry_wait +537 arch/powerpc/mm/hugetlbpage.c ^1da177e4c3f41 arch/ppc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16 507 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 508 struct page *follow_huge_pd(struct vm_area_struct *vma, 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 509 unsigned long address, hugepd_t hpd, 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 510 int flags, int pdshift) 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 511 { 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 512 pte_t *ptep; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 513 spinlock_t *ptl; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 514 struct page *page = NULL; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 515 unsigned long mask; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 516 int shift = hugepd_shift(hpd); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 517 struct mm_struct *mm = vma->vm_mm; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 518 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 519 retry: ed515b6898c367 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2018-06-01 520 /* ed515b6898c367 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2018-06-01 521 * hugepage directory entries are protected by mm->page_table_lock ed515b6898c367 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2018-06-01 522 * Use this instead of huge_pte_lockptr ed515b6898c367 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2018-06-01 523 */ 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 524 ptl = &mm->page_table_lock; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 525 spin_lock(ptl); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 526 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 527 ptep = hugepte_offset(hpd, address, pdshift); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 528 if (pte_present(*ptep)) { 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 529 mask = (1UL << shift) - 1; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 530 page = pte_page(*ptep); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 531 page += ((address & mask) >> PAGE_SHIFT); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 532 if (flags & FOLL_GET) 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 533 get_page(page); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 534 } else { 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 535 if (is_hugetlb_entry_migration(*ptep)) { 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 536 spin_unlock(ptl); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 @537 __migration_entry_wait(mm, ptep, ptl); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 538 goto retry; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 539 } 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 540 } 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 541 spin_unlock(ptl); 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 542 return page; 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 543 } 50791e6de0b5f2 arch/powerpc/mm/hugetlbpage.c Aneesh Kumar K.V 2017-07-06 544 -- 0-DAY CI Kernel Test Service https://01.org/lkp