From: Sudeep Holla <sudeep.holla@arm.com>
To: Qing Wang <wangqing@vivo.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch_topology: Do not set llc_sibling if llc_id is invalid
Date: Mon, 11 Apr 2022 09:37:36 +0100 [thread overview]
Message-ID: <20220411083736.hrpgndcwuvtsgnhc@bogus> (raw)
In-Reply-To: <1649644580-54626-1-git-send-email-wangqing@vivo.com>
Hi Qing,
On Sun, Apr 10, 2022 at 07:36:19PM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> When ACPI is not enabled, cpuid_topo->llc_id = cpu_topo->llc_id = -1, which
> will set llc_sibling 0xff(...), this is misleading.
>
> Don't set llc_sibling(default 0) if we don't know the cache topology.
>
Makes sense to me and thanks for splitting the patch and pointing this out
clearly. Your earlier patches mixed other things and made it hard to highlight
this one.
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Hi Greg,
Can you pick this up ? IMO It can go as fix in -rc as it is kind of
misleading though I am not sure if it is breaking any platform.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-04-11 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 2:36 [PATCH] arch_topology: Do not set llc_sibling if llc_id is invalid Qing Wang
2022-04-11 8:37 ` Sudeep Holla [this message]
2022-04-11 9:32 ` Greg Kroah-Hartman
2022-04-11 15:07 ` Andy Shevchenko
2022-04-12 8:58 ` Sudeep Holla
-- strict thread matches above, loose matches on Subject: below --
2022-03-28 7:24 Qing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411083736.hrpgndcwuvtsgnhc@bogus \
--to=sudeep.holla@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).