linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node
@ 2022-04-11 10:01 Aidan MacDonald
  2022-04-11 12:41 ` Zhou Yanjie
  0 siblings, 1 reply; 4+ messages in thread
From: Aidan MacDonald @ 2022-04-11 10:01 UTC (permalink / raw)
  To: robh+dt, krzk+dt; +Cc: paul, linux-mips, devicetree, linux-kernel

Copied from the jz4740 devicetree and trimmed to 5 timers, which
is what the hardware supports.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
 arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
index 8bd27edef216..0dcf37527c8e 100644
--- a/arch/mips/boot/dts/ingenic/x1000.dtsi
+++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
@@ -127,6 +127,19 @@ wdt: watchdog@0 {
 			clocks = <&tcu TCU_CLK_WDT>;
 			clock-names = "wdt";
 		};
+
+		pwm: pwm@40 {
+			compatible = "ingenic,x1000-pwm";
+			reg = <0x40 0x80>;
+
+			#pwm-cells = <3>;
+
+			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
+				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
+				 <&tcu TCU_CLK_TIMER4>;
+			clock-names = "timer0", "timer1", "timer2",
+				      "timer3", "timer4";
+		};
 	};
 
 	rtc: rtc@10003000 {
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node
  2022-04-11 10:01 [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node Aidan MacDonald
@ 2022-04-11 12:41 ` Zhou Yanjie
  2022-04-11 15:47   ` Aidan MacDonald
  0 siblings, 1 reply; 4+ messages in thread
From: Zhou Yanjie @ 2022-04-11 12:41 UTC (permalink / raw)
  To: Aidan MacDonald, robh+dt, krzk+dt
  Cc: paul, linux-mips, devicetree, linux-kernel

Hi Aidan,

On 2022/4/11 下午6:01, Aidan MacDonald wrote:
> Copied from the jz4740 devicetree and trimmed to 5 timers, which
> is what the hardware supports.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>   arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 8bd27edef216..0dcf37527c8e 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -127,6 +127,19 @@ wdt: watchdog@0 {
>   			clocks = <&tcu TCU_CLK_WDT>;
>   			clock-names = "wdt";
>   		};
> +
> +		pwm: pwm@40 {
> +			compatible = "ingenic,x1000-pwm";
> +			reg = <0x40 0x80>;


It seems more reasonable to use "reg = <0x40 0x80>" since the
X1000 has only 5 PWM channels.


> +
> +			#pwm-cells = <3>;
> +
> +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
> +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
> +				 <&tcu TCU_CLK_TIMER4>;
> +			clock-names = "timer0", "timer1", "timer2",
> +				      "timer3", "timer4";


One line is now allowed to hold at most 100 characters,
so it is possible to use only one line like:

         clock-names = "timer0", "timer1", "timer2", "timer3", "timer4";

to reduce the number of lines in the dtsi file.


Thanks and best regards!


> +		};
>   	};
>   
>   	rtc: rtc@10003000 {

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node
  2022-04-11 12:41 ` Zhou Yanjie
@ 2022-04-11 15:47   ` Aidan MacDonald
  2022-04-11 16:08     ` Zhou Yanjie
  0 siblings, 1 reply; 4+ messages in thread
From: Aidan MacDonald @ 2022-04-11 15:47 UTC (permalink / raw)
  To: Zhou Yanjie; +Cc: devicetree, krzk+dt, linux-kernel, linux-mips, paul, robh+dt

On Mon, Apr 11, 2022 at 08:41:26PM +0800, Zhou Yanjie wrote:
> Hi Aidan,
> 
> On 2022/4/11 下午6:01, Aidan MacDonald wrote:
> > Copied from the jz4740 devicetree and trimmed to 5 timers, which
> > is what the hardware supports.
> >
> > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> > ---
> >   arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > index 8bd27edef216..0dcf37527c8e 100644
> > --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> > +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > @@ -127,6 +127,19 @@ wdt: watchdog@0 {
> >   			clocks = <&tcu TCU_CLK_WDT>;
> >   			clock-names = "wdt";
> >   		};
> > +
> > +		pwm: pwm@40 {
> > +			compatible = "ingenic,x1000-pwm";
> > +			reg = <0x40 0x80>;
> 
> 
> It seems more reasonable to use "reg = <0x40 0x80>" since the
> X1000 has only 5 PWM channels.

I think you mean "reg = <0x40 0x60>" but I'll do that, thanks!

> > +
> > +			#pwm-cells = <3>;
> > +
> > +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
> > +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
> > +				 <&tcu TCU_CLK_TIMER4>;
> > +			clock-names = "timer0", "timer1", "timer2",
> > +				      "timer3", "timer4";
> 
> 
> One line is now allowed to hold at most 100 characters,
> so it is possible to use only one line like:
> 
>          clock-names = "timer0", "timer1", "timer2", "timer3", "timer4";
> 
> to reduce the number of lines in the dtsi file.

Sounds good to me.

> 
> 
> Thanks and best regards!
> 
> 
> > +		};
> >   	};
> >   
> >   	rtc: rtc@10003000 {

Regards,
Aidan

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node
  2022-04-11 15:47   ` Aidan MacDonald
@ 2022-04-11 16:08     ` Zhou Yanjie
  0 siblings, 0 replies; 4+ messages in thread
From: Zhou Yanjie @ 2022-04-11 16:08 UTC (permalink / raw)
  To: Aidan MacDonald
  Cc: devicetree, krzk+dt, linux-kernel, linux-mips, paul, robh+dt

Hi Aidan,

On 2022/4/11 下午11:47, Aidan MacDonald wrote:
> On Mon, Apr 11, 2022 at 08:41:26PM +0800, Zhou Yanjie wrote:
>> Hi Aidan,
>>
>> On 2022/4/11 下午6:01, Aidan MacDonald wrote:
>>> Copied from the jz4740 devicetree and trimmed to 5 timers, which
>>> is what the hardware supports.
>>>
>>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>>> ---
>>>    arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>>>    1 file changed, 13 insertions(+)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> index 8bd27edef216..0dcf37527c8e 100644
>>> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> @@ -127,6 +127,19 @@ wdt: watchdog@0 {
>>>    			clocks = <&tcu TCU_CLK_WDT>;
>>>    			clock-names = "wdt";
>>>    		};
>>> +
>>> +		pwm: pwm@40 {
>>> +			compatible = "ingenic,x1000-pwm";
>>> +			reg = <0x40 0x80>;
>>
>> It seems more reasonable to use "reg = <0x40 0x80>" since the
>> X1000 has only 5 PWM channels.
> I think you mean "reg = <0x40 0x60>" but I'll do that, thanks!


Ah, yes, what a what a stupid mistake... :(


>
>>> +
>>> +			#pwm-cells = <3>;
>>> +
>>> +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
>>> +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
>>> +				 <&tcu TCU_CLK_TIMER4>;
>>> +			clock-names = "timer0", "timer1", "timer2",
>>> +				      "timer3", "timer4";
>>
>> One line is now allowed to hold at most 100 characters,
>> so it is possible to use only one line like:
>>
>>           clock-names = "timer0", "timer1", "timer2", "timer3", "timer4";
>>
>> to reduce the number of lines in the dtsi file.
> Sounds good to me.
>
>>
>> Thanks and best regards!
>>
>>
>>> +		};
>>>    	};
>>>    
>>>    	rtc: rtc@10003000 {
> Regards,
> Aidan

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-11 16:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 10:01 [PATCH] mips: dts: ingenic: x1000: Add PWM device tree node Aidan MacDonald
2022-04-11 12:41 ` Zhou Yanjie
2022-04-11 15:47   ` Aidan MacDonald
2022-04-11 16:08     ` Zhou Yanjie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).