* [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout
@ 2022-04-11 10:58 Miaoqian Lin
2022-06-29 5:47 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-04-11 10:58 UTC (permalink / raw)
To: Dmitry Torokhov, Miaoqian Lin, Lucas Stach, linux-input, linux-kernel
wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.
Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/input/touchscreen/exc3000.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
index cbe0dd412912..b290a0bb26cf 100644
--- a/drivers/input/touchscreen/exc3000.c
+++ b/drivers/input/touchscreen/exc3000.c
@@ -220,6 +220,7 @@ static int exc3000_vendor_data_request(struct exc3000_data *data, u8 *request,
{
u8 buf[EXC3000_LEN_VENDOR_REQUEST] = { 0x67, 0x00, 0x42, 0x00, 0x03 };
int ret;
+ unsigned long time_left;
mutex_lock(&data->query_lock);
@@ -233,9 +234,9 @@ static int exc3000_vendor_data_request(struct exc3000_data *data, u8 *request,
goto out_unlock;
if (response) {
- ret = wait_for_completion_timeout(&data->wait_event,
+ time_left = wait_for_completion_timeout(&data->wait_event,
timeout * HZ);
- if (ret <= 0) {
+ if (time_left == 0) {
ret = -ETIMEDOUT;
goto out_unlock;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout
2022-04-11 10:58 [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout Miaoqian Lin
@ 2022-06-29 5:47 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-06-29 5:47 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Lucas Stach, linux-input, linux-kernel
On Mon, Apr 11, 2022 at 10:58:23AM +0000, Miaoqian Lin wrote:
> wait_for_completion_timeout() returns unsigned long not int.
> It returns 0 if timed out, and positive if completed.
> The check for <= 0 is ambiguous and should be == 0 here
> indicating timeout which is the only error case.
>
> Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 5:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 10:58 [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout Miaoqian Lin
2022-06-29 5:47 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).