From: kernel test robot <lkp@intel.com>
To: Samuel Holland <samuel@sholland.org>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 2/4] dmaengine: sun6i: Do not use virt_to_phys
Date: Mon, 11 Apr 2022 16:20:58 +0800 [thread overview]
Message-ID: <202204111641.yuvoMU5q-lkp@intel.com> (raw)
In-Reply-To: <20220411044633.39014-3-samuel@sholland.org>
Hi Samuel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on sunxi/sunxi/for-next v5.18-rc2 next-20220411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Holland/dmaengine-sun6i-Allwinner-D1-support/20220411-124826
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: hexagon-randconfig-r041-20220410 (https://download.01.org/0day-ci/archive/20220411/202204111641.yuvoMU5q-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c6e83f560f06cdfe8aa47b248d8bdc58f947274b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/280420721fd264a03a3d3f9fbe2b4e6bfddd0f79
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Samuel-Holland/dmaengine-sun6i-Allwinner-D1-support/20220411-124826
git checkout 280420721fd264a03a3d3f9fbe2b4e6bfddd0f79
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/dma/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/dma/sun6i-dma.c:253:15: warning: format specifies type 'unsigned long' but the argument has type 'int' [-Wformat]
pchan->idx, pchan->base - sdev->base,
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:39: note: expanded from macro 'dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:167:19: note: expanded from macro 'dynamic_dev_dbg'
dev, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
1 warning generated.
vim +253 drivers/dma/sun6i-dma.c
240
241 static inline void sun6i_dma_dump_chan_regs(struct sun6i_dma_dev *sdev,
242 struct sun6i_pchan *pchan)
243 {
244 dev_dbg(sdev->slave.dev, "Chan %d reg: 0x%lx\n"
245 "\t___en(%04x): \t0x%08x\n"
246 "\tpause(%04x): \t0x%08x\n"
247 "\tstart(%04x): \t0x%08x\n"
248 "\t__cfg(%04x): \t0x%08x\n"
249 "\t__src(%04x): \t0x%08x\n"
250 "\t__dst(%04x): \t0x%08x\n"
251 "\tcount(%04x): \t0x%08x\n"
252 "\t_para(%04x): \t0x%08x\n\n",
> 253 pchan->idx, pchan->base - sdev->base,
254 DMA_CHAN_ENABLE,
255 readl(pchan->base + DMA_CHAN_ENABLE),
256 DMA_CHAN_PAUSE,
257 readl(pchan->base + DMA_CHAN_PAUSE),
258 DMA_CHAN_LLI_ADDR,
259 readl(pchan->base + DMA_CHAN_LLI_ADDR),
260 DMA_CHAN_CUR_CFG,
261 readl(pchan->base + DMA_CHAN_CUR_CFG),
262 DMA_CHAN_CUR_SRC,
263 readl(pchan->base + DMA_CHAN_CUR_SRC),
264 DMA_CHAN_CUR_DST,
265 readl(pchan->base + DMA_CHAN_CUR_DST),
266 DMA_CHAN_CUR_CNT,
267 readl(pchan->base + DMA_CHAN_CUR_CNT),
268 DMA_CHAN_CUR_PARA,
269 readl(pchan->base + DMA_CHAN_CUR_PARA));
270 }
271
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-11 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 4:46 [PATCH v2 0/4] dmaengine: sun6i: Allwinner D1 support Samuel Holland
2022-04-11 4:46 ` [PATCH v2 1/4] dt-bindings: dma: sun50i-a64: Add compatible for D1 Samuel Holland
2022-04-11 4:46 ` [PATCH v2 2/4] dmaengine: sun6i: Do not use virt_to_phys Samuel Holland
2022-04-11 8:10 ` kernel test robot
2022-04-11 8:20 ` kernel test robot [this message]
2022-04-11 4:46 ` [PATCH v2 3/4] dmaengine: sun6i: Add support for 34-bit physical addresses Samuel Holland
2022-04-11 12:03 ` kernel test robot
2022-04-11 4:46 ` [PATCH v2 4/4] dmaengine: sun6i: Add support for the D1 variant Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204111641.yuvoMU5q-lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).