From: "Martin Povišer" <povik+lin@cutebit.org>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mark Kettenis" <kettenis@openbsd.org>,
"Martin Povišer" <povik+lin@cutebit.org>
Subject: [PATCH v2 1/2] dt-bindings: dma: Add Apple ADMAC
Date: Tue, 12 Apr 2022 00:22:03 +0200 [thread overview]
Message-ID: <20220411222204.96860-2-povik+lin@cutebit.org> (raw)
In-Reply-To: <20220411222204.96860-1-povik+lin@cutebit.org>
Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio
samples on SoCs from the "Apple Silicon" family.
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
After the v1 discussion, I dropped the apple,internal-irq-destination
property and instead the index of the usable interrupt is now signified
by prepending -1 entries to the interrupts= list. This works when I do
it like this:
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 0xffffffff 0>,
<AIC_IRQ 626 IRQ_TYPE_LEVEL_HIGH>;
I would find it neat to do it like this:
interrupts-extended = <0xffffffff>,
<&aic AIC_IRQ 626 IRQ_TYPE_LEVEL_HIGH>;
but unfortunately the kernel doesn't pick up on it:
[ 0.767964] apple-admac 238200000.dma-controller: error -6: IRQ index 0 not found
[ 0.773943] apple-admac 238200000.dma-controller: error -6: IRQ index 1 not found
[ 0.780154] apple-admac 238200000.dma-controller: error -6: IRQ index 2 not found
[ 0.786367] apple-admac 238200000.dma-controller: error -6: IRQ index 3 not found
[ 0.788592] apple-admac 238200000.dma-controller: error -6: no usable interrupt
.../devicetree/bindings/dma/apple,admac.yaml | 68 +++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/dma/apple,admac.yaml
diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml
new file mode 100644
index 000000000000..bbd5eaf5f709
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/apple,admac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Apple Audio DMA Controller (ADMAC)
+
+description: |
+ Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio samples
+ on SoCs from the "Apple Silicon" family.
+
+ The controller has been seen with up to 24 channels. Even-numbered channels
+ are TX-only, odd-numbered are RX-only. Individual channels are coupled to
+ fixed device endpoints.
+
+maintainers:
+ - Martin Povišer <povik+lin@cutebit.org>
+
+allOf:
+ - $ref: "dma-controller.yaml#"
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - apple,t6000-admac
+ - apple,t8103-admac
+ - const: apple,admac
+
+ reg:
+ maxItems: 1
+
+ '#dma-cells':
+ const: 1
+ description:
+ Clients specify single cell with channel number.
+
+ dma-channels:
+ maximum: 24
+
+ interrupts:
+ minItems: 1
+ maxItems: 4
+
+required:
+ - compatible
+ - reg
+ - '#dma-cells'
+ - dma-channels
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/apple-aic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ admac: dma-controller@238200000 {
+ compatible = "apple,t8103-admac", "apple,admac";
+ reg = <0x38200000 0x34000>;
+ dma-channels = <24>;
+ interrupt-parent = <&aic>;
+ interrupts = <AIC_IRQ 0xffffffff 0>,
+ <AIC_IRQ 626 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ };
--
2.33.0
next prev parent reply other threads:[~2022-04-11 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 22:22 [PATCH v2 0/2] Apple ADMAC driver Martin Povišer
2022-04-11 22:22 ` Martin Povišer [this message]
2022-04-14 15:43 ` [PATCH v2 1/2] dt-bindings: dma: Add Apple ADMAC Rob Herring
2022-04-14 17:23 ` Martin Povišer
2022-04-14 17:52 ` Martin Povišer
2022-04-11 22:22 ` [PATCH v2 2/2] dmaengine: apple-admac: Add Apple ADMAC driver Martin Povišer
2022-04-20 12:40 ` Vinod Koul
2022-04-20 13:41 ` Martin Povišer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411222204.96860-2-povik+lin@cutebit.org \
--to=povik+lin@cutebit.org \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).