From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Jon Kohler <jon@nutanix.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, dave.hansen@intel.com,
Borislav Petkov <bp@suse.de>,
Neelima Krishnan <neelima.krishnan@intel.com>,
"kvm @ vger . kernel . org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] x86/tsx: fix KVM guest live migration for tsx=on
Date: Tue, 12 Apr 2022 13:54:11 -0700 [thread overview]
Message-ID: <20220412205411.m7n2gnon3ai7wobm@guptapa-desk> (raw)
In-Reply-To: <20220411200703.48654-1-jon@nutanix.com>
On Mon, Apr 11, 2022 at 04:07:01PM -0400, Jon Kohler wrote:
>Move automatic disablement for TSX microcode deprecation from tsx_init() to
>x86_get_tsx_auto_mode(), such that systems with tsx=on will continue to
>see the TSX CPU features (HLE, RTM) even on updated microcode.
>
>KVM live migration could be possibly be broken in 5.14+ commit 293649307ef9
>("x86/tsx: Clear CPUID bits when TSX always force aborts"). Consider the
>following scenario:
>
>1. KVM hosts clustered in a live migration capable setup.
>2. KVM guests have TSX CPU features HLE and/or RTM presented.
>3. One of the three maintenance events occur:
>3a. An existing host running kernel >= 5.14 in the pool updated with the
> new microcode.
>3b. A new host running kernel >= 5.14 is commissioned that already has the
> microcode update preloaded.
>3c. All hosts are running kernel < 5.14 with microcode update already
> loaded and one existing host gets updated to kernel >= 5.14.
>4. After maintenance event, the impacted host will not have HLE and RTM
> exposed, and live migrations with guests with TSX features might not
> migrate.
Which part was this reproduced on? AFAIK server parts(except for some
Intel Xeon E3s) did not get such microcode update.
Thanks,
Pawan
prev parent reply other threads:[~2022-04-12 21:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 18:01 [PATCH] x86/tsx: fix KVM guest live migration for tsx=on Jon Kohler
2022-04-11 19:26 ` Dave Hansen
2022-04-11 19:35 ` Jon Kohler
2022-04-11 23:45 ` Dave Hansen
2022-04-12 13:36 ` Jon Kohler
2022-04-12 15:54 ` Dave Hansen
2022-04-12 16:08 ` Jon Kohler
2022-04-12 18:04 ` Pawan Gupta
2022-04-12 18:12 ` Jon Kohler
2022-04-12 20:40 ` Pawan Gupta
2022-04-13 12:43 ` Jon Kohler
2022-04-11 20:07 ` [PATCH v2] " Jon Kohler
2022-04-12 19:55 ` Pawan Gupta
2022-04-12 20:54 ` Pawan Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412205411.m7n2gnon3ai7wobm@guptapa-desk \
--to=pawan.kumar.gupta@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon@nutanix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neelima.krishnan@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).