From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F0DC433F5 for ; Wed, 13 Apr 2022 07:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233258AbiDMHP4 (ORCPT ); Wed, 13 Apr 2022 03:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbiDMHPy (ORCPT ); Wed, 13 Apr 2022 03:15:54 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF91B35247; Wed, 13 Apr 2022 00:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1649834013; x=1681370013; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=h3C/0JKkds2vE5J17NOx80JGTh8SJToIN8IB1dF+FE8=; b=RHAMW0YWL9QnM/JspOo1W5EIiUMuPeJMTUkTlOxjHwyrGFcR4dn3vFvm YE2/2nIFai98DUNarlgMwA+9f+J8kaJ/a2WdQc52/ttfUnXT99ZWOxljk 0UfflXUcoRZSq8aO7crvmZtYu/yWllX8hvKYMYgQaNLwO36HWRWMXDzTW EPy4+Abfe5o4kc9nX3olW8SQq9DA7vimCut7SjE1WbC4ZBLbfSBhfuskS pnRubE1JH8wH9ACxaTBcz01m7/DeTJMLV1/ddc6W8RbXSAXTBfdCtKUJ0 E5seD+4sGiBODcG5xur3+nTwCkdP3/5b6VFcjEBuTCA5+xOB6UnSLuBZN Q==; X-IronPort-AV: E=Sophos;i="5.90,256,1643698800"; d="scan'208";a="159933363" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Apr 2022 00:13:32 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 13 Apr 2022 00:13:31 -0700 Received: from rob-ult-m19940.amer.actel.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 13 Apr 2022 00:13:29 -0700 From: Codrin Ciubotariu To: , , CC: , , , , , Codrin Ciubotariu Subject: [PATCH] clk: at91: generated: consider range when calculating best rate Date: Wed, 13 Apr 2022 10:13:18 +0300 Message-ID: <20220413071318.244912-1-codrin.ciubotariu@microchip.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clk_generated_best_diff() helps in finding the parent and the divisor to compute a rate closest to the required one. However, it doesn't take into account the request's range for the new rate. Make sure the new rate is within the required range. Fixes: 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff") Signed-off-by: Codrin Ciubotariu --- drivers/clk/at91/clk-generated.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c index 23cc8297ec4c..d429ba52a719 100644 --- a/drivers/clk/at91/clk-generated.c +++ b/drivers/clk/at91/clk-generated.c @@ -117,6 +117,10 @@ static void clk_generated_best_diff(struct clk_rate_request *req, tmp_rate = parent_rate; else tmp_rate = parent_rate / div; + + if (tmp_rate < req->min_rate || tmp_rate > req->max_rate) + return; + tmp_diff = abs(req->rate - tmp_rate); if (*best_diff < 0 || *best_diff >= tmp_diff) { -- 2.32.0