* [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
@ 2022-04-14 9:19 Miles Chen
2022-04-15 0:01 ` Randy Dunlap
2022-04-15 7:17 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Miles Chen @ 2022-04-14 9:19 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Randy Dunlap
Cc: Miles Chen, Takashi Iwai, alsa-devel, linux-kernel,
linux-arm-kernel, linux-mediatek
We observed: 'dmasound_setup' defined but not used error with
COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
Fix it by adding __maybe_unused to dmasound_setup.
Error(s):
sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Cc: Takashi Iwai <tiwai@suse.com>
---
Change sinve v1:
add fixes tag
use __maybe_unused
---
sound/oss/dmasound/dmasound_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
index 9c48f3a9e3d1..164335d3c200 100644
--- a/sound/oss/dmasound/dmasound_core.c
+++ b/sound/oss/dmasound/dmasound_core.c
@@ -1428,7 +1428,7 @@ void dmasound_deinit(void)
unregister_sound_dsp(sq_unit);
}
-static int dmasound_setup(char *str)
+static int __maybe_unused dmasound_setup(char *str)
{
int ints[6], size;
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
2022-04-14 9:19 [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Miles Chen
@ 2022-04-15 0:01 ` Randy Dunlap
2022-04-15 7:17 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2022-04-15 0:01 UTC (permalink / raw)
To: Miles Chen, Jaroslav Kysela, Takashi Iwai, Matthias Brugger
Cc: Takashi Iwai, alsa-devel, linux-kernel, linux-arm-kernel, linux-mediatek
On 4/14/22 02:19, Miles Chen wrote:
> We observed: 'dmasound_setup' defined but not used error with
> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
>
> Fix it by adding __maybe_unused to dmasound_setup.
>
> Error(s):
> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
>
> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> Cc: Takashi Iwai <tiwai@suse.com>
>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
>
> Change sinve v1:
> add fixes tag
> use __maybe_unused
>
> ---
> sound/oss/dmasound/dmasound_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
> index 9c48f3a9e3d1..164335d3c200 100644
> --- a/sound/oss/dmasound/dmasound_core.c
> +++ b/sound/oss/dmasound/dmasound_core.c
> @@ -1428,7 +1428,7 @@ void dmasound_deinit(void)
> unregister_sound_dsp(sq_unit);
> }
>
> -static int dmasound_setup(char *str)
> +static int __maybe_unused dmasound_setup(char *str)
> {
> int ints[6], size;
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
2022-04-14 9:19 [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Miles Chen
2022-04-15 0:01 ` Randy Dunlap
@ 2022-04-15 7:17 ` Takashi Iwai
2022-04-22 2:53 ` Miles Chen
1 sibling, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2022-04-15 7:17 UTC (permalink / raw)
To: Miles Chen
Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Randy Dunlap,
alsa-devel, linux-kernel, linux-arm-kernel, linux-mediatek
On Thu, 14 Apr 2022 11:19:38 +0200,
Miles Chen wrote:
>
> We observed: 'dmasound_setup' defined but not used error with
> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
>
> Fix it by adding __maybe_unused to dmasound_setup.
>
> Error(s):
> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
>
> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> Cc: Takashi Iwai <tiwai@suse.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
2022-04-15 7:17 ` Takashi Iwai
@ 2022-04-22 2:53 ` Miles Chen
2022-04-22 5:58 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Miles Chen @ 2022-04-22 2:53 UTC (permalink / raw)
To: tiwai
Cc: alsa-devel, linux-arm-kernel, linux-kernel, linux-mediatek,
matthias.bgg, miles.chen, perex, rdunlap, tiwai
Hi Taksshi,
>> We observed: 'dmasound_setup' defined but not used error with
>> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
>>
>> Fix it by adding __maybe_unused to dmasound_setup.
>>
>> Error(s):
>> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
>>
>> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
>> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
>> Cc: Takashi Iwai <tiwai@suse.com>
>
>Thanks, applied.
This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
you can pick it to the mainstream?
[1] https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2204190925230.302265@ramsan.of.borg/
thanks,
Miles
>
>
>Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
2022-04-22 2:53 ` Miles Chen
@ 2022-04-22 5:58 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2022-04-22 5:58 UTC (permalink / raw)
To: Miles Chen
Cc: alsa-devel, linux-arm-kernel, linux-kernel, linux-mediatek,
matthias.bgg, perex, rdunlap, tiwai
On Fri, 22 Apr 2022 04:53:12 +0200,
Miles Chen wrote:
>
> Hi Taksshi,
>
> >> We observed: 'dmasound_setup' defined but not used error with
> >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
> >>
> >> Fix it by adding __maybe_unused to dmasound_setup.
> >>
> >> Error(s):
> >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> >> Cc: Takashi Iwai <tiwai@suse.com>
> >
> >Thanks, applied.
>
> This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
> you can pick it to the mainstream?
It's included in the branch for the next PR to 5.18.
thanks,
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-22 5:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 9:19 [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Miles Chen
2022-04-15 0:01 ` Randy Dunlap
2022-04-15 7:17 ` Takashi Iwai
2022-04-22 2:53 ` Miles Chen
2022-04-22 5:58 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).