From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B240EC433EF for ; Fri, 15 Apr 2022 02:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347427AbiDOCyY (ORCPT ); Thu, 14 Apr 2022 22:54:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbiDOCyV (ORCPT ); Thu, 14 Apr 2022 22:54:21 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33AC0B53D0 for ; Thu, 14 Apr 2022 19:51:55 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id n11so5807701qvl.0 for ; Thu, 14 Apr 2022 19:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yHG4RTfLs3izK4POBBX3OO4Xti9SeDZkZKSmtbKLbz0=; b=H1L8OA2uxN+e9KYvFwRTQoTkze4E6CKkRG15sEmWhV+jNE2OBN91ow1ArTufc4XnPX rIxL+iEUic98cZYlVaTcp125vee1CclSoRNxW9mX4N8Upl+Vl6aPzrLzuInNOip2yGva pNbq8vNlDI5cXSgUKZCj0wtwD8491AfGlNTaHyjzMxbmA6P8XG31aMig88n1hfc/j7l4 /xQWP4VWvtiu4IO3W6Zyc6E6QWjVq1Ff4C+FniH7tmagR+Bwmc0P7j8wI9+DWtpKFkqg d2OKfbGNpqBq+b9Q8wSBJVuK/sgIAp4Qp6DCX92414hKkqKmQ8gVpduumI7ldVpCGxRy AZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yHG4RTfLs3izK4POBBX3OO4Xti9SeDZkZKSmtbKLbz0=; b=7F82N0Z2ACGt3S+iBXe80cUN7+Rrkj+yhPzCbPAks69FS9TrGf4brLfvEnBN5bJdbG 5k69mRTW+n+/gCIHmtG90h0/yiSaVHsa5kDg+3eC+rL26ZQJUM/wEmoJ5cnPVwnU20dT 4Us3nqIxycsKv7dDePa/1+QAfkHFLbhUYUTO4aXI9ZWMgFmYSc8LnNi/h2BfJl7zf5U7 ToakPAqykD+Kf95dSZHymDh+ztJGeyoMVg+GLhmu7f+H/CRVJ8d5vT9a2hw8pBuDwZoj /2N17x+K9eXtRSElR9YGxNkE4TFZkQV0fmxN8etZHouig7euVqLy7A+f3UMrtFP42kBh 8C3w== X-Gm-Message-State: AOAM533o7gtJ9tOOP12p3jJXiRsUnENHTX24O0nOupq/Ejt9b1KD2v2o JajtttqHDdnkEFflODdGoc4= X-Google-Smtp-Source: ABdhPJxSuarSH8KOah4mgH+Moko/hRAN6yMOuAxrxP8FPMA4xiQ9fHcZjOpO6LJsWCOpGWVAHaXSfg== X-Received: by 2002:ad4:5948:0:b0:441:5d45:6d62 with SMTP id eo8-20020ad45948000000b004415d456d62mr5899708qvb.25.1649991114367; Thu, 14 Apr 2022 19:51:54 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id t198-20020a3746cf000000b0069c51337badsm1884570qka.45.2022.04.14.19.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:51:53 -0700 (PDT) Date: Thu, 14 Apr 2022 22:51:51 -0400 From: Jaehee Park To: Pavel Skripkin Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH 1/6] staging: r8188eu: remove unnecessary braces in single statement block Message-ID: <20220415025151.GA33625@jaehee-ThinkPad-X1-Extreme> References: <4a0f2a0f24321c5b2039f0f8e6132cec4a2ef068.1649880454.git.jhpark1013@gmail.com> <3f4a6c08-4434-1865-bc96-984152af5af1@gmail.com> <20220414194118.GA4144553@jaehee-ThinkPad-X1-Extreme> <8bd1cc3c-c28b-b30f-d9ff-04f9a3c79646@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bd1cc3c-c28b-b30f-d9ff-04f9a3c79646@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 10:50:52PM +0300, Pavel Skripkin wrote: > Hi Jaehee, > > On 4/14/22 22:41, Jaehee Park wrote: > > > > @@ -112,9 +112,8 @@ void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) > > > > rtw_free_mlme_priv_ie_data(pmlmepriv); > > > > - if (pmlmepriv) { > > > > + if (pmlmepriv) > > > > vfree(pmlmepriv->free_bss_buf); > > > > - } > > > > > > If pmlmepriv is equal to NULL we would die in rtw_free_mlme_priv_ie_data(), > > > so this check is just redundant > > > > > > > Hi Pavel, thank you for your comment! If I'm removing this if statement, > > should I include vfree(pmlmepriv->free_bss_buf) in > > rtw_free_mlme_priv_ie_data? > > > > Hm > > Simple grep shows, that this member is just unused > > 1 drivers/staging/r8188eu/core/rtw_mlme.c|64 col 13| pmlmepriv->free_bss_buf > = pbuf; > 2 drivers/staging/r8188eu/core/rtw_mlme.c|116 col 20| > vfree(pmlmepriv->free_bss_buf); > 3 drivers/staging/r8188eu/include/rtw_mlme.h|322 col 6| u8 *free_bss_buf; > > so looks like you can just remove free_bss_buf and all related lines. > > I hope I haven't overlooked something > Hi Pavel, Thank you for your review! I have sent a second version of the patchset. Thanks, Jaehee > > > With regards, > Pavel Skripkin