From: Dan Carpenter <dan.carpenter@oracle.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
len.baker@gmx.com, dave@stgolabs.net, edumazet@google.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
Date: Fri, 15 Apr 2022 08:25:02 +0300 [thread overview]
Message-ID: <20220415052502.GE12805@kadam> (raw)
In-Reply-To: <1649988571-19923-1-git-send-email-baihaowen@meizu.com>
On Fri, Apr 15, 2022 at 10:09:31AM +0800, Haowen Bai wrote:
> function rtllib_rx_assoc_resp () unsigned errcode receive auth_parse()'s
> errcode -ENOMEM.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: reduce return random value; print its own error message.
>
> drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 82bf05eb1cbf..8a0961e64a8c 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1764,7 +1764,7 @@ static void rtllib_softmac_check_all_nets(struct rtllib_device *ieee)
> spin_unlock_irqrestore(&ieee->lock, flags);
> }
>
> -static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
> +static inline s16 auth_parse(struct net_device *dev, struct sk_buff *skb,
Could you make this an int instead of s16. s16 is always a bit weird.
> u8 **challenge, int *chlen)
> {
> struct rtllib_authentication *a;
> @@ -1773,7 +1773,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
> if (skb->len < (sizeof(struct rtllib_authentication) -
> sizeof(struct rtllib_info_element))) {
> netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len);
> - return 0xcafe;
> + return -EINVAL;
> }
> *challenge = NULL;
> a = (struct rtllib_authentication *) skb->data;
> @@ -1787,7 +1787,7 @@ static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb,
> return -ENOMEM;
> }
> }
> - return le16_to_cpu(a->status);
> + return a->status;
But then just say:
if (a->status) {
netdev_info(ieee->dev, "blah blah failed");
return -EINVAL;
}
return 0;
If you look up what a->status is, it can only be
WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG which is not worth preserving really.
regards,
dan carpenter
prev parent reply other threads:[~2022-04-15 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:09 [PATCH V2] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Haowen Bai
2022-04-15 5:22 ` Fabio M. De Francesco
2022-04-15 5:31 ` Dan Carpenter
2022-04-15 5:50 ` [PATCH V3] " Haowen Bai
2022-04-15 6:06 ` Fabio M. De Francesco
2022-04-15 6:10 ` Fabio M. De Francesco
2022-04-15 6:15 ` [PATCH V4] " Haowen Bai
2022-04-15 6:20 ` Dan Carpenter
2022-04-15 6:39 ` Haowen Bai
2022-04-15 6:58 ` Dan Carpenter
2022-04-15 7:21 ` Haowen Bai
2022-04-20 16:41 ` Greg Kroah-Hartman
2022-04-21 1:34 ` Haowen Bai
2022-04-21 8:09 ` kernel test robot
2022-04-21 8:21 ` [PATCH V5] " Haowen Bai
2022-04-21 16:22 ` Dan Carpenter
2022-04-18 1:48 ` [PATCH V4] " baihaowen
2022-04-15 6:18 ` [PATCH V3] " Dan Carpenter
2022-04-15 5:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415052502.GE12805@kadam \
--to=dan.carpenter@oracle.com \
--cc=baihaowen@meizu.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.baker@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).