From: Christoph Hellwig <hch@lst.de>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: viro@zeniv.linux.org.uk, torvalds@linux-foundation.org,
hch@lst.de, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com
Subject: Re: [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback()
Date: Fri, 15 Apr 2022 08:39:20 +0200 [thread overview]
Message-ID: <20220415063920.GB24262@lst.de> (raw)
In-Reply-To: <20220415013735.1610091-1-chengzhihao1@huawei.com>
On Fri, Apr 15, 2022 at 09:37:35AM +0800, Zhihao Cheng wrote:
> + if (progress) {
> + /*
> + * The progress may be false postive in page redirty
> + * case (which is caused by failing to get buffer head
> + * lock), which will requeue dirty inodes and start
> + * next writeback iteration, and other tasks maybe
> + * stuck for getting tags for new requests. So, flush
> + * plug to schedule requests holding tags.
> + *
> + * The code can be removed after buffer head
> + * disappering from linux.
> + */
> + blk_flush_plug(current->plug, false);
This basically removes plugging entirely, so we might as well stop
adding the plug if we can't solve it any other way. But it seems
like that fake progress needs to be fixed instead.
next prev parent reply other threads:[~2022-04-15 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 1:37 [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback() Zhihao Cheng
2022-04-15 6:39 ` Christoph Hellwig [this message]
2022-04-15 8:39 ` Zhihao Cheng
2022-04-16 5:42 ` Christoph Hellwig
2022-04-16 8:41 ` Zhihao Cheng
2022-04-18 5:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415063920.GB24262@lst.de \
--to=hch@lst.de \
--cc=chengzhihao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).