From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Klinger <ak@it-klinger.de>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: proximity: mb1232: Switch to use fwnode_irq_get()
Date: Sat, 16 Apr 2022 12:07:26 +0100 [thread overview]
Message-ID: <20220416120726.0ba78960@jic23-huawei> (raw)
In-Reply-To: <20220413183123.20292-1-andriy.shevchenko@linux.intel.com>
On Wed, 13 Apr 2022 21:31:23 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> We have OF-centric variant of fwnode_irq_get() in the driver.
> Replace it with a call to an agnostic implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Whilst I 'think' this ends up being functionally identical
I'd like to leave it a little longer to see if Andreas has
time to take a look and verify this change is fine.
There seem to be subtle differences in the irq setup as the
new code does a sanity check on the domain being available
and defers if not which I don't think happens with the
existing code.
Thanks,
Jonathan
> ---
> drivers/iio/proximity/mb1232.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/proximity/mb1232.c b/drivers/iio/proximity/mb1232.c
> index ad4b1fb2607a..0bca5f74de68 100644
> --- a/drivers/iio/proximity/mb1232.c
> +++ b/drivers/iio/proximity/mb1232.c
> @@ -10,12 +10,14 @@
> * https://www.maxbotix.com/documents/I2CXL-MaxSonar-EZ_Datasheet.pdf
> */
>
> +#include <linux/bitops.h>
> #include <linux/err.h>
> #include <linux/i2c.h>
> -#include <linux/of_irq.h>
> #include <linux/delay.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/bitops.h>
> +#include <linux/property.h>
> +
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/iio/buffer.h>
> @@ -209,7 +211,7 @@ static int mb1232_probe(struct i2c_client *client,
>
> init_completion(&data->ranging);
>
> - data->irqnr = irq_of_parse_and_map(dev->of_node, 0);
> + data->irqnr = fwnode_irq_get(dev_fwnode(&client->dev), 0);
> if (data->irqnr <= 0) {
> /* usage of interrupt is optional */
> data->irqnr = -1;
next prev parent reply other threads:[~2022-04-16 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 18:31 [PATCH v1 1/1] iio: proximity: mb1232: Switch to use fwnode_irq_get() Andy Shevchenko
2022-04-16 11:07 ` Jonathan Cameron [this message]
2022-04-19 10:24 ` Andreas Klinger
2022-04-28 18:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220416120726.0ba78960@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).