From: Kees Cook <keescook@chromium.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@collabora.com, kernelci@groups.io,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/lkdtm: add config
Date: Sat, 16 Apr 2022 14:13:25 -0700 [thread overview]
Message-ID: <202204161407.D6D3202FD@keescook> (raw)
In-Reply-To: <a9c74cc2-491e-678a-8965-86fa6a6002dc@collabora.com>
On Mon, Apr 04, 2022 at 12:50:01PM +0500, Muhammad Usama Anjum wrote:
> Hi Kees,
>
> Any thoughts?
>
> On 3/15/22 4:55 PM, Muhammad Usama Anjum wrote:
> > On 3/10/22 10:22 PM, Muhammad Usama Anjum wrote:
> >> On 3/10/22 12:23 AM, Kees Cook wrote:
> >>> On Fri, Feb 18, 2022 at 01:56:20AM +0500, Muhammad Usama Anjum wrote:
> >>>> Add config option which is needed for SLAB_LINEAR_OVERFLOW test. It
> >>>> needs KASAN enabled.
> >>>
> >>> I'd prefer this use the SLAB_DEBUG options -- KASAN is very heavy.
> >> I'll test it out and update in the next patch version.
> >> I've tested by removing KASAN and adding the following config:
> > CONFIG_SLAB=y
> > CONFIG_DEBUG_SLAB=y
I recommend slub instead:
CONFIG_SLUB=y
CONFIG_SLUB_DEBUG=y
and one more, see below...
> >
> > The result of SLAB_LINEAR_OVERFLOW test doesn't remain deterministic in
> > this config. The task never crashes and hence stack trace never appears.
> > When executed several times we get "Slab corruption" logs and after some
> > more tries whole kernel crashes. I've not used DEBUG_SLAB before and not
> > sure if this is the expected behavior. If we aren't sure, we can keep
> > KASAN turned on instead.
I think you need to enable the actual kmem debugging with a boot param
("slub_debug=ZF"), or with CONFIG_SLUB_DEBUG_ON=y.
--
Kees Cook
next prev parent reply other threads:[~2022-04-16 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 20:56 [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO Muhammad Usama Anjum
2022-02-17 20:56 ` [PATCH 2/2] selftests/lkdtm: add config Muhammad Usama Anjum
2022-02-18 15:32 ` Muhammad Usama Anjum
2022-03-09 19:23 ` Kees Cook
2022-03-10 17:22 ` Muhammad Usama Anjum
2022-03-15 11:55 ` Muhammad Usama Anjum
2022-04-04 7:50 ` Muhammad Usama Anjum
2022-04-16 21:13 ` Kees Cook [this message]
2022-02-18 15:31 ` [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO Muhammad Usama Anjum
2022-02-28 7:06 ` Muhammad Usama Anjum
2022-03-08 11:17 ` Muhammad Usama Anjum
2022-03-09 19:22 ` Kees Cook
2022-03-10 17:21 ` Muhammad Usama Anjum
2022-04-14 11:31 ` Muhammad Usama Anjum
2022-04-16 21:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204161407.D6D3202FD@keescook \
--to=keescook@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=kernelci@groups.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).