From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B3EC433EF for ; Tue, 19 Apr 2022 12:44:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345459AbiDSMqz (ORCPT ); Tue, 19 Apr 2022 08:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234437AbiDSMqw (ORCPT ); Tue, 19 Apr 2022 08:46:52 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F17FE369FD for ; Tue, 19 Apr 2022 05:44:09 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 621125C01E6; Tue, 19 Apr 2022 08:44:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 19 Apr 2022 08:44:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1650372249; x=1650458649; bh=Qq/UOm8yAY qIo9R+oNyskcDN1bISCRnifsESqPXRXqM=; b=p201mqdZqtHqRbdRbaJon0PCjT k613N+9JcNU/LhVygOZYbe9uIAU/pWoy+Df0P0Dvo/ji4gOdH9yV0GmAzgG5lbFF PIPPFNZlQWr8wUFZpE8IlxVnT8ki7pLitSaewxBY2h4mzccKEI/GjzViXSd8A87w jK/HB63MA75DZvaNZRxdsqGq//p7PFYZEXBSg9L/9rwdmA+wiNLjw4I5PbJkPzUz QpDEcBIxcsiqVMjotwfaw66uzbZe0uVgxrFzoe07beC8cbffvysix9S9wj6Q7EB5 zu7fSd2qc//onBm+0DCz9y7M4PvY8U7edMoYnadT8Dxd4sywx8uaFnrnol/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650372249; x= 1650458649; bh=Qq/UOm8yAYqIo9R+oNyskcDN1bISCRnifsESqPXRXqM=; b=n MnCkWXihgtITSTFysFLOA/Ux9ur3YAH8S8JC1BPrZv0Y4vzRIwEZkPMpTbPj60mD vHtHOuX4Rc36Ht8UlqEmE1COTknqJosV2B2b4CFzgaFgXpIHimqVpq1UDIiRWvqr YLW1nSBH0k3E7EwBVk7Tm6NuM6fDVDwBHbXlpLwxVZUbjeivsp2bMaoRqMSN+H3I mTy8T2NTbITbynyj5pmzl4NidsO0Se19dDjo6nooyg1E2awWuZBVgyx/nFtugkHP pJrXsiCSpqGuZaJYsKvVWpP8VAy1DznsZQs7jmFbt23Pl0ZzDkUL82P2Dl/CXhti 1Mn7avsNW8gL+SHHeRxaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Apr 2022 08:44:08 -0400 (EDT) Date: Tue, 19 Apr 2022 14:44:07 +0200 From: Maxime Ripard To: Miaoqian Lin Cc: Emma Anholt , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix pm_runtime_get_sync() error checking Message-ID: <20220419124407.ugzl7hknsytbhrmr@houat> References: <20220412070458.21819-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uztsba55upz7amoc" Content-Disposition: inline In-Reply-To: <20220412070458.21819-1-linmq006@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uztsba55upz7amoc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Apr 12, 2022 at 07:04:57AM +0000, Miaoqian Lin wrote: > If the device is already in a runtime PM enabled state > pm_runtime_get_sync() will return 1, so a test for negative > value should be used to check for errors. >=20 > Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") > Signed-off-by: Miaoqian Lin > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 752f921735c6..26aa7d1fa421 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -847,7 +847,7 @@ static void vc4_dsi_encoder_enable(struct drm_encoder= *encoder) > int ret; > =20 > ret =3D pm_runtime_get_sync(dev); > - if (ret) { > + if (ret < 0) { > DRM_ERROR("Failed to runtime PM enable on DSI%d\n", dsi->variant->port= ); > return; > } We also don't put back our reference after an error. I think a better fix would be to switch to pm_runtime_resume_and_get. Maxime --uztsba55upz7amoc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYl6ulwAKCRDj7w1vZxhR xWMdAP0VKWdkPdp6eRfSc4/lPac9MGFErgPN7HCtHcYKnTtV6AEA7oCtUCIDSMHJ mfz5mdgSRKw8zc3op1i2em3Vr8h6kgQ= =Lm9X -----END PGP SIGNATURE----- --uztsba55upz7amoc--