From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE64C433F5 for ; Wed, 20 Apr 2022 13:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379197AbiDTNwJ (ORCPT ); Wed, 20 Apr 2022 09:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240617AbiDTNwH (ORCPT ); Wed, 20 Apr 2022 09:52:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478EC434B5 for ; Wed, 20 Apr 2022 06:49:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAB45B81D6E for ; Wed, 20 Apr 2022 13:49:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9047DC385A0; Wed, 20 Apr 2022 13:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650462558; bh=CGz3cFAbrwU2Jgt4y+fKjgyBtQYs0UtifVstpEDTGDM=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=TiGKK6Y6AnZ8wgqbZS1mvxsBcp+00HuAFa46wYyQmnJp7F7G/K/4Y0n/75jrzvPDn 63nYAPSaNE9C1JuqrL/fledTHeF+nxWPfi3TY3Vt87w+/LYmYHuBKYLmTUZ+O8S20F m5P08N8yGDgdMqy1jn1loxNocqmn6IugmZ13/3WNlqTNZ9Q7hvaIF5WEMBykeZ44Nj 8Oi0LWjjwWlgpt99lxgX/S8k9WOKjW6e9ueUZFCT1UP2YQ3QCIZIxFEFS7+yFfRBXh NIp7iQxXCCUMp+8wfMGhSnwrIeUc1a+FggcXJYMZ419iiJlnk//CuGkVsCtFS8WYZ3 0bZhXT8cRILrA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 39BE95C0269; Wed, 20 Apr 2022 06:49:18 -0700 (PDT) Date: Wed, 20 Apr 2022 06:49:18 -0700 From: "Paul E. McKenney" To: kernel test robot Cc: Joel Fernandes , llvm@lists.linux.dev, kbuild-all@lists.01.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, "Uladzislau Rezki (Sony)" , Kalesh Singh Subject: Re: [ammarfaizi2-block:paulmck/linux-rcu/dev 28/28] kernel/rcu/tree_nocb.h:1213:3: warning: misleading indentation; statement is not part of the previous 'if' Message-ID: <20220420134918.GZ4285@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <202204201732.oTzYh0Xo-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202204201732.oTzYh0Xo-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 05:57:46PM +0800, kernel test robot wrote: > tree: https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev > head: ad68d8bf085421e4f22731c8b64c0b774a154e06 > commit: ad68d8bf085421e4f22731c8b64c0b774a154e06 [28/28] rcu/nocb: Add an option to offload all CPUs on boot > config: riscv-randconfig-r024-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201732.oTzYh0Xo-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://github.com/ammarfaizi2/linux-block/commit/ad68d8bf085421e4f22731c8b64c0b774a154e06 > git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block > git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev > git checkout ad68d8bf085421e4f22731c8b64c0b774a154e06 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash kernel/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): I am dropping this commit, and thank you for your testing efforts! Thanx, Paul > In file included from kernel/rcu/tree.c:5031: > >> kernel/rcu/tree_nocb.h:1213:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] > offload_all = false; /* NO_HZ_FULL has its own mask. */ > ^ > kernel/rcu/tree_nocb.h:1211:2: note: previous statement is here > if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) > ^ > kernel/rcu/tree_nocb.h:1198:6: warning: unused variable 'cpu' [-Wunused-variable] > int cpu; > ^ > kernel/rcu/tree_nocb.h:1199:7: warning: variable 'need_rcu_nocb_mask' set but not used [-Wunused-but-set-variable] > bool need_rcu_nocb_mask = false; > ^ > kernel/rcu/tree_nocb.h:1200:7: warning: variable 'offload_all' set but not used [-Wunused-but-set-variable] > bool offload_all = false; > ^ > kernel/rcu/tree_nocb.h:1201:19: warning: unused variable 'rdp' [-Wunused-variable] > struct rcu_data *rdp; > ^ > kernel/rcu/tree_nocb.h:1217:2: error: expected identifier or '(' > if (need_rcu_nocb_mask) { > ^ > kernel/rcu/tree_nocb.h:1227:2: error: expected identifier or '(' > if (!rcu_state.nocb_is_setup) > ^ > kernel/rcu/tree_nocb.h:1231:2: error: expected identifier or '(' > if (tick_nohz_full_running) > ^ > kernel/rcu/tree_nocb.h:1235:2: error: expected identifier or '(' > if (offload_all) > ^ > kernel/rcu/tree_nocb.h:1238:2: error: expected identifier or '(' > if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { > ^ > kernel/rcu/tree_nocb.h:1243:2: error: expected identifier or '(' > if (cpumask_empty(rcu_nocb_mask)) > ^ > kernel/rcu/tree_nocb.h:1245:2: error: expected identifier or '(' > else > ^ > kernel/rcu/tree_nocb.h:1248:2: error: expected identifier or '(' > if (rcu_nocb_poll) > ^ > kernel/rcu/tree_nocb.h:1251:2: error: expected identifier or '(' > for_each_cpu(cpu, rcu_nocb_mask) { > ^ > include/linux/cpumask.h:276:2: note: expanded from macro 'for_each_cpu' > for ((cpu) = -1; \ > ^ > In file included from kernel/rcu/tree.c:5031: > kernel/rcu/tree_nocb.h:1259:2: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] > rcu_organize_nocb_kthreads(); > ^ > kernel/rcu/tree_nocb.h:1259:28: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > rcu_organize_nocb_kthreads(); > ^ > void > kernel/rcu/tree_nocb.h:1259:2: error: conflicting types for 'rcu_organize_nocb_kthreads' > rcu_organize_nocb_kthreads(); > ^ > kernel/rcu/tree.h:463:20: note: previous declaration is here > static void __init rcu_organize_nocb_kthreads(void); > ^ > In file included from kernel/rcu/tree.c:5031: > kernel/rcu/tree_nocb.h:1260:1: error: extraneous closing brace ('}') > } > ^ > 5 warnings and 13 errors generated. > > > vim +/if +1213 kernel/rcu/tree_nocb.h > > 1209 > 1210 #if defined(CONFIG_NO_HZ_FULL) > 1211 if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) > 1212 need_rcu_nocb_mask = true; > > 1213 offload_all = false; /* NO_HZ_FULL has its own mask. */ > 1214 } > 1215 #endif /* #if defined(CONFIG_NO_HZ_FULL) */ > 1216 > 1217 if (need_rcu_nocb_mask) { > 1218 if (!cpumask_available(rcu_nocb_mask)) { > 1219 if (!zalloc_cpumask_var(&rcu_nocb_mask, GFP_KERNEL)) { > 1220 pr_info("rcu_nocb_mask allocation failed, callback offloading disabled.\n"); > 1221 return; > 1222 } > 1223 } > 1224 rcu_state.nocb_is_setup = true; > 1225 } > 1226 > 1227 if (!rcu_state.nocb_is_setup) > 1228 return; > 1229 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp