From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org,
Alexander Gordeev <agordeev@linux.ibm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Yury Norov <yury.norov@gmail.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH 0/4] bitmap: fix conversion from/to fix-sized arrays
Date: Wed, 20 Apr 2022 15:25:26 -0700 [thread overview]
Message-ID: <20220420222530.910125-1-yury.norov@gmail.com> (raw)
In the kernel codebase we have functions that call bitmap_copy()
to convert bitmaps to and from fix-sized 32 or 64-bit arrays. It
works well for LE architectures when size of long is equal to the
size of fixed type.
If the system is BE and/or size of long is not equal to the size of
fixed type of the array, bitmap_copy() may produce wrong result either
because of endianness issue, or because of out-of-bound access.
To address this problem we already have bitmap_{from,to}_arr32().
In recent discussion it was spotted that we also need 64-bit
analogue of it:
https://lore.kernel.org/all/YiCWNdWd+AsLbDkp@smile.fi.intel.com/T/#m754da92acb0003e12b99293d07ddcd46dbe04ada
This series takes care of it.
Yury Norov (4):
lib/bitmap: extend comment for bitmap_(from,to)_arr32()
lib: add bitmap_{from,to}_arr64
KVM: s390: replace bitmap_copy with bitmap_{from,to}_arr64 where
appropriate
drm/amd/pm: use bitmap_{from,to}_arr32 where appropriate
arch/s390/kvm/kvm-s390.c | 10 ++--
.../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +-
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 +-
include/linux/bitmap.h | 31 +++++++++---
lib/bitmap.c | 47 +++++++++++++++++++
5 files changed, 77 insertions(+), 15 deletions(-)
--
2.32.0
next reply other threads:[~2022-04-20 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 22:25 Yury Norov [this message]
2022-04-20 22:25 ` [PATCH 1/4] lib/bitmap: extend comment for bitmap_(from,to)_arr32() Yury Norov
2022-04-20 22:25 ` [PATCH 2/4] lib: add bitmap_{from,to}_arr64 Yury Norov
2022-04-21 7:40 ` David Laight
2022-04-21 16:31 ` Yury Norov
2022-04-20 22:25 ` [PATCH 3/4] KVM: s390: replace bitmap_copy with bitmap_{from,to}_arr64 where appropriate Yury Norov
2022-04-21 7:24 ` David Hildenbrand
2022-04-21 13:01 ` Yury Norov
2022-04-20 22:41 ` [PATCH 4/4] drm/amd/pm: use bitmap_{from,to}_arr32 " Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420222530.910125-1-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).