From: Bjorn Helgaas <helgaas@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 3/8] PCI: rcar-gen2: Add RZ/N1 SOCs support
Date: Fri, 22 Apr 2022 11:47:44 -0500 [thread overview]
Message-ID: <20220422164744.GA1460864@bhelgaas> (raw)
In-Reply-To: <20220422120850.769480-4-herve.codina@bootlin.com>
On Fri, Apr 22, 2022 at 02:08:45PM +0200, Herve Codina wrote:
> Add Renesas RZ/N1 SOCs family support to the Renesas R-Car
> gen2 PCI bridge driver.
> The Renesas RZ/N1 SOCs internal PCI bridge is comptible with
> the one available in the R-Car Gen2 family.
> Tested with the RZ/N1D (R9A06G032) SOC.
Nits (only address if you have some other reason to repost this
series):
- Subject claims this adds "support," which suggests that this adds
some piece of new functionality. But it adds no new
functionality, it merely adds a new compatible string. I would
say "Add RZ/N1 SOC compatible string"
- Add blank lines between paragraphs
- Rewrap paragraphs to fill 75 characters
- s/comptible/compatible/
- s/R-Car gen2/R-Car Gen2/ to write this consistently instead of
capitalizing "Gen2" sometimes but not others
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> drivers/pci/controller/pci-rcar-gen2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 35804ea394fd..839695791757 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -328,6 +328,7 @@ static const struct of_device_id rcar_pci_of_match[] = {
> { .compatible = "renesas,pci-r8a7791", },
> { .compatible = "renesas,pci-r8a7794", },
> { .compatible = "renesas,pci-rcar-gen2", },
> + { .compatible = "renesas,pci-rzn1", },
> { },
> };
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-22 16:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 12:08 [PATCH v3 0/8] RZN1 USB Host support Herve Codina
2022-04-22 12:08 ` [PATCH v3 1/8] dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema Herve Codina
2022-04-26 0:45 ` Rob Herring
2022-04-26 0:47 ` Rob Herring
2022-04-27 15:05 ` Geert Uytterhoeven
2022-04-22 12:08 ` [PATCH v3 2/8] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-04-26 0:46 ` Rob Herring
2022-04-27 15:15 ` Geert Uytterhoeven
2022-04-28 9:08 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 3/8] PCI: rcar-gen2: Add RZ/N1 SOCs support Herve Codina
2022-04-22 16:47 ` Bjorn Helgaas [this message]
2022-04-28 9:19 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 4/8] soc: renesas: rzn1: Select PM and PM_GENERIC_DOMAINS configs Herve Codina
2022-04-27 14:58 ` Geert Uytterhoeven
2022-04-28 9:15 ` Herve Codina
2022-04-28 9:22 ` Geert Uytterhoeven
2022-04-28 9:25 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 5/8] ARM: dts: r9a06g032: Add missing '#power-domain-cells' Herve Codina
2022-04-27 14:59 ` Geert Uytterhoeven
2022-04-22 12:08 ` [PATCH v3 6/8] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-28 9:49 ` Geert Uytterhoeven
2022-04-28 9:50 ` Geert Uytterhoeven
2022-04-28 10:08 ` Herve Codina
2022-04-28 10:07 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-23 9:09 ` Sergey Shtylyov
2022-04-23 16:41 ` Sergey Shtylyov
2022-04-28 9:23 ` Herve Codina
2022-04-28 9:51 ` Geert Uytterhoeven
2022-04-28 10:30 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 8/8] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
2022-04-28 9:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422164744.GA1460864@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).