From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: kernel test robot <lkp@intel.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"richard@nod.at" <richard@nod.at>,
"joern@lazybastard.org" <joern@lazybastard.org>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
kernel <kernel@axis.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
Date: Mon, 25 Apr 2022 10:30:15 +0200 [thread overview]
Message-ID: <20220425103015.1cc05f77@xps13> (raw)
In-Reply-To: <20220425102816.54619c66@xps13>
miquel.raynal@bootlin.com wrote on Mon, 25 Apr 2022 10:28:16 +0200:
> Hi Vincent,
>
> vincent.whitchurch@axis.com wrote on Thu, 14 Apr 2022 11:04:02 +0200:
>
> > On Wed, Apr 13, 2022 at 08:45:59AM +0200, kernel test robot wrote:
> > > All errors (new ones prefixed by >>):
> > >
> > > In file included from include/linux/io.h:13,
> > > from drivers/mtd/devices/phram.c:21:
> > > drivers/mtd/devices/phram.c: In function 'register_device':
> > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
> > > 274 | #define iounmap(addr) do { } while (0)
> > > | ^~
> > > drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap'
> > > 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv);
> > > | ^~~~~~~
> > > drivers/mtd/devices/phram.c: In function 'phram_remove':
> > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
> > > 274 | #define iounmap(addr) do { } while (0)
> > > | ^~
> > > drivers/mtd/devices/phram.c:372:53: note: in expansion of macro 'iounmap'
> > > 372 | phram->cached ? memunmap(phram->mtd.priv) : iounmap(phram->mtd.priv);
> > > | ^~~~~~~
> > >
> > >
> > > vim +/do +274 arch/sh/include/asm/io.h
> > >
> > > d57d64080ddc0f Paul Mundt 2010-01-19 272
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 273 #else /* CONFIG_MMU */
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 @274 #define iounmap(addr) do { } while (0)
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 275 #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset))
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 276 #endif /* CONFIG_MMU */
> > > d627a2ebd1a303 Paul Mundt 2010-01-28 277
> >
> > Thank you for the report. This patch could certainly be changed to work
> > around this, but ISTM that the right fix is in the SH header file, since
> > the problem could hit in other cases too. I've posted a fix here now:
> >
> > https://lore.kernel.org/lkml/20220414081257.1487499-1-vincent.whitchurch@axis.com/
>
> Looks good to me but I don't want to be the one "carrying" new compile
> errors so I'll drop the series for now, until you get this patch
> applied. Please then just resend the series with this thread mentioned
> and I'll take it back.
BTW, I'm only talking about this improvement, patches 1-3 will remain.
next prev parent reply other threads:[~2022-04-25 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 13:52 [PATCH v3 0/4] mtd: phram improvements Vincent Whitchurch
2022-04-12 13:52 ` [PATCH v3 1/4] mtd: core: Check devicetree alias for index Vincent Whitchurch
2022-04-21 7:36 ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 2/4] dt-bindings: reserved-memory: Support MTD/block device Vincent Whitchurch
2022-04-14 16:00 ` Rob Herring
2022-04-21 7:36 ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 3/4] mtd: phram: Allow probing via reserved-memory Vincent Whitchurch
2022-04-14 16:02 ` Rob Herring
2022-04-21 7:36 ` Miquel Raynal
2022-04-12 13:53 ` [PATCH v3 4/4] mtd: phram: Allow cached mappings Vincent Whitchurch
2022-04-13 6:45 ` kernel test robot
2022-04-14 9:04 ` Vincent Whitchurch
2022-04-25 8:28 ` Miquel Raynal
2022-04-25 8:30 ` Miquel Raynal [this message]
2022-05-10 15:26 ` Vincent Whitchurch
2022-04-21 7:35 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425103015.1cc05f77@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=joern@lazybastard.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).