* [PATCH v3 0/4] mainline Protonic PRTT1x boards
@ 2022-04-25 13:28 Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
` (3 more replies)
0 siblings, 4 replies; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-25 13:28 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32, linux-arm-kernel
changes v3:
- add silabs,wfx compatible
- move spi pin configuration to stm32mp15-pinctrl.dtsi
- move prtt1X compatible in alphabetical order
- add watchdog and thermal nodes
changes v2:
- cleanup mmc nodes
- disabled dma for uart4 (this is console interface and it should work
as simple as possible)
Oleksij Rempel (4):
dt-bindings: arm: stm32: Add compatible strings for Protonic T1L
boards
dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant
ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group
ARM: dts: stm32: add support for Protonic PRTT1x boards
.../devicetree/bindings/arm/stm32/stm32.yaml | 8 +
.../staging/net/wireless/silabs,wfx.yaml | 1 +
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 15 +
arch/arm/boot/dts/stm32mp151a-prtt1a.dts | 52 +++
arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 304 ++++++++++++++++++
arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi | 229 +++++++++++++
arch/arm/boot/dts/stm32mp151a-prtt1s.dts | 63 ++++
8 files changed, 675 insertions(+)
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1a.dts
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1c.dts
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1s.dts
--
2.30.2
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards
2022-04-25 13:28 [PATCH v3 0/4] mainline Protonic PRTT1x boards Oleksij Rempel
@ 2022-04-25 13:28 ` Oleksij Rempel
2022-04-25 13:53 ` Krzysztof Kozlowski
2022-04-25 13:28 ` [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant Oleksij Rempel
` (2 subsequent siblings)
3 siblings, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-25 13:28 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32, linux-arm-kernel
This boards are based on STM32MP151AAD3 and use 10BaseT1L for
communication.
- PRTT1C - 10BaseT1L switch
- PRTT1S - 10BaseT1L CO2 sensor board
- PRTT1A - 10BaseT1L multi functional controller
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index fa0a1b84122e..3a10be1c73d5 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -14,6 +14,14 @@ properties:
const: "/"
compatible:
oneOf:
+ - description: ST STM32MP151 based Boards
+ items:
+ - enum:
+ - prt,prtt1a # Protonic PRTT1A
+ - prt,prtt1c # Protonic PRTT1C
+ - prt,prtt1s # Protonic PRTT1S
+ - const: st,stm32mp151
+
- description: DH STM32MP1 SoM based Boards
items:
- enum:
--
2.30.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant
2022-04-25 13:28 [PATCH v3 0/4] mainline Protonic PRTT1x boards Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
@ 2022-04-25 13:28 ` Oleksij Rempel
2022-04-25 15:38 ` Jérôme Pouiller
2022-04-25 13:28 ` [PATCH v3 3/4] ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards Oleksij Rempel
3 siblings, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-25 13:28 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32, linux-arm-kernel
Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
board.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
index 105725a127ab..ce107fe45d7c 100644
--- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
+++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
@@ -39,6 +39,7 @@ properties:
compatible:
items:
- enum:
+ - prt,prtt1c-wfm200 # Protonic PRTT1C Board
- silabs,brd4001a # WGM160P Evaluation Board
- silabs,brd8022a # WF200 Evaluation Board
- silabs,brd8023a # WFM200 Evaluation Board
--
2.30.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 3/4] ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group
2022-04-25 13:28 [PATCH v3 0/4] mainline Protonic PRTT1x boards Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant Oleksij Rempel
@ 2022-04-25 13:28 ` Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards Oleksij Rempel
3 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-25 13:28 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32, linux-arm-kernel
Add spi1-1 pingroup as preparation for Protonic PRTT1C board.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index f0d66d8c6e3b..67a242b03813 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -2212,4 +2212,19 @@ pins2 {
bias-disable;
};
};
+
+ spi1_pins_b: spi1-1 {
+ pins1 {
+ pinmux = <STM32_PINMUX('A', 5, AF5)>, /* SPI1_SCK */
+ <STM32_PINMUX('B', 5, AF5)>; /* SPI1_MOSI */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <1>;
+ };
+
+ pins2 {
+ pinmux = <STM32_PINMUX('A', 6, AF5)>; /* SPI1_MISO */
+ bias-disable;
+ };
+ };
};
--
2.30.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards
2022-04-25 13:28 [PATCH v3 0/4] mainline Protonic PRTT1x boards Oleksij Rempel
` (2 preceding siblings ...)
2022-04-25 13:28 ` [PATCH v3 3/4] ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group Oleksij Rempel
@ 2022-04-25 13:28 ` Oleksij Rempel
2022-04-25 13:49 ` Marc Kleine-Budde
3 siblings, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-25 13:28 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32, linux-arm-kernel
This boards are based on STM32MP151AAD3 and use 10BaseT1L for communication.
- PRTT1C - 10BaseT1L switch
- PRTT1S - 10BaseT1L CO2 sensor board
- PRTT1A - 10BaseT1L multi functional controller
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/stm32mp151a-prtt1a.dts | 52 ++++
arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 304 ++++++++++++++++++++++
arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi | 229 ++++++++++++++++
arch/arm/boot/dts/stm32mp151a-prtt1s.dts | 63 +++++
5 files changed, 651 insertions(+)
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1a.dts
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1c.dts
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi
create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1s.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7c16f8a2b738..2585ba8e1293 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1156,6 +1156,9 @@ dtb-$(CONFIG_ARCH_STM32) += \
stm32h743i-disco.dtb \
stm32h750i-art-pi.dtb \
stm32mp135f-dk.dtb \
+ stm32mp151a-prtt1a.dtb \
+ stm32mp151a-prtt1c.dtb \
+ stm32mp151a-prtt1s.dtb \
stm32mp153c-dhcom-drc02.dtb \
stm32mp157a-avenger96.dtb \
stm32mp157a-dhcor-avenger96.dtb \
diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1a.dts b/arch/arm/boot/dts/stm32mp151a-prtt1a.dts
new file mode 100644
index 000000000000..75874eafde11
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp151a-prtt1a.dts
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * Copyright (C) Protonic Holland
+ * Author: David Jander <david@protonic.nl>
+ */
+/dts-v1/;
+
+#include "stm32mp151a-prtt1l.dtsi"
+
+/ {
+ model = "Protonic PRTT1A";
+ compatible = "prt,prtt1a", "st,stm32mp151";
+};
+
+ðernet0 {
+ phy-handle = <&phy0>;
+};
+
+&mdio0 {
+ /* TI DP83TD510E */
+ phy0: ethernet-phy@0 {
+ compatible = "ethernet-phy-id2000.0181";
+ reg = <0>;
+ interrupts-extended = <&gpioa 4 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpioa 3 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <35>;
+ };
+};
+
+&pwm5_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('A', 0, AF2)>; /* TIM5_CH1 */
+ };
+};
+
+&pwm5_sleep_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('A', 0, ANALOG)>; /* TIM5_CH1 */
+ };
+};
+
+&timers5 {
+ status = "okay";
+
+ pwm {
+ pinctrl-0 = <&pwm5_pins_a>;
+ pinctrl-1 = <&pwm5_sleep_pins_a>;
+ pinctrl-names = "default", "sleep";
+ status = "okay";
+ };
+};
diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
new file mode 100644
index 000000000000..0d542c8ff2c7
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
@@ -0,0 +1,304 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * Copyright (C) Protonic Holland
+ * Author: David Jander <david@protonic.nl>
+ */
+/dts-v1/;
+
+#include "stm32mp151a-prtt1l.dtsi"
+
+/ {
+ model = "Protonic PRTT1C";
+ compatible = "prt,prtt1c", "st,stm32mp151";
+
+ clock_ksz9031: clock-ksz9031 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
+ clock_sja1105: clock-sja1105 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
+ mdio0: mdio {
+ compatible = "virtual,mdio-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpios = <&gpioc 1 GPIO_ACTIVE_HIGH
+ &gpioa 2 GPIO_ACTIVE_HIGH>;
+
+ };
+
+ wifi_pwrseq: wifi-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpiod 8 GPIO_ACTIVE_LOW>;
+ };
+};
+
+ðernet0 {
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+};
+
+&gpioa {
+ gpio-line-names =
+ "", "", "", "PHY0_nRESET", "PHY0_nINT", "", "", "",
+ "", "", "", "", "", "", "", "SPI1_nSS";
+};
+
+&gpiod {
+ gpio-line-names =
+ "", "", "", "", "", "", "", "",
+ "WFM_RESET", "", "", "", "", "", "", "";
+};
+
+&gpioe {
+ gpio-line-names =
+ "SDMMC2_nRESET", "", "", "", "", "", "SPI1_nRESET", "",
+ "", "", "", "", "WFM_nIRQ", "", "", "";
+};
+
+&gpiog {
+ gpio-line-names =
+ "", "", "", "", "", "", "", "PHY3_nINT",
+ "PHY1_nINT", "PHY3_nRESET", "PHY2_nINT", "PHY2_nRESET",
+ "PHY1_nRESET", "SPE1_PWR", "SPE0_PWR", "";
+};
+
+&mdio0 {
+ /* All this DP83TD510E PHYs can't be probed before switch@0 is
+ * probed so we need to use compatible with PHYid
+ */
+ /* TI DP83TD510E */
+ t1l0_phy: ethernet-phy@6 {
+ compatible = "ethernet-phy-id2000.0181";
+ reg = <6>;
+ interrupts-extended = <&gpioa 4 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpioa 3 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <35>;
+ };
+
+ /* TI DP83TD510E */
+ t1l1_phy: ethernet-phy@7 {
+ compatible = "ethernet-phy-id2000.0181";
+ reg = <7>;
+ interrupts-extended = <&gpiog 8 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpiog 12 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <35>;
+ };
+
+ /* TI DP83TD510E */
+ t1l2_phy: ethernet-phy@10 {
+ compatible = "ethernet-phy-id2000.0181";
+ reg = <10>;
+ interrupts-extended = <&gpiog 10 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpiog 11 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <35>;
+ };
+
+ /* Micrel KSZ9031 */
+ rj45_phy: ethernet-phy@2 {
+ reg = <2>;
+ interrupts-extended = <&gpiog 7 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpiog 9 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <1000>;
+
+ clocks = <&clock_ksz9031>;
+ };
+};
+
+&qspi {
+ status = "disabled";
+};
+
+&sdmmc2 {
+ pinctrl-names = "default", "opendrain", "sleep";
+ pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
+ pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>;
+ pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
+ non-removable;
+ no-sd;
+ no-sdio;
+ no-1-8-v;
+ st,neg-edge;
+ bus-width = <8>;
+ vmmc-supply = <®_3v3>;
+ vqmmc-supply = <®_3v3>;
+ status = "okay";
+};
+
+&sdmmc2_b4_od_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
+ <STM32_PINMUX('B', 7, AF10)>, /* SDMMC2_D1 */
+ <STM32_PINMUX('B', 3, AF9)>, /* SDMMC2_D2 */
+ <STM32_PINMUX('B', 4, AF9)>; /* SDMMC2_D3 */
+ };
+};
+
+&sdmmc2_b4_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
+ <STM32_PINMUX('B', 7, AF10)>, /* SDMMC2_D1 */
+ <STM32_PINMUX('B', 3, AF9)>, /* SDMMC2_D2 */
+ <STM32_PINMUX('B', 4, AF9)>, /* SDMMC2_D3 */
+ <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
+ };
+};
+
+&sdmmc2_b4_sleep_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('B', 14, ANALOG)>, /* SDMMC2_D0 */
+ <STM32_PINMUX('B', 7, ANALOG)>, /* SDMMC2_D1 */
+ <STM32_PINMUX('B', 3, ANALOG)>, /* SDMMC2_D2 */
+ <STM32_PINMUX('B', 4, ANALOG)>, /* SDMMC2_D3 */
+ <STM32_PINMUX('E', 3, ANALOG)>, /* SDMMC2_CK */
+ <STM32_PINMUX('G', 6, ANALOG)>; /* SDMMC2_CMD */
+ };
+};
+
+&sdmmc2_d47_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
+ <STM32_PINMUX('A', 9, AF10)>, /* SDMMC2_D5 */
+ <STM32_PINMUX('C', 6, AF10)>, /* SDMMC2_D6 */
+ <STM32_PINMUX('C', 7, AF10)>; /* SDMMC2_D7 */
+ };
+};
+
+&sdmmc2_d47_sleep_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
+ <STM32_PINMUX('A', 9, ANALOG)>, /* SDMMC2_D5 */
+ <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
+ <STM32_PINMUX('D', 3, ANALOG)>; /* SDMMC2_D7 */
+ };
+};
+
+&sdmmc3 {
+ pinctrl-names = "default", "opendrain", "sleep";
+ pinctrl-0 = <&sdmmc3_b4_pins_b>;
+ pinctrl-1 = <&sdmmc3_b4_od_pins_b>;
+ pinctrl-2 = <&sdmmc3_b4_sleep_pins_b>;
+ non-removable;
+ no-1-8-v;
+ st,neg-edge;
+ bus-width = <4>;
+ vmmc-supply = <®_3v3>;
+ vqmmc-supply = <®_3v3>;
+ mmc-pwrseq = <&wifi_pwrseq>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ mmc@1 {
+ compatible = "prt,prtt1c-wfm200", "silabs,wf200";
+ reg = <1>;
+ };
+};
+
+&sdmmc3_b4_od_pins_b {
+ pins1 {
+ pinmux = <STM32_PINMUX('D', 1, AF10)>, /* SDMMC3_D0 */
+ <STM32_PINMUX('D', 4, AF10)>, /* SDMMC3_D1 */
+ <STM32_PINMUX('D', 5, AF10)>, /* SDMMC3_D2 */
+ <STM32_PINMUX('D', 7, AF10)>; /* SDMMC3_D3 */
+ };
+};
+
+&sdmmc3_b4_pins_b {
+ pins1 {
+ pinmux = <STM32_PINMUX('D', 1, AF10)>, /* SDMMC3_D0 */
+ <STM32_PINMUX('D', 4, AF10)>, /* SDMMC3_D1 */
+ <STM32_PINMUX('D', 5, AF10)>, /* SDMMC3_D2 */
+ <STM32_PINMUX('D', 7, AF10)>, /* SDMMC3_D3 */
+ <STM32_PINMUX('D', 0, AF10)>; /* SDMMC3_CMD */
+ };
+};
+
+&sdmmc3_b4_sleep_pins_b {
+ pins {
+ pinmux = <STM32_PINMUX('D', 1, ANALOG)>, /* SDMMC3_D0 */
+ <STM32_PINMUX('D', 4, ANALOG)>, /* SDMMC3_D1 */
+ <STM32_PINMUX('D', 5, ANALOG)>, /* SDMMC3_D2 */
+ <STM32_PINMUX('D', 7, ANALOG)>, /* SDMMC3_D3 */
+ <STM32_PINMUX('G', 15, ANALOG)>, /* SDMMC3_CK */
+ <STM32_PINMUX('D', 0, ANALOG)>; /* SDMMC3_CMD */
+ };
+};
+
+&spi1 {
+ pinctrl-0 = <&spi1_pins_b>;
+ pinctrl-names = "default";
+ cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;
+ /delete-property/dmas;
+ /delete-property/dma-names;
+ status = "okay";
+
+ switch@0 {
+ compatible = "nxp,sja1105q";
+ reg = <0>;
+ spi-max-frequency = <4000000>;
+ spi-rx-delay-us = <1>;
+ spi-tx-delay-us = <1>;
+ spi-cpha;
+
+ reset-gpios = <&gpioe 6 GPIO_ACTIVE_LOW>;
+
+ clocks = <&clock_sja1105>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "t1l0";
+ phy-mode = "rmii";
+ phy-handle = <&t1l0_phy>;
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "t1l1";
+ phy-mode = "rmii";
+ phy-handle = <&t1l1_phy>;
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "t1l2";
+ phy-mode = "rmii";
+ phy-handle = <&t1l2_phy>;
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "rj45";
+ phy-handle = <&rj45_phy>;
+ phy-mode = "rgmii-id";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "cpu";
+ ethernet = <ðernet0>;
+ phy-mode = "rmii";
+
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+ };
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi b/arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi
new file mode 100644
index 000000000000..d865ab5d866b
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi
@@ -0,0 +1,229 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * Copyright (C) Protonic Holland
+ * Author: David Jander <david@protonic.nl>
+ */
+/dts-v1/;
+
+#include "stm32mp151.dtsi"
+#include "stm32mp15-pinctrl.dtsi"
+#include "stm32mp15xxad-pinctrl.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+ aliases {
+ ethernet0 = ðernet0;
+ mdio-gpio0 = &mdio0;
+ serial0 = &uart4;
+ };
+
+ led-controller-0 {
+ compatible = "gpio-leds";
+
+ led-0 {
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_INDICATOR;
+ gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
+ };
+
+ led-1 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_INDICATOR;
+ gpios = <&gpioa 14 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
+
+ /* DP83TD510E PHYs have max MDC rate of 1.75MHz. Since we can't reduce
+ * stmmac MDC clock without reducing system bus rate, we need to use
+ * gpio based MDIO bus.
+ */
+ mdio0: mdio {
+ compatible = "virtual,mdio-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpios = <&gpioc 1 GPIO_ACTIVE_HIGH
+ &gpioa 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ reg_3v3: regulator-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "3v3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+};
+
+&dts {
+ status = "okay";
+};
+
+ðernet0 {
+ pinctrl-0 = <ðernet0_rmii_pins_a>;
+ pinctrl-1 = <ðernet0_rmii_sleep_pins_a>;
+ pinctrl-names = "default", "sleep";
+ phy-mode = "rmii";
+ status = "okay";
+};
+
+ðernet0_rmii_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 12, AF11)>, /* ETH1_RMII_TXD0 */
+ <STM32_PINMUX('B', 13, AF11)>, /* ETH1_RMII_TXD1 */
+ <STM32_PINMUX('B', 11, AF11)>; /* ETH1_RMII_TX_EN */
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('C', 4, AF11)>, /* ETH1_RMII_RXD0 */
+ <STM32_PINMUX('C', 5, AF11)>, /* ETH1_RMII_RXD1 */
+ <STM32_PINMUX('A', 1, AF11)>, /* ETH1_RMII_REF_CLK input */
+ <STM32_PINMUX('A', 7, AF11)>; /* ETH1_RMII_CRS_DV */
+ };
+};
+
+ðernet0_rmii_sleep_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 12, ANALOG)>, /* ETH1_RMII_TXD0 */
+ <STM32_PINMUX('B', 13, ANALOG)>, /* ETH1_RMII_TXD1 */
+ <STM32_PINMUX('B', 11, ANALOG)>, /* ETH1_RMII_TX_EN */
+ <STM32_PINMUX('C', 4, ANALOG)>, /* ETH1_RMII_RXD0 */
+ <STM32_PINMUX('C', 5, ANALOG)>, /* ETH1_RMII_RXD1 */
+ <STM32_PINMUX('A', 1, ANALOG)>, /* ETH1_RMII_REF_CLK */
+ <STM32_PINMUX('A', 7, ANALOG)>; /* ETH1_RMII_CRS_DV */
+ };
+};
+
+&iwdg2 {
+ status = "okay";
+};
+
+&qspi {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&qspi_clk_pins_a &qspi_bk1_pins_a>;
+ pinctrl-1 = <&qspi_clk_sleep_pins_a &qspi_bk1_sleep_pins_a>;
+ reg = <0x58003000 0x1000>, <0x70000000 0x4000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ flash@0 {
+ compatible = "spi-nand";
+ reg = <0>;
+ spi-rx-bus-width = <4>;
+ spi-max-frequency = <104000000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+};
+
+&qspi_bk1_pins_a {
+ pins1 {
+ bias-pull-up;
+ drive-push-pull;
+ slew-rate = <1>;
+ };
+};
+
+&rng1 {
+ status = "okay";
+};
+
+&sdmmc1 {
+ pinctrl-names = "default", "opendrain", "sleep";
+ pinctrl-0 = <&sdmmc1_b4_pins_a>;
+ pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
+ pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
+ broken-cd;
+ st,neg-edge;
+ bus-width = <4>;
+ vmmc-supply = <®_3v3>;
+ vqmmc-supply = <®_3v3>;
+ status = "okay";
+};
+
+&sdmmc1_b4_od_pins_a {
+ pins1 {
+ bias-pull-up;
+ };
+ pins2 {
+ bias-pull-up;
+ };
+};
+
+&sdmmc1_b4_pins_a {
+ pins1 {
+ bias-pull-up;
+ };
+ pins2 {
+ bias-pull-up;
+ };
+};
+
+&uart4 {
+ pinctrl-names = "default", "sleep", "idle";
+ pinctrl-0 = <&uart4_pins_a>;
+ pinctrl-1 = <&uart4_sleep_pins_a>;
+ pinctrl-2 = <&uart4_idle_pins_a>;
+ /delete-property/dmas;
+ /delete-property/dma-names;
+ status = "okay";
+};
+
+&uart4_idle_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 9, ANALOG)>; /* UART4_TX */
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('B', 2, AF8)>; /* UART4_RX */
+ bias-pull-up;
+ };
+};
+
+&uart4_pins_a {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 9, AF8)>; /* UART4_TX */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <0>;
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('B', 2, AF8)>; /* UART4_RX */
+ bias-pull-up;
+ };
+};
+
+&uart4_sleep_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('B', 9, ANALOG)>, /* UART4_TX */
+ <STM32_PINMUX('B', 2, ANALOG)>; /* UART4_RX */
+ };
+};
+
+&usbh_ehci {
+ phys = <&usbphyc_port0>;
+ phy-names = "usb";
+ status = "okay";
+};
+
+&usbotg_hs {
+ dr_mode = "host";
+ pinctrl-0 = <&usbotg_hs_pins_a>;
+ pinctrl-names = "default";
+ phys = <&usbphyc_port1 0>;
+ phy-names = "usb2-phy";
+ status = "okay";
+};
+
+&usbphyc {
+ status = "okay";
+};
+
+&usbphyc_port0 {
+ phy-supply = <®_3v3>;
+};
+
+&usbphyc_port1 {
+ phy-supply = <®_3v3>;
+};
diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1s.dts b/arch/arm/boot/dts/stm32mp151a-prtt1s.dts
new file mode 100644
index 000000000000..ad25929e64e6
--- /dev/null
+++ b/arch/arm/boot/dts/stm32mp151a-prtt1s.dts
@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * Copyright (C) Protonic Holland
+ * Author: David Jander <david@protonic.nl>
+ */
+/dts-v1/;
+
+#include "stm32mp151a-prtt1l.dtsi"
+
+/ {
+ model = "Protonic PRTT1S";
+ compatible = "prt,prtt1s", "st,stm32mp151";
+};
+
+ðernet0 {
+ phy-handle = <&phy0>;
+};
+
+&i2c1 {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&i2c1_pins_a>;
+ pinctrl-1 = <&i2c1_sleep_pins_a>;
+ clock-frequency = <100000>;
+ /delete-property/dmas;
+ /delete-property/dma-names;
+ status = "okay";
+
+ humidity-sensor@40 {
+ compatible = "ti,hdc1080";
+ reg = <0x40>;
+ };
+
+ co2-sensor@62 {
+ compatible = "sensirion,scd41";
+ reg = <0x62>;
+ };
+};
+
+&i2c1_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('D', 12, AF5)>, /* I2C1_SCL */
+ <STM32_PINMUX('D', 13, AF5)>; /* I2C1_SDA */
+ };
+};
+
+&i2c1_sleep_pins_a {
+ pins {
+ pinmux = <STM32_PINMUX('D', 12, ANALOG)>, /* I2C1_SCL */
+ <STM32_PINMUX('D', 13, ANALOG)>; /* I2C1_SDA */
+ };
+};
+
+&mdio0 {
+ /* TI DP83TD510E */
+ phy0: ethernet-phy@0 {
+ compatible = "ethernet-phy-id2000.0181";
+ reg = <0>;
+ interrupts-extended = <&gpioa 4 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpioa 3 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <35>;
+ };
+};
--
2.30.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards
2022-04-25 13:28 ` [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards Oleksij Rempel
@ 2022-04-25 13:49 ` Marc Kleine-Budde
0 siblings, 0 replies; 17+ messages in thread
From: Marc Kleine-Budde @ 2022-04-25 13:49 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller, linux-arm-kernel,
linux-kernel, kernel, linux-stm32
[-- Attachment #1: Type: text/plain, Size: 7031 bytes --]
On 25.04.2022 15:28:44, Oleksij Rempel wrote:
> This boards are based on STM32MP151AAD3 and use 10BaseT1L for communication.
>
> - PRTT1C - 10BaseT1L switch
> - PRTT1S - 10BaseT1L CO2 sensor board
> - PRTT1A - 10BaseT1L multi functional controller
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/Makefile | 3 +
> arch/arm/boot/dts/stm32mp151a-prtt1a.dts | 52 ++++
> arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 304 ++++++++++++++++++++++
> arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi | 229 ++++++++++++++++
> arch/arm/boot/dts/stm32mp151a-prtt1s.dts | 63 +++++
> 5 files changed, 651 insertions(+)
> create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1a.dts
> create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1c.dts
> create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1l.dtsi
> create mode 100644 arch/arm/boot/dts/stm32mp151a-prtt1s.dts
[...]
> diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
> new file mode 100644
> index 000000000000..0d542c8ff2c7
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
> @@ -0,0 +1,304 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (C) Protonic Holland
> + * Author: David Jander <david@protonic.nl>
> + */
> +/dts-v1/;
> +
> +#include "stm32mp151a-prtt1l.dtsi"
> +
> +/ {
> + model = "Protonic PRTT1C";
> + compatible = "prt,prtt1c", "st,stm32mp151";
> +
> + clock_ksz9031: clock-ksz9031 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> + clock_sja1105: clock-sja1105 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> + mdio0: mdio {
> + compatible = "virtual,mdio-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpios = <&gpioc 1 GPIO_ACTIVE_HIGH
> + &gpioa 2 GPIO_ACTIVE_HIGH>;
> +
> + };
> +
> + wifi_pwrseq: wifi-pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&gpiod 8 GPIO_ACTIVE_LOW>;
> + };
> +};
> +
> +ðernet0 {
> + fixed-link {
> + speed = <100>;
> + full-duplex;
> + };
> +};
> +
> +&gpioa {
> + gpio-line-names =
> + "", "", "", "PHY0_nRESET", "PHY0_nINT", "", "", "",
> + "", "", "", "", "", "", "", "SPI1_nSS";
> +};
> +
> +&gpiod {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "WFM_RESET", "", "", "", "", "", "", "";
> +};
> +
> +&gpioe {
> + gpio-line-names =
> + "SDMMC2_nRESET", "", "", "", "", "", "SPI1_nRESET", "",
> + "", "", "", "", "WFM_nIRQ", "", "", "";
> +};
> +
> +&gpiog {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "PHY3_nINT",
> + "PHY1_nINT", "PHY3_nRESET", "PHY2_nINT", "PHY2_nRESET",
> + "PHY1_nRESET", "SPE1_PWR", "SPE0_PWR", "";
> +};
> +
> +&mdio0 {
> + /* All this DP83TD510E PHYs can't be probed before switch@0 is
> + * probed so we need to use compatible with PHYid
> + */
> + /* TI DP83TD510E */
> + t1l0_phy: ethernet-phy@6 {
> + compatible = "ethernet-phy-id2000.0181";
> + reg = <6>;
> + interrupts-extended = <&gpioa 4 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&gpioa 3 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10>;
> + reset-deassert-us = <35>;
> + };
> +
> + /* TI DP83TD510E */
> + t1l1_phy: ethernet-phy@7 {
> + compatible = "ethernet-phy-id2000.0181";
> + reg = <7>;
> + interrupts-extended = <&gpiog 8 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&gpiog 12 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10>;
> + reset-deassert-us = <35>;
> + };
> +
> + /* TI DP83TD510E */
> + t1l2_phy: ethernet-phy@10 {
> + compatible = "ethernet-phy-id2000.0181";
> + reg = <10>;
> + interrupts-extended = <&gpiog 10 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&gpiog 11 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10>;
> + reset-deassert-us = <35>;
> + };
> +
> + /* Micrel KSZ9031 */
> + rj45_phy: ethernet-phy@2 {
> + reg = <2>;
> + interrupts-extended = <&gpiog 7 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&gpiog 9 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <1000>;
> +
> + clocks = <&clock_ksz9031>;
> + };
> +};
> +
> +&qspi {
> + status = "disabled";
> +};
> +
> +&sdmmc2 {
> + pinctrl-names = "default", "opendrain", "sleep";
> + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
> + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>;
> + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
> + non-removable;
> + no-sd;
> + no-sdio;
> + no-1-8-v;
> + st,neg-edge;
> + bus-width = <8>;
> + vmmc-supply = <®_3v3>;
> + vqmmc-supply = <®_3v3>;
> + status = "okay";
> +};
> +
> +&sdmmc2_b4_od_pins_a {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
> + <STM32_PINMUX('B', 7, AF10)>, /* SDMMC2_D1 */
> + <STM32_PINMUX('B', 3, AF9)>, /* SDMMC2_D2 */
> + <STM32_PINMUX('B', 4, AF9)>; /* SDMMC2_D3 */
> + };
> +};
> +
> +&sdmmc2_b4_pins_a {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
> + <STM32_PINMUX('B', 7, AF10)>, /* SDMMC2_D1 */
> + <STM32_PINMUX('B', 3, AF9)>, /* SDMMC2_D2 */
> + <STM32_PINMUX('B', 4, AF9)>, /* SDMMC2_D3 */
> + <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
> + };
> +};
> +
> +&sdmmc2_b4_sleep_pins_a {
> + pins {
> + pinmux = <STM32_PINMUX('B', 14, ANALOG)>, /* SDMMC2_D0 */
> + <STM32_PINMUX('B', 7, ANALOG)>, /* SDMMC2_D1 */
> + <STM32_PINMUX('B', 3, ANALOG)>, /* SDMMC2_D2 */
> + <STM32_PINMUX('B', 4, ANALOG)>, /* SDMMC2_D3 */
> + <STM32_PINMUX('E', 3, ANALOG)>, /* SDMMC2_CK */
> + <STM32_PINMUX('G', 6, ANALOG)>; /* SDMMC2_CMD */
> + };
> +};
> +
> +&sdmmc2_d47_pins_a {
> + pins {
> + pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
> + <STM32_PINMUX('A', 9, AF10)>, /* SDMMC2_D5 */
> + <STM32_PINMUX('C', 6, AF10)>, /* SDMMC2_D6 */
> + <STM32_PINMUX('C', 7, AF10)>; /* SDMMC2_D7 */
> + };
> +};
> +
> +&sdmmc2_d47_sleep_pins_a {
> + pins {
> + pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
> + <STM32_PINMUX('A', 9, ANALOG)>, /* SDMMC2_D5 */
> + <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
> + <STM32_PINMUX('D', 3, ANALOG)>; /* SDMMC2_D7 */
> + };
> +};
> +
> +&sdmmc3 {
> + pinctrl-names = "default", "opendrain", "sleep";
> + pinctrl-0 = <&sdmmc3_b4_pins_b>;
> + pinctrl-1 = <&sdmmc3_b4_od_pins_b>;
> + pinctrl-2 = <&sdmmc3_b4_sleep_pins_b>;
> + non-removable;
> + no-1-8-v;
> + st,neg-edge;
> + bus-width = <4>;
> + vmmc-supply = <®_3v3>;
> + vqmmc-supply = <®_3v3>;
> + mmc-pwrseq = <&wifi_pwrseq>;
nitpick: use tabs here, too
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards
2022-04-25 13:28 ` [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
@ 2022-04-25 13:53 ` Krzysztof Kozlowski
2022-04-25 14:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 13:53 UTC (permalink / raw)
To: Oleksij Rempel, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: kernel, linux-kernel, linux-stm32, linux-arm-kernel
On 25/04/2022 15:28, Oleksij Rempel wrote:
> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
> communication.
>
> - PRTT1C - 10BaseT1L switch
> - PRTT1S - 10BaseT1L CO2 sensor board
> - PRTT1A - 10BaseT1L multi functional controller
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards
2022-04-25 13:53 ` Krzysztof Kozlowski
@ 2022-04-25 14:06 ` Krzysztof Kozlowski
2022-04-26 6:35 ` Oleksij Rempel
0 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 14:06 UTC (permalink / raw)
To: Oleksij Rempel, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller
Cc: kernel, linux-kernel, linux-stm32, linux-arm-kernel
On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
> On 25/04/2022 15:28, Oleksij Rempel wrote:
>> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
>> communication.
>>
>> - PRTT1C - 10BaseT1L switch
>> - PRTT1S - 10BaseT1L CO2 sensor board
>> - PRTT1A - 10BaseT1L multi functional controller
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Although the order is still messed up. I through you will move the entry
just slightly up, not to the beginning, so maybe just rebase on top of:
https://lore.kernel.org/all/20220425140436.332467-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant
2022-04-25 13:28 ` [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant Oleksij Rempel
@ 2022-04-25 15:38 ` Jérôme Pouiller
2022-04-26 5:08 ` Oleksij Rempel
2022-04-26 7:21 ` [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 " Oleksij Rempel
0 siblings, 2 replies; 17+ messages in thread
From: Jérôme Pouiller @ 2022-04-25 15:38 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Oleksij Rempel, kernel
Cc: linux-kernel, linux-stm32, linux-arm-kernel
On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> board.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> index 105725a127ab..ce107fe45d7c 100644
> --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> @@ -39,6 +39,7 @@ properties:
> compatible:
> items:
> - enum:
> + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> - silabs,brd4001a # WGM160P Evaluation Board
> - silabs,brd8022a # WF200 Evaluation Board
> - silabs,brd8023a # WFM200 Evaluation Board
I think you also have to declare this new entry in wfx_sdio_of_match,
and/or wfx_spi_of_match and wfx_spi_id.
On the WFM200 variant, the antenna is built in the chip. So I think you
can point on the same configuration than the brd8023a.
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant
2022-04-25 15:38 ` Jérôme Pouiller
@ 2022-04-26 5:08 ` Oleksij Rempel
2022-04-26 8:10 ` Jérôme Pouiller
2022-04-26 7:21 ` [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 " Oleksij Rempel
1 sibling, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-26 5:08 UTC (permalink / raw)
To: Jérôme Pouiller
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > board.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > index 105725a127ab..ce107fe45d7c 100644
> > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > @@ -39,6 +39,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > - silabs,brd4001a # WGM160P Evaluation Board
> > - silabs,brd8022a # WF200 Evaluation Board
> > - silabs,brd8023a # WFM200 Evaluation Board
>
> I think you also have to declare this new entry in wfx_sdio_of_match,
> and/or wfx_spi_of_match and wfx_spi_id.
>
> On the WFM200 variant, the antenna is built in the chip. So I think you
> can point on the same configuration than the brd8023a.
We have attached Molex 47950 antenna on secondary RF output. Is it still
compatible with brd8023a?
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards
2022-04-25 14:06 ` Krzysztof Kozlowski
@ 2022-04-26 6:35 ` Oleksij Rempel
2022-04-26 6:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-26 6:35 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller, kernel,
linux-kernel, linux-stm32, linux-arm-kernel
On Mon, Apr 25, 2022 at 04:06:45PM +0200, Krzysztof Kozlowski wrote:
> On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
> > On 25/04/2022 15:28, Oleksij Rempel wrote:
> >> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
> >> communication.
> >>
> >> - PRTT1C - 10BaseT1L switch
> >> - PRTT1S - 10BaseT1L CO2 sensor board
> >> - PRTT1A - 10BaseT1L multi functional controller
> >>
> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> >> ---
> >
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Although the order is still messed up. I through you will move the entry
> just slightly up, not to the beginning, so maybe just rebase on top of:
> https://lore.kernel.org/all/20220425140436.332467-1-krzysztof.kozlowski@linaro.org/
I put it according to the SoC version. st,stm32mp151 would be the first
entry before stm32mp153. What order do you prefer, where should I put my
boards?
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards
2022-04-26 6:35 ` Oleksij Rempel
@ 2022-04-26 6:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-26 6:45 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Jérôme Pouiller, kernel,
linux-kernel, linux-stm32, linux-arm-kernel
On 26/04/2022 08:35, Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 04:06:45PM +0200, Krzysztof Kozlowski wrote:
>> On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
>>> On 25/04/2022 15:28, Oleksij Rempel wrote:
>>>> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
>>>> communication.
>>>>
>>>> - PRTT1C - 10BaseT1L switch
>>>> - PRTT1S - 10BaseT1L CO2 sensor board
>>>> - PRTT1A - 10BaseT1L multi functional controller
>>>>
>>>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>>>> ---
>>>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Although the order is still messed up. I through you will move the entry
>> just slightly up, not to the beginning, so maybe just rebase on top of:
>> https://lore.kernel.org/all/20220425140436.332467-1-krzysztof.kozlowski@linaro.org/
>
> I put it according to the SoC version. st,stm32mp151 would be the first
> entry before stm32mp153. What order do you prefer, where should I put my
> boards?
153 is defined lower. The first entry in the file is a trap. :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant
2022-04-25 15:38 ` Jérôme Pouiller
2022-04-26 5:08 ` Oleksij Rempel
@ 2022-04-26 7:21 ` Oleksij Rempel
2022-04-26 8:19 ` Jérôme Pouiller
1 sibling, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-26 7:21 UTC (permalink / raw)
To: Jérôme Pouiller
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > board.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > index 105725a127ab..ce107fe45d7c 100644
> > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > @@ -39,6 +39,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > - silabs,brd4001a # WGM160P Evaluation Board
> > - silabs,brd8022a # WF200 Evaluation Board
> > - silabs,brd8023a # WFM200 Evaluation Board
>
> I think you also have to declare this new entry in wfx_sdio_of_match,
> and/or wfx_spi_of_match and wfx_spi_id.
>
> On the WFM200 variant, the antenna is built in the chip. So I think you
> can point on the same configuration than the brd8023a.
I assume driver update can be made in a separate patch. As soon as we
reserved compatible for this boards there should be no conflicts. This patches
series is targeting only devicetree and needed DT schema changes.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant
2022-04-26 5:08 ` Oleksij Rempel
@ 2022-04-26 8:10 ` Jérôme Pouiller
0 siblings, 0 replies; 17+ messages in thread
From: Jérôme Pouiller @ 2022-04-26 8:10 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Tuesday 26 April 2022 07:08:12 CEST Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > > board.
> > >
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > index 105725a127ab..ce107fe45d7c 100644
> > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > @@ -39,6 +39,7 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > - silabs,brd4001a # WGM160P Evaluation Board
> > > - silabs,brd8022a # WF200 Evaluation Board
> > > - silabs,brd8023a # WFM200 Evaluation Board
> >
> > I think you also have to declare this new entry in wfx_sdio_of_match,
> > and/or wfx_spi_of_match and wfx_spi_id.
> >
> > On the WFM200 variant, the antenna is built in the chip. So I think you
> > can point on the same configuration than the brd8023a.
>
> We have attached Molex 47950 antenna on secondary RF output. Is it still
> compatible with brd8023a?
I think it is not. You will have to provide the configuration file for
this board.
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant
2022-04-26 7:21 ` [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 " Oleksij Rempel
@ 2022-04-26 8:19 ` Jérôme Pouiller
2022-04-26 8:33 ` Oleksij Rempel
0 siblings, 1 reply; 17+ messages in thread
From: Jérôme Pouiller @ 2022-04-26 8:19 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > > board.
> > >
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > index 105725a127ab..ce107fe45d7c 100644
> > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > @@ -39,6 +39,7 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > - silabs,brd4001a # WGM160P Evaluation Board
> > > - silabs,brd8022a # WF200 Evaluation Board
> > > - silabs,brd8023a # WFM200 Evaluation Board
> >
> > I think you also have to declare this new entry in wfx_sdio_of_match,
> > and/or wfx_spi_of_match and wfx_spi_id.
> >
> > On the WFM200 variant, the antenna is built in the chip. So I think you
> > can point on the same configuration than the brd8023a.
>
> I assume driver update can be made in a separate patch. As soon as we
> reserved compatible for this boards there should be no conflicts. This patches
> series is targeting only devicetree and needed DT schema changes.
hmmm... I am not DT specialist, but it seems a bit weird to have a new
entry in the dt schema, but no new code in any of_match table.
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant
2022-04-26 8:19 ` Jérôme Pouiller
@ 2022-04-26 8:33 ` Oleksij Rempel
2022-04-26 8:56 ` Jérôme Pouiller
0 siblings, 1 reply; 17+ messages in thread
From: Oleksij Rempel @ 2022-04-26 8:33 UTC (permalink / raw)
To: Jérôme Pouiller
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Tue, Apr 26, 2022 at 10:19:29AM +0200, Jérôme Pouiller wrote:
> On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote:
> > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > > > board.
> > > >
> > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > ---
> > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > index 105725a127ab..ce107fe45d7c 100644
> > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > @@ -39,6 +39,7 @@ properties:
> > > > compatible:
> > > > items:
> > > > - enum:
> > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > > - silabs,brd4001a # WGM160P Evaluation Board
> > > > - silabs,brd8022a # WF200 Evaluation Board
> > > > - silabs,brd8023a # WFM200 Evaluation Board
> > >
> > > I think you also have to declare this new entry in wfx_sdio_of_match,
> > > and/or wfx_spi_of_match and wfx_spi_id.
> > >
> > > On the WFM200 variant, the antenna is built in the chip. So I think you
> > > can point on the same configuration than the brd8023a.
> >
> > I assume driver update can be made in a separate patch. As soon as we
> > reserved compatible for this boards there should be no conflicts. This patches
> > series is targeting only devicetree and needed DT schema changes.
>
> hmmm... I am not DT specialist, but it seems a bit weird to have a new
> entry in the dt schema, but no new code in any of_match table.
Here is one example:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml?h=v5.18-rc4#n28
properties:
compatible:
oneOf:
- const: fsl,imx1-cspi
- const: fsl,imx21-cspi
- const: fsl,imx27-cspi
- const: fsl,imx31-cspi
- const: fsl,imx35-cspi
- const: fsl,imx51-ecspi
- const: fsl,imx53-ecspi
- items:
- enum:
- fsl,imx50-ecspi
- fsl,imx6q-ecspi
- fsl,imx6sx-ecspi
- fsl,imx6sl-ecspi
- fsl,imx6sll-ecspi
- fsl,imx6ul-ecspi
- fsl,imx7d-ecspi
- fsl,imx8mq-ecspi
- fsl,imx8mm-ecspi
- fsl,imx8mn-ecspi
- fsl,imx8mp-ecspi
- const: fsl,imx51-ecspi
httpt://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-imx.c?h=v5.18-rc4#n1063
static const struct of_device_id spi_imx_dt_ids[] = {
{ .compatible = "fsl,imx1-cspi", .data = &imx1_cspi_devtype_data, },
{ .compatible = "fsl,imx21-cspi", .data = &imx21_cspi_devtype_data, },
{ .compatible = "fsl,imx27-cspi", .data = &imx27_cspi_devtype_data, },
{ .compatible = "fsl,imx31-cspi", .data = &imx31_cspi_devtype_data, },
{ .compatible = "fsl,imx35-cspi", .data = &imx35_cspi_devtype_data, },
{ .compatible = "fsl,imx51-ecspi", .data = &imx51_ecspi_devtype_data, },
{ .compatible = "fsl,imx53-ecspi", .data = &imx53_ecspi_devtype_data, },
{ .compatible = "fsl,imx6ul-ecspi", .data = &imx6ul_ecspi_devtype_data, },
{ /* sentinel */ }
};
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant
2022-04-26 8:33 ` Oleksij Rempel
@ 2022-04-26 8:56 ` Jérôme Pouiller
0 siblings, 0 replies; 17+ messages in thread
From: Jérôme Pouiller @ 2022-04-26 8:56 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, kernel, linux-kernel, linux-stm32,
linux-arm-kernel
On Tuesday 26 April 2022 10:33:05 CEST Oleksij Rempel wrote:
> On Tue, Apr 26, 2022 at 10:19:29AM +0200, Jérôme Pouiller wrote:
> > On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote:
> > > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote:
> > > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C
> > > > > board.
> > > > >
> > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > > ---
> > > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > > index 105725a127ab..ce107fe45d7c 100644
> > > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml
> > > > > @@ -39,6 +39,7 @@ properties:
> > > > > compatible:
> > > > > items:
> > > > > - enum:
> > > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > > > - silabs,brd4001a # WGM160P Evaluation Board
> > > > > - silabs,brd8022a # WF200 Evaluation Board
> > > > > - silabs,brd8023a # WFM200 Evaluation Board
> > > >
> > > > I think you also have to declare this new entry in wfx_sdio_of_match,
> > > > and/or wfx_spi_of_match and wfx_spi_id.
> > > >
> > > > On the WFM200 variant, the antenna is built in the chip. So I think you
> > > > can point on the same configuration than the brd8023a.
> > >
> > > I assume driver update can be made in a separate patch. As soon as we
> > > reserved compatible for this boards there should be no conflicts. This patches
> > > series is targeting only devicetree and needed DT schema changes.
> >
> > hmmm... I am not DT specialist, but it seems a bit weird to have a new
> > entry in the dt schema, but no new code in any of_match table.
>
> Here is one example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml?h=v5.18-rc4
> properties:
> compatible:
> oneOf:
> - const: fsl,imx1-cspi
> - const: fsl,imx21-cspi
> - const: fsl,imx27-cspi
> - const: fsl,imx31-cspi
> - const: fsl,imx35-cspi
> - const: fsl,imx51-ecspi
> - const: fsl,imx53-ecspi
> - items:
> - enum:
> - fsl,imx50-ecspi
> - fsl,imx6q-ecspi
> - fsl,imx6sx-ecspi
> - fsl,imx6sl-ecspi
> - fsl,imx6sll-ecspi
> - fsl,imx6ul-ecspi
> - fsl,imx7d-ecspi
> - fsl,imx8mq-ecspi
> - fsl,imx8mm-ecspi
> - fsl,imx8mn-ecspi
> - fsl,imx8mp-ecspi
> - const: fsl,imx51-ecspi
>
> httpt://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-imx.c?h=v5.18-rc4#n1063
> static const struct of_device_id spi_imx_dt_ids[] = {
> { .compatible = "fsl,imx1-cspi", .data = &imx1_cspi_devtype_data, },
> { .compatible = "fsl,imx21-cspi", .data = &imx21_cspi_devtype_data, },
> { .compatible = "fsl,imx27-cspi", .data = &imx27_cspi_devtype_data, },
> { .compatible = "fsl,imx31-cspi", .data = &imx31_cspi_devtype_data, },
> { .compatible = "fsl,imx35-cspi", .data = &imx35_cspi_devtype_data, },
> { .compatible = "fsl,imx51-ecspi", .data = &imx51_ecspi_devtype_data, },
> { .compatible = "fsl,imx53-ecspi", .data = &imx53_ecspi_devtype_data, },
> { .compatible = "fsl,imx6ul-ecspi", .data = &imx6ul_ecspi_devtype_data, },
> { /* sentinel */ }
> };
Right.
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-04-26 9:38 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 13:28 [PATCH v3 0/4] mainline Protonic PRTT1x boards Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
2022-04-25 13:53 ` Krzysztof Kozlowski
2022-04-25 14:06 ` Krzysztof Kozlowski
2022-04-26 6:35 ` Oleksij Rempel
2022-04-26 6:45 ` Krzysztof Kozlowski
2022-04-25 13:28 ` [PATCH v3 2/4] dt-bindings: net: silabs,wfx: add prt,prtt1c-wfm200 antenna variant Oleksij Rempel
2022-04-25 15:38 ` Jérôme Pouiller
2022-04-26 5:08 ` Oleksij Rempel
2022-04-26 8:10 ` Jérôme Pouiller
2022-04-26 7:21 ` [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 " Oleksij Rempel
2022-04-26 8:19 ` Jérôme Pouiller
2022-04-26 8:33 ` Oleksij Rempel
2022-04-26 8:56 ` Jérôme Pouiller
2022-04-25 13:28 ` [PATCH v3 3/4] ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group Oleksij Rempel
2022-04-25 13:28 ` [PATCH v3 4/4] ARM: dts: stm32: add support for Protonic PRTT1x boards Oleksij Rempel
2022-04-25 13:49 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).