linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards
@ 2022-04-25 14:04 Krzysztof Kozlowski
  2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 14:04 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
	Alexandre Torgue, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel
  Cc: Oleksij Rempel, Krzysztof Kozlowski

The bindings for DH STM32MP1 SoM boards allows invalid combinations,
e.g. st,stm32mp153 SoC on a dh,stm32mp157c-dhcom-som SoM.

Split the enums to properly match valid setups.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/arm/stm32/stm32.yaml  | 37 +++++++++++--------
 1 file changed, 22 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index fa0a1b84122e..2f83f2760e6a 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -14,21 +14,6 @@ properties:
     const: "/"
   compatible:
     oneOf:
-      - description: DH STM32MP1 SoM based Boards
-        items:
-          - enum:
-              - arrow,stm32mp157a-avenger96 # Avenger96
-              - dh,stm32mp153c-dhcom-drc02
-              - dh,stm32mp157c-dhcom-pdk2
-              - dh,stm32mp157c-dhcom-picoitx
-          - enum:
-              - dh,stm32mp153c-dhcom-som
-              - dh,stm32mp157a-dhcor-som
-              - dh,stm32mp157c-dhcom-som
-          - enum:
-              - st,stm32mp153
-              - st,stm32mp157
-
       - description: emtrion STM32MP1 Argon based Boards
         items:
           - const: emtrion,stm32mp157c-emsbc-argon
@@ -65,6 +50,13 @@ properties:
           - enum:
               - st,stm32mp135f-dk
           - const: st,stm32mp135
+
+      - description: DH STM32MP153 SoM based Boards
+        items:
+          - const: dh,stm32mp153c-dhcom-drc02
+          - const: dh,stm32mp153c-dhcom-som
+          - const: st,stm32mp153
+
       - items:
           - enum:
               - shiratech,stm32mp157a-iot-box # IoT Box
@@ -79,6 +71,21 @@ properties:
           - const: st,stm32mp157c-ed1
           - const: st,stm32mp157
 
+      - description: DH STM32MP1 SoM based Boards
+        items:
+          - enum:
+              - arrow,stm32mp157a-avenger96 # Avenger96
+          - const: dh,stm32mp157a-dhcor-som
+          - const: st,stm32mp157
+
+      - description: DH STM32MP1 SoM based Boards
+        items:
+          - enum:
+              - dh,stm32mp157c-dhcom-pdk2
+              - dh,stm32mp157c-dhcom-picoitx
+          - const: dh,stm32mp157c-dhcom-som
+          - const: st,stm32mp157
+
       - description: Engicam i.Core STM32MP1 SoM based Boards
         items:
           - enum:
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines
  2022-04-25 14:04 [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Krzysztof Kozlowski
@ 2022-04-25 14:04 ` Krzysztof Kozlowski
  2022-04-26 18:15   ` Rob Herring
  2022-05-02  8:31   ` Alexandre TORGUE
  2022-04-26 18:15 ` [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Rob Herring
  2022-05-02  8:01 ` Alexandre TORGUE
  2 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 14:04 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
	Alexandre Torgue, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel
  Cc: Oleksij Rempel, Krzysztof Kozlowski

Correct blank lines to precesily separate entries.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 2f83f2760e6a..80b29f6903f0 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -64,8 +64,8 @@ properties:
               - st,stm32mp157c-ed1
               - st,stm32mp157a-dk1
               - st,stm32mp157c-dk2
-
           - const: st,stm32mp157
+
       - items:
           - const: st,stm32mp157c-ev1
           - const: st,stm32mp157c-ed1
@@ -110,6 +110,7 @@ properties:
           - const: oct,stm32mp15xx-osd32
           - enum:
               - st,stm32mp157
+
       - description: Odyssey STM32MP1 SoM based Boards
         items:
           - enum:
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards
  2022-04-25 14:04 [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Krzysztof Kozlowski
  2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
@ 2022-04-26 18:15 ` Rob Herring
  2022-05-02  8:01 ` Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-04-26 18:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Alexandre Torgue, Oleksij Rempel, Krzysztof Kozlowski,
	linux-kernel, devicetree, linux-stm32, Maxime Coquelin,
	linux-arm-kernel, Rob Herring

On Mon, 25 Apr 2022 16:04:35 +0200, Krzysztof Kozlowski wrote:
> The bindings for DH STM32MP1 SoM boards allows invalid combinations,
> e.g. st,stm32mp153 SoC on a dh,stm32mp157c-dhcom-som SoM.
> 
> Split the enums to properly match valid setups.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/arm/stm32/stm32.yaml  | 37 +++++++++++--------
>  1 file changed, 22 insertions(+), 15 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines
  2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
@ 2022-04-26 18:15   ` Rob Herring
  2022-05-02  8:31   ` Alexandre TORGUE
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-04-26 18:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Alexandre Torgue, Krzysztof Kozlowski, linux-arm-kernel,
	Oleksij Rempel, Maxime Coquelin, linux-stm32, Rob Herring,
	devicetree, linux-kernel

On Mon, 25 Apr 2022 16:04:36 +0200, Krzysztof Kozlowski wrote:
> Correct blank lines to precesily separate entries.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards
  2022-04-25 14:04 [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Krzysztof Kozlowski
  2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
  2022-04-26 18:15 ` [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Rob Herring
@ 2022-05-02  8:01 ` Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2022-05-02  8:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel
  Cc: Oleksij Rempel

Hi krzysztof

On 4/25/22 16:04, Krzysztof Kozlowski wrote:
> The bindings for DH STM32MP1 SoM boards allows invalid combinations,
> e.g. st,stm32mp153 SoC on a dh,stm32mp157c-dhcom-som SoM.
> 
> Split the enums to properly match valid setups.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../devicetree/bindings/arm/stm32/stm32.yaml  | 37 +++++++++++--------
>   1 file changed, 22 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index fa0a1b84122e..2f83f2760e6a 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -14,21 +14,6 @@ properties:
>       const: "/"
>     compatible:
>       oneOf:
> -      - description: DH STM32MP1 SoM based Boards
> -        items:
> -          - enum:
> -              - arrow,stm32mp157a-avenger96 # Avenger96
> -              - dh,stm32mp153c-dhcom-drc02
> -              - dh,stm32mp157c-dhcom-pdk2
> -              - dh,stm32mp157c-dhcom-picoitx
> -          - enum:
> -     Applied on stm32-next.

Thanks.
Alex         - dh,stm32mp153c-dhcom-som
> -              - dh,stm32mp157a-dhcor-som
> -              - dh,stm32mp157c-dhcom-som
> -          - enum:
> -              - st,stm32mp153
> -              - st,stm32mp157
> -
>         - description: emtrion STM32MP1 Argon based Boards
>           items:
>             - const: emtrion,stm32mp157c-emsbc-argon
> @@ -65,6 +50,13 @@ properties:
>             - enum:
>                 - st,stm32mp135f-dk
>             - const: st,stm32mp135
> +
> +      - description: DH STM32MP153 SoM based Boards
> +        items:
> +          - const: dh,stm32mp153c-dhcom-drc02
> +          - const: dh,stm32mp153c-dhcom-som
> +          - const: st,stm32mp153
> +
>         - items:
>             - enum:
>                 - shiratech,stm32mp157a-iot-box # IoT Box
> @@ -79,6 +71,21 @@ properties:
>             - const: st,stm32mp157c-ed1
>             - const: st,stm32mp157
>   
> +      - description: DH STM32MP1 SoM based Boards
> +        items:
> +          - enum:
> +              - arrow,stm32mp157a-avenger96 # Avenger96
> +          - const: dh,stm32mp157a-dhcor-som
> +          - const: st,stm32mp157
> +
> +      - description: DH STM32MP1 SoM based Boards
> +        items:
> +          - enum:
> +              - dh,stm32mp157c-dhcom-pdk2
> +              - dh,stm32mp157c-dhcom-picoitx
> +          - const: dh,stm32mp157c-dhcom-som
> +          - const: st,stm32mp157
> +
>         - description: Engicam i.Core STM32MP1 SoM based Boards
>           items:
>             - enum:

Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines
  2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
  2022-04-26 18:15   ` Rob Herring
@ 2022-05-02  8:31   ` Alexandre TORGUE
  1 sibling, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2022-05-02  8:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel
  Cc: Oleksij Rempel

Hi Krzysztof

On 4/25/22 16:04, Krzysztof Kozlowski wrote:
> Correct blank lines to precesily separate entries.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 2f83f2760e6a..80b29f6903f0 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -64,8 +64,8 @@ properties:
>                 - st,stm32mp157c-ed1
>                 - st,stm32mp157a-dk1
>                 - st,stm32mp157c-dk2
> -
>             - const: st,stm32mp157
> +
>         - items:
>             - const: st,stm32mp157c-ev1
>             - const: st,stm32mp157c-ed1
> @@ -110,6 +110,7 @@ properties:
>             - const: oct,stm32mp15xx-osd32
>             - enum:
>                 - st,stm32mp157
> +
>         - description: Odyssey STM32MP1 SoM based Boards
>           items:
>             - enum:

Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-02  8:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 14:04 [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Krzysztof Kozlowski
2022-04-25 14:04 ` [PATCH 2/2] dt-bindings: arm: stm32: correct blank lines Krzysztof Kozlowski
2022-04-26 18:15   ` Rob Herring
2022-05-02  8:31   ` Alexandre TORGUE
2022-04-26 18:15 ` [PATCH 1/2] dt-bindings: arm: stm32: narrow DH STM32MP1 SoM boards Rob Herring
2022-05-02  8:01 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).