From: Sudeep Holla <sudeep.holla@arm.com>
To: 王擎 <wangqing@vivo.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>
Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI
Date: Mon, 25 Apr 2022 17:59:46 +0100 [thread overview]
Message-ID: <20220425165946.qb6xilgmjahdh4pa@bogus> (raw)
In-Reply-To: <SL2PR06MB308217E24459AB685FBF6FD2BDF89@SL2PR06MB3082.apcprd06.prod.outlook.com>
On Mon, Apr 25, 2022 at 11:18:21AM +0000, 王擎 wrote:
>
> >> From: Wang Qing <wangqing@vivo.com>
> >>
> >> cluster sched_domain configured by cpu_topology[].cluster_sibling,
> >> which is set by cluster_id, cluster_id can only get from ACPI.
> >>
> >> If the system does not enable ACPI, cluster_id is always -1, even enable
> >> SCHED_CLUSTER is invalid, this is misleading.
> >>
> >> So we add SCHED_CLUSTER's dependency on ACPI here.
> >>
> >
> >Any reason why this can't be extended to support DT based systems via
> >cpu-map in the device tree. IMO we almost have everything w.r.t topology
> >in DT and no reason to deviate this feature between ACPI and DT.
> >
> That's the problem, we parse out "cluster" info according to the
> description in cpu-map, but do assign it to package_id, which used to
> configure the MC sched domain, not cluster sched domain.
>
Right, we haven't updated the code after updating the bindings to match
ACPI sockets which are the physical package boundaries. Clusters are not
the physical boundaries and the current topology code is not 100% aligned
with the bindings after Commit 849b384f92bc ("Documentation: DT: arm: add
support for sockets defining package boundaries")
> That is to say, "cluster" in cpu-map is used to describe the package_id.
> We can't get cluster_id from DT.
>
That is wrong, we have "socket" to describe the package_id now.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-04-25 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 2:55 [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Qing Wang
2022-04-25 10:06 ` Sudeep Holla
2022-04-25 11:18 ` 王擎
2022-04-25 16:59 ` Sudeep Holla [this message]
2022-04-26 2:23 ` 王擎
2022-04-26 6:40 ` Sudeep Holla
2022-04-26 6:52 ` 王擎
2022-04-26 13:25 ` Sudeep Holla
2022-04-26 19:14 ` Dietmar Eggemann
2022-04-27 2:18 ` 王擎
2022-04-27 15:47 ` Dietmar Eggemann
2022-04-28 0:04 ` 王擎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425165946.qb6xilgmjahdh4pa@bogus \
--to=sudeep.holla@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=wangqing@vivo.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).