From: Adam Manzanares <a.manzanares@samsung.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rientjes@google.com" <rientjes@google.com>,
"yosryahmed@google.com" <yosryahmed@google.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"shakeelb@google.com" <shakeelb@google.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
"gthelen@google.com" <gthelen@google.com>,
Heekwon Park <heekwon.p@samsung.com>,
Jongmin Gim <gim.jongmin@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node_reclaim
Date: Mon, 25 Apr 2022 22:32:17 +0000 [thread overview]
Message-ID: <20220425223217.GB147460@bgt-140510-bm01> (raw)
In-Reply-To: <20220416053902.68517-3-dave@stgolabs.net>
On Fri, Apr 15, 2022 at 10:38:58PM -0700, Davidlohr Bueso wrote:
> We have helpers for a reason.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 1678802e03e7..cb583fcbf5bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4750,7 +4750,7 @@ int node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned int order)
> * over remote processors and spread off node memory allocations
> * as wide as possible.
> */
> - if (node_state(pgdat->node_id, N_CPU) && pgdat->node_id != numa_node_id())
> + if (node_is_toptier(pgdat->node_id) && pgdat->node_id != numa_node_id())
> return NODE_RECLAIM_NOSCAN;
>
> if (test_and_set_bit(PGDAT_RECLAIM_LOCKED, &pgdat->flags))
> --
> 2.26.2
>
Looks good.
Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
next prev parent reply other threads:[~2022-04-25 22:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 5:38 [PATCH RFC lsfmm 0/6] mm: proactive reclaim and memory tiering topics Davidlohr Bueso
2022-04-16 5:38 ` [PATCH 1/6] drivers/base/node: cleanup register_node() Davidlohr Bueso
2022-04-25 22:30 ` Adam Manzanares
2022-05-03 18:17 ` David Hildenbrand
2022-05-04 4:33 ` David Rientjes
2022-04-16 5:38 ` [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node_reclaim Davidlohr Bueso
2022-04-25 22:32 ` Adam Manzanares [this message]
2022-05-04 4:33 ` David Rientjes
2022-05-04 7:26 ` Jagdish Gediya
2022-05-31 11:50 ` Aneesh Kumar K.V
2022-06-01 6:12 ` Ying Huang
2022-06-01 14:00 ` Davidlohr Bueso
2022-04-16 5:38 ` [PATCH 3/6] mm: make __node_reclaim() more flexible Davidlohr Bueso
2022-04-16 5:39 ` [PATCH 4/6] mm: introduce per-node proactive reclaim interface Davidlohr Bueso
2022-04-19 0:00 ` Tim Chen
2022-04-16 5:39 ` [PATCH 5/6] mm/migration: export demotion_path of a node via sysfs Davidlohr Bueso
2022-04-22 17:31 ` Yang Shi
2022-04-22 17:33 ` Yang Shi
2022-04-22 17:50 ` Davidlohr Bueso
2022-04-17 3:49 ` [PATCH 6/6] mm/migrate: export whether or not node is toptier in sysf Davidlohr Bueso
2022-04-18 15:34 ` Dave Hansen
2022-04-18 16:45 ` Davidlohr Bueso
2022-04-18 16:50 ` Dave Hansen
2022-04-18 17:01 ` Davidlohr Bueso
2022-04-22 17:37 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425223217.GB147460@bgt-140510-bm01 \
--to=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=gim.jongmin@samsung.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=heekwon.p@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tim.c.chen@linux.intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).