From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C55B9C433FE for ; Wed, 27 Apr 2022 12:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234083AbiD0MZw (ORCPT ); Wed, 27 Apr 2022 08:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233930AbiD0MZr (ORCPT ); Wed, 27 Apr 2022 08:25:47 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9146C4132E; Wed, 27 Apr 2022 05:22:35 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B9681F74B; Wed, 27 Apr 2022 12:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651062154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bPJVJ/mvoFlMUFOZPBJ+knXZSOjq1aUlwWwkq9LhQTo=; b=n6Zsmd3ZvSPkPhiIdXXfFL6ehZn8AL7BshvVE3p+w5JDx9muTQd5wKkGExHgczFgQH8G4e d8rlT0rW81Ve1qiYTkNlC1dukAx4Q4DIDccyG20zh1OfPZXR6eF7ygx84SM0nBfFl5krNz Ihf/Jng1e1v9VeCT1AdFdSHRSN77vjg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD64F13A39; Wed, 27 Apr 2022 12:22:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AT8+MYk1aWLfOAAAMHmgww (envelope-from ); Wed, 27 Apr 2022 12:22:33 +0000 Date: Wed, 27 Apr 2022 14:22:32 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Shakeel Butt Cc: Vasily Averin , Vlastimil Babka , Roman Gushchin , kernel@openvz.org, Florian Westphal , LKML , Michal Hocko , Cgroups , netdev , "David S. Miller" , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH memcg v4] net: set proper memcg for net_init hooks allocations Message-ID: <20220427122232.GA9823@blackbody.suse.cz> References: <33085523-a8b9-1bf6-2726-f456f59015ef@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 10:23:32PM -0700, Shakeel Butt wrote: > [...] > > > > +static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p) > > +{ > > + struct mem_cgroup *memcg; > > + > > Do we need memcg_kmem_enabled() check here or maybe > mem_cgroup_from_obj() should be doing memcg_kmem_enabled() instead of > mem_cgroup_disabled() as we can have "cgroup.memory=nokmem" boot > param. I reckon such a guard is on the charge side and readers should treat NULL and root_mem_group equally. Or is there a case when these two are different? (I can see it's different semantics when stored in current->active_memcg (and active_memcg() getter) but for such "outer" callers like here it seems equal.) Regards, Michal