From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Alyssa Ross <hi@alyssa.is>,
Like Xu <likexu@tencent.com>, Kajol Jain <kjain@linux.ibm.com>,
Li Huafei <lihuafei1@huawei.com>, Ali Saidi <alisaidi@amazon.com>,
German Gomez <german.gomez@arm.com>,
James Clark <james.clark@arm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v1 04/11] perf mem: Add statistics for peer snooping
Date: Wed, 27 Apr 2022 23:50:06 +0800 [thread overview]
Message-ID: <20220427155013.1833222-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20220427155013.1833222-1-leo.yan@linaro.org>
Since we have added the flag PERF_MEM_SNOOPX_PEER to support cache
snooping from peer core or cluster, this patch is to add statistics for
this new flag.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Ali Saidi <alisaidi@amazon.com>
---
tools/perf/util/mem-events.c | 11 ++++++++++-
tools/perf/util/mem-events.h | 1 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index bfbac365e1e4..2086f067359b 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -525,6 +525,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
u64 op = data_src->mem_op;
u64 lvl = data_src->mem_lvl;
u64 snoop = data_src->mem_snoop;
+ u64 snoopx = data_src->mem_snoopx;
u64 lock = data_src->mem_lock;
u64 blk = data_src->mem_blk;
u64 lvl_num = data_src->mem_lvl_num;
@@ -568,10 +569,17 @@ do { \
if (lvl & P(LVL, IO)) stats->ld_io++;
if (lvl & P(LVL, LFB)) stats->ld_fbhit++;
if (lvl & P(LVL, L1 )) stats->ld_l1hit++;
- if (lvl & P(LVL, L2 )) stats->ld_l2hit++;
+ if (lvl & P(LVL, L2)) {
+ if (snoopx & P(SNOOPX, PEER))
+ stats->ld_peer++;
+ else
+ stats->ld_l2hit++;
+ }
if (lvl & P(LVL, L3 )) {
if (snoop & P(SNOOP, HITM))
HITM_INC(lcl_hitm);
+ else if (snoopx & P(SNOOPX, PEER))
+ stats->ld_peer++;
else
stats->ld_llchit++;
}
@@ -662,6 +670,7 @@ void c2c_add_stats(struct c2c_stats *stats, struct c2c_stats *add)
stats->ld_l1hit += add->ld_l1hit;
stats->ld_l2hit += add->ld_l2hit;
stats->ld_llchit += add->ld_llchit;
+ stats->ld_peer += add->ld_peer;
stats->lcl_hitm += add->lcl_hitm;
stats->rmt_hitm += add->rmt_hitm;
stats->tot_hitm += add->tot_hitm;
diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index e0e8057c52e8..7b6c74e74354 100644
--- a/tools/perf/util/mem-events.h
+++ b/tools/perf/util/mem-events.h
@@ -75,6 +75,7 @@ struct c2c_stats {
u32 ld_l1hit; /* count of loads that hit L1D */
u32 ld_l2hit; /* count of loads that hit L2D */
u32 ld_llchit; /* count of loads that hit LLC */
+ u32 ld_peer; /* count of loads that hit peer core or cluster cache */
u32 lcl_hitm; /* count of loads with local HITM */
u32 rmt_hitm; /* count of loads with remote HITM */
u32 tot_hitm; /* count of loads with local and remote HITM */
--
2.25.1
next prev parent reply other threads:[~2022-04-27 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:50 [PATCH v1 00/11] perf c2c: Support display for Arm64 Leo Yan
2022-04-27 15:50 ` [PATCH v1 01/11] perf mem: Add any cache level statistics for store operation Leo Yan
2022-04-27 15:50 ` [PATCH v1 02/11] perf c2c: Add dimensions for 'anylvl' metrics of " Leo Yan
2022-04-27 15:50 ` [PATCH v1 03/11] perf c2c: Update documentation for store metric 'Any Lvl' Leo Yan
2022-04-27 15:50 ` Leo Yan [this message]
2022-04-27 15:50 ` [PATCH v1 05/11] perf c2c: Add dimensions for peer load operations Leo Yan
2022-04-27 15:50 ` [PATCH v1 06/11] perf c2c: Use explicit names for display macros Leo Yan
2022-04-27 15:50 ` [PATCH v1 07/11] perf c2c: Rename dimension from 'percent_hitm' to 'percent_costly_snoop' Leo Yan
2022-04-27 15:50 ` [PATCH v1 08/11] perf c2c: Refactor node header Leo Yan
2022-04-27 15:50 ` [PATCH v1 09/11] perf c2c: Sort on peer snooping for load operations Leo Yan
2022-04-27 15:50 ` [PATCH v1 10/11] perf c2c: Update documentation for new display option 'peer' Leo Yan
2022-04-27 15:50 ` [PATCH v1 11/11] perf c2c: Use 'peer' as default display for Arm64 Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427155013.1833222-5-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=german.gomez@arm.com \
--cc=hi@alyssa.is \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=lihuafei1@huawei.com \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).