From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD73C433EF for ; Thu, 28 Apr 2022 09:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347179AbiD1JaW (ORCPT ); Thu, 28 Apr 2022 05:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347018AbiD1J2q (ORCPT ); Thu, 28 Apr 2022 05:28:46 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DAD67C795; Thu, 28 Apr 2022 02:25:30 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0CAC7240008; Thu, 28 Apr 2022 09:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1651137929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMLva4/g7+wAMx0LKhwNxH51lXYsvGGHAJATfjO0pGs=; b=YPR4woGd2LbLPt23lAH82e2KSKHFmuR/RTpRojKTgNtF6wKuUygUbjYuS1XrGiaflxm9uc JqhnwEiKfOLQERiERPTe+1//P5XkUcVgAPMfGLe/XO65agC9qinxS1MjW7i0jhYnbKpq1i OpQ+VZRDpBnqLKyzY6iW7qdNVD1xaLQ0eOSwSXzJ8ufZFrL0eh69DNdIVZnIyk5XjbgmO0 K4hsoMazXZDhiruoFoQvpLvWWIiBHUmMbhk7M0iAehbFw+89OrK+zdZwYDNTM5VkQ9KBr2 L1tLpfgombKHZ1Q+/bEmGbmWT3hMaGmog8dBREZomFQvwOl55m58BEwh0imf3Q== Date: Thu, 28 Apr 2022 11:25:26 +0200 From: Herve Codina To: Geert Uytterhoeven Cc: Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Rob Herring , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal Subject: Re: [PATCH v3 4/8] soc: renesas: rzn1: Select PM and PM_GENERIC_DOMAINS configs Message-ID: <20220428112526.3b55555b@bootlin.com> In-Reply-To: References: <20220422120850.769480-1-herve.codina@bootlin.com> <20220422120850.769480-5-herve.codina@bootlin.com> <20220428111535.51833857@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Thu, 28 Apr 2022 11:22:35 +0200 Geert Uytterhoeven wrote: > Hi Herv=C3=A9, >=20 > On Thu, Apr 28, 2022 at 11:15 AM Herve Codina = wrote: > > On Wed, 27 Apr 2022 16:58:07 +0200 > > Geert Uytterhoeven wrote: =20 > > > On Fri, Apr 22, 2022 at 2:09 PM Herve Codina wrote: =20 > > > > PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs. > > > > Without these configs, the clocks used by the PCI bridge are not > > > > enabled and so accessing the devices leads to a kernel crash: > > > > [ 0.832958] Unhandled fault: external abort on non-linefetch (= 0x1008) at 0x90b5f848 > > > > > > > > Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1 > > > > > > > > Signed-off-by: Herve Codina =20 > > > > > > Reviewed-by: Geert Uytterhoeven > > > i.e. will queue in renesas-devel for v5.19. =20 > > > > I plan to send a v4 of this series. > > > > As this patch (4/8) and the following one (5/8) will be > > queued for v5.19, I plan to remove them from the v4 version > > of the series. > > > > Is that ok for you or do you prefer to still have them > > in v4 ? =20 >=20 > As these two patches are not strictly related to adding PCI support, > but they are dependencies, I will queue them separately. Hence you > do not need to include them in v5. Perfect. Thanks, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com