linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Li Yang <leoyang.li@nxp.com>,
	linux-kernel@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Walle <michael@walle.cc>, Andrew Lunn <andrew@lunn.ch>,
	Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH v3 2/9] dt-bindings: nvmem: sfp: Add clock properties
Date: Thu, 28 Apr 2022 14:16:56 -0400	[thread overview]
Message-ID: <20220428181703.2194171-3-sean.anderson@seco.com> (raw)
In-Reply-To: <20220428181703.2194171-1-sean.anderson@seco.com>

To program fuses, it is necessary to set the fuse programming time. This
is determined based on the value of the platform clock. Add a clock
property.

Because this property is necessary for programming, it is made
mandatory. Since these bindings have not yet been present in a stable
release (though they are on track for 5.18), it is not an ABI break to
change them in this manner.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
This patch causes CI to fail. It will be fixed by patch 5.

Changes in v3:
- Update commit message to note that this binding has not yet been
  present in a relase, so it is OK to make otherwise breaking changes.

 .../bindings/nvmem/fsl,layerscape-sfp.yaml         | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
index b7798e903191..54086f50157d 100644
--- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
+++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
@@ -24,15 +24,29 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+    description:
+      The SFP clock. Typically, this is the platform clock divided by 4.
+
+  clock-names:
+    const: sfp
+
 required:
   - compatible
   - reg
+  - clock-names
+  - clocks
 
 unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
     efuse@1e80000 {
         compatible = "fsl,ls1028a-sfp";
         reg = <0x1e80000 0x8000>;
+        clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
+                            QORIQ_CLK_PLL_DIV(4)>;
+        clock-names = "sfp";
     };
-- 
2.35.1.1320.gc452695387.dirty


  parent reply	other threads:[~2022-04-28 18:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 18:16 [PATCH v3 0/9] nvmem: sfp: binding updates and additions Sean Anderson
2022-04-28 18:16 ` [PATCH v3 1/9] dt-bindings: nvmem: sfp: Fix typo Sean Anderson
2022-04-28 18:16 ` Sean Anderson [this message]
2022-04-28 18:16 ` [PATCH v3 3/9] dt-bindings: nvmem: sfp: Add TA_PROG_SFP supply Sean Anderson
2022-04-28 18:16 ` [PATCH v3 4/9] dt-bindings: nvmem: sfp: Add compatible binding for TA 2.1 SFPs Sean Anderson
2022-04-28 18:16 ` [PATCH v3 5/9] arm64: dts: ls1028a: Update SFP binding to include clock Sean Anderson
2022-05-03 13:47   ` Michael Walle
2022-06-29 13:32     ` Shawn Guo
2022-04-28 18:17 ` [PATCH v3 6/9] ARM: dts: layerscape: Add SFP binding for TA 2.1 devices Sean Anderson
2022-06-29 13:34   ` Shawn Guo
2022-04-28 18:17 ` [PATCH v3 7/9] ARM: dts: Add SFP binding for TA 3.0 devices Sean Anderson
2022-04-28 18:17 ` [PATCH v3 8/9] nvmem: sfp: Use regmap Sean Anderson
2022-04-28 18:17 ` [PATCH v3 9/9] nvmem: sfp: Add support for TA 2.1 devices Sean Anderson
2022-04-29 15:56 ` [PATCH v3 0/9] nvmem: sfp: binding updates and additions Srinivas Kandagatla
2022-05-03 13:43   ` Michael Walle
2022-05-09  8:28     ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428181703.2194171-3-sean.anderson@seco.com \
    --to=sean.anderson@seco.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).