From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9826C433F5 for ; Sat, 30 Apr 2022 14:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382843AbiD3OgE (ORCPT ); Sat, 30 Apr 2022 10:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239177AbiD3OgC (ORCPT ); Sat, 30 Apr 2022 10:36:02 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B608017048; Sat, 30 Apr 2022 07:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651329160; x=1682865160; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5n9k9ZqfREXkHj6Rcus3Ptw9qG95yOLcMZ9wKQUwq7c=; b=WtRUDu2Slk69CMvPNKeE8RwazDAuFuU83mqVubpYtq6EwRoMsqc9byNk BVwHGzigWr84TgEeKov9tin9VIrUu/q7LXBLMBjnu5PbtgflG3MDb/Cbj nBcRrLA1+AFBM9h/6H2L7/3RJxpAbAZUIsRg+GIuOBDnKym3wlm79aLA5 1Q3g+k6biS2aRmGLPTSQtnTawrorR1udgzIgcwD5WmSjs89nkuo1FnzHs Cmxrba9A6Tuy4nI2QlNlSlokUro+JGoQuB6+9XMUIuX4zjPSNIK9xEtOo 67LL+OA+uCTD6biKErIyoZO3KO4XQXOeo4O+1MFGyYG/0nyV/+5nrHPDO w==; X-IronPort-AV: E=McAfee;i="6400,9594,10332"; a="265736052" X-IronPort-AV: E=Sophos;i="5.91,188,1647327600"; d="scan'208";a="265736052" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2022 07:32:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,188,1647327600"; d="scan'208";a="706978136" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by fmsmga001.fm.intel.com with ESMTP; 30 Apr 2022 07:32:38 -0700 Date: Sat, 30 Apr 2022 22:24:52 +0800 From: Xu Yilun To: Tom Rix Cc: Tianfei Zhang , hao.wu@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Matthew Gerlach Subject: Re: [PATCH v3] uio: dfl: add HSSI subsystem feature id Message-ID: <20220430142452.GB398931@yilunxu-OptiPlex-7050> References: <20220429005726.607804-1-tianfei.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote: > > On 4/28/22 5:57 PM, Tianfei Zhang wrote: > > From: Matthew Gerlach > > > > Add the Device Feature List (DFL) feature id for the > > High Speed Serial Interface (HSSI) Subsystem to the > > table of ids supported by the uio_dfl driver. > > > > The HSSI Subsystem is a configurable set of IP blocks > > to be used as part of a Ethernet or PCS/FEC/PMA pipeline. > > Like the Ethernet group used by the N3000 card, the HSSI > > Subsystem does not fully implement a network device from > > a Linux netdev perspective and is controlled and monitored > > from user space software via the uio interface. > > Generally you should include the url for the dfl definitions. > > Can you add it here to the commit log ? Do you refer to this url, https://github.com/OPAE/dfl-feature-id ? Hao has some comments about this at https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com/ > > Otherwise fine. > > Reviewed-by: Tom Rix > > > > > Signed-off-by: Matthew Gerlach > > Signed-off-by: Tianfei Zhang This patch is now good to me. Acked-by: Xu Yilun > > --- > > v3: change the name of this feature id to HSSI_SUBSYS and rewrite > > the git message. > > v2: add HSSI introduction and the git repo of Feature ID table. > > --- > > drivers/uio/uio_dfl.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c > > index 89c0fc7b0cbc..8f39cc8bb034 100644 > > --- a/drivers/uio/uio_dfl.c > > +++ b/drivers/uio/uio_dfl.c > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev) > > } > > #define FME_FEATURE_ID_ETH_GROUP 0x10 > > +#define FME_FEATURE_ID_HSSI_SUBSYS 0x15 > > static const struct dfl_device_id uio_dfl_ids[] = { > > { FME_ID, FME_FEATURE_ID_ETH_GROUP }, > > + { FME_ID, FME_FEATURE_ID_HSSI_SUBSYS }, > > { } > > }; > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);