From: Xu Yilun <yilun.xu@intel.com>
To: Tom Rix <trix@redhat.com>
Cc: Tianfei Zhang <tianfei.zhang@intel.com>,
hao.wu@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH v3] uio: dfl: add HSSI subsystem feature id
Date: Sun, 1 May 2022 00:58:47 +0800 [thread overview]
Message-ID: <20220430165847.GD398931@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <774dee52-7f68-9d50-4a61-feaedd99eb86@redhat.com>
On Sat, Apr 30, 2022 at 07:54:57AM -0700, Tom Rix wrote:
>
> On 4/30/22 7:24 AM, Xu Yilun wrote:
> > On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
> > > On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > >
> > > > Add the Device Feature List (DFL) feature id for the
> > > > High Speed Serial Interface (HSSI) Subsystem to the
> > > > table of ids supported by the uio_dfl driver.
> > > >
> > > > The HSSI Subsystem is a configurable set of IP blocks
> > > > to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> > > > Like the Ethernet group used by the N3000 card, the HSSI
> > > > Subsystem does not fully implement a network device from
> > > > a Linux netdev perspective and is controlled and monitored
> > > > from user space software via the uio interface.
> > > Generally you should include the url for the dfl definitions.
> > >
> > > Can you add it here to the commit log ?
> > Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?
>
> Yes, exactly.
>
> To someone not working the day-to-day working dfl they will have no clue
> where the fids come from.
>
> When a new one is added to the kernel, it should have a listing in
> dfl-feature-id repo.
>
> If it doesn't, there will be a future conflict.
I remember a recent patch records the url in Documentation/fpga/dfl.rst.
Anyway I'm OK with or without the url in commit message.
Thanks,
Yilun
>
> Tom
>
> >
> > Hao has some comments about this at
> >
> > https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com/
> >
> > > Otherwise fine.
> > >
> > > Reviewed-by: Tom Rix <trix@redhat.com>
> > >
> > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > This patch is now good to me.
> >
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> >
> > > > ---
> > > > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> > > > the git message.
> > > > v2: add HSSI introduction and the git repo of Feature ID table.
> > > > ---
> > > > drivers/uio/uio_dfl.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > index 89c0fc7b0cbc..8f39cc8bb034 100644
> > > > --- a/drivers/uio/uio_dfl.c
> > > > +++ b/drivers/uio/uio_dfl.c
> > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > > > }
> > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > +#define FME_FEATURE_ID_HSSI_SUBSYS 0x15
> > > > static const struct dfl_device_id uio_dfl_ids[] = {
> > > > { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > > > + { FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> > > > { }
> > > > };
> > > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
next prev parent reply other threads:[~2022-04-30 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 0:57 [PATCH v3] uio: dfl: add HSSI subsystem feature id Tianfei Zhang
2022-04-29 12:23 ` Tom Rix
2022-04-30 14:24 ` Xu Yilun
2022-04-30 14:54 ` Tom Rix
2022-04-30 16:58 ` Xu Yilun [this message]
2022-05-05 6:22 ` Wu, Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220430165847.GD398931@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).