From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: kishon@ti.com, lorenzo.pieralisi@arm.com, kw@linux.com,
bhelgaas@google.com, robh@kernel.org
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH 2/8] PCI: endpoint: Warn and return if EPC is started/stopped multiple times
Date: Mon, 2 May 2022 11:36:05 +0530 [thread overview]
Message-ID: <20220502060611.58987-3-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20220502060611.58987-1-manivannan.sadhasivam@linaro.org>
When the EPC is started or stopped multiple times from configfs, just emit
a once time warning and return. There is no need to call the EPC start/stop
functions in those cases.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/pci/endpoint/pci-ep-cfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index d4850bdd837f..2cfd5fd2794c 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -178,6 +178,9 @@ static ssize_t pci_epc_start_store(struct config_item *item, const char *page,
if (kstrtobool(page, &start) < 0)
return -EINVAL;
+ if (WARN_ON_ONCE(start == epc_group->start))
+ return 0;
+
if (!start) {
pci_epc_stop(epc);
epc_group->start = 0;
--
2.25.1
next prev parent reply other threads:[~2022-05-02 6:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 6:06 [PATCH 0/8] Add support for MHI Endpoint function driver Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 1/8] PCI: endpoint: Pass EPF device ID to the probe function Manivannan Sadhasivam
2022-05-02 6:06 ` Manivannan Sadhasivam [this message]
2022-05-02 6:06 ` [PATCH 3/8] PCI: endpoint: Add an API for unregistering the EPF notifier Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 4/8] PCI: endpoint: Add linkdown notifier support Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 5/8] PCI: endpoint: Add BME " Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 6/8] PCI: qcom-ep: Add support for Link down notification Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 7/8] PCI: qcom-ep: Add support for BME notification Manivannan Sadhasivam
2022-05-02 6:06 ` [PATCH 8/8] PCI: endpoint: Add PCI Endpoint function driver for MHI bus Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502060611.58987-3-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).