From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5EAC433EF for ; Mon, 2 May 2022 09:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381379AbiEBJuv (ORCPT ); Mon, 2 May 2022 05:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384371AbiEBJuf (ORCPT ); Mon, 2 May 2022 05:50:35 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A205413F1A for ; Mon, 2 May 2022 02:47:00 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2429khig030092; Mon, 2 May 2022 04:46:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1651484803; bh=/f3+ZN1BRGOPjS26Jk9C7pfpeHeos4hddQADZyloaso=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=hpBeSDROS88ZzV1RwsUTd7IItg2jtfZ2v+SJLCd58Q2vsh1C5YCSDaRbcrahEj2Ot CtJ3+FKrrfvt7h2eZrNsyu+ormjOBXRGT+e5ONlQHSMJmNv/lrf//sL2xcbwHFHw7G uMh5uIx7B7RGfuF96cxXXJMNgLbR39N56LfFJqDE= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2429khF9042579 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 2 May 2022 04:46:43 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 2 May 2022 04:46:43 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 2 May 2022 04:46:43 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2429kgkh040255; Mon, 2 May 2022 04:46:43 -0500 Date: Mon, 2 May 2022 15:16:42 +0530 From: Pratyush Yadav To: Michael Walle CC: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Subject: Re: [PATCH v3 2/2] mtd: spi-nor: expose internal parameters via debugfs Message-ID: <20220502094642.trl7fggx6se5cqhg@ti.com> References: <20220429102018.2361038-1-michael@walle.cc> <20220429102018.2361038-2-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220429102018.2361038-2-michael@walle.cc> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/04/22 12:20PM, Michael Walle wrote: > There is no way to gather all information to verify support for a new > flash chip. Also if you want to convert an existing flash chip to the > new SFDP parsing, there is not enough information to determine if the > flash will work like before. To ease this development, expose internal > parameters via the debugfs. > > Signed-off-by: Michael Walle Did some basic testing, seems fine to me. I'll wait a couple more days if someone has any comments or else I'll apply it. Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav Texas Instruments Inc.