* [PATCH v2] gpio: xilinx: add missing blank line after declarations
@ 2022-05-02 11:00 Shubhrajyoti Datta
2022-06-21 10:21 ` Datta, Shubhrajyoti
2022-07-07 13:12 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Shubhrajyoti Datta @ 2022-05-02 11:00 UTC (permalink / raw)
To: linux-gpio
Cc: michal.simek, srinivas.neeli, linux-kernel, git, Shubhrajyoti Datta
Add a missing blank line. No functional changes.
WARNING: Missing a blank line after declarations
128: FILE: drivers/gpio/gpio-xilinx.c:120:
+ void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+ xgpio_set_value32(a, bit, xgpio_readreg(addr));
WARNING: Missing a blank line after declarations
136: FILE: drivers/gpio/gpio-xilinx.c:126:
+ void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+ xgpio_writereg(addr, xgpio_get_value32(a, bit));
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
v2: Update commit message
drivers/gpio/gpio-xilinx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index b6d3a57e27ed..7f129e7eae78 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
{
void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
xgpio_set_value32(a, bit, xgpio_readreg(addr));
}
static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
{
void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
xgpio_writereg(addr, xgpio_get_value32(a, bit));
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] gpio: xilinx: add missing blank line after declarations
2022-05-02 11:00 [PATCH v2] gpio: xilinx: add missing blank line after declarations Shubhrajyoti Datta
@ 2022-06-21 10:21 ` Datta, Shubhrajyoti
2022-07-07 13:12 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Datta, Shubhrajyoti @ 2022-06-21 10:21 UTC (permalink / raw)
To: Shubhrajyoti Datta, linux-gpio
Cc: Simek, Michal, Neeli, Srinivas, linux-kernel, git
[AMD Official Use Only - General]
> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Sent: Monday, May 2, 2022 4:31 PM
> To: linux-gpio@vger.kernel.org
> Cc: Michal Simek <michals@xilinx.com>; Srinivas Neeli <sneeli@xilinx.com>;
> linux-kernel@vger.kernel.org; git <git@xilinx.com>; Shubhrajyoti Datta
> <shubhraj@xilinx.com>
> Subject: [PATCH v2] gpio: xilinx: add missing blank line after declarations
>
> Add a missing blank line. No functional changes.
>
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_set_value32(a, bit, xgpio_readreg(addr));
>
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_writereg(addr, xgpio_get_value32(a, bit));
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
If there are no further comments can it be merged.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gpio: xilinx: add missing blank line after declarations
2022-05-02 11:00 [PATCH v2] gpio: xilinx: add missing blank line after declarations Shubhrajyoti Datta
2022-06-21 10:21 ` Datta, Shubhrajyoti
@ 2022-07-07 13:12 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2022-07-07 13:12 UTC (permalink / raw)
To: Shubhrajyoti Datta, linux-gpio, Bartosz Golaszewski
Cc: michal.simek, srinivas.neeli, linux-kernel, git
On 5/2/22 13:00, Shubhrajyoti Datta wrote:
> Add a missing blank line. No functional changes.
>
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_set_value32(a, bit, xgpio_readreg(addr));
>
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_writereg(addr, xgpio_get_value32(a, bit));
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v2: Update commit message
>
> drivers/gpio/gpio-xilinx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
> static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
> {
> void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
> xgpio_set_value32(a, bit, xgpio_readreg(addr));
> }
>
> static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
> {
> void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
> xgpio_writereg(addr, xgpio_get_value32(a, bit));
> }
>
Fixes: 02b3f84d9080 ("gpio: xilinx: Switch to use bitmap APIs")
Reviewed-by: Michal Simek <michal.simek@amd.com>
Bartosz: Can you please apply it?
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-07 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 11:00 [PATCH v2] gpio: xilinx: add missing blank line after declarations Shubhrajyoti Datta
2022-06-21 10:21 ` Datta, Shubhrajyoti
2022-07-07 13:12 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).