From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, elver@google.com,
jbaron@akamai.com, rostedt@goodmis.org, ardb@kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/3] x86/cpu: Elide KCSAN for cpu_has() and friends
Date: Mon, 2 May 2022 11:47:47 -0700 [thread overview]
Message-ID: <20220502184747.cr5ssem3g4mel4qq@treble> (raw)
In-Reply-To: <20220502111216.290518605@infradead.org>
On Mon, May 02, 2022 at 01:07:43PM +0200, Peter Zijlstra wrote:
> vmlinux.o: warning: objtool: enter_from_user_mode+0x24: call to __kcsan_check_access() leaves .noinstr.text section
> vmlinux.o: warning: objtool: syscall_enter_from_user_mode+0x28: call to __kcsan_check_access() leaves .noinstr.text section
> vmlinux.o: warning: objtool: syscall_enter_from_user_mode_prepare+0x24: call to __kcsan_check_access() leaves .noinstr.text section
> vmlinux.o: warning: objtool: irqentry_enter_from_user_mode+0x24: call to __kcsan_check_access() leaves .noinstr.text section
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
An explanation about *why* this fixes it would help, as I have no idea
from looking at the patch.
> ---
> arch/x86/include/asm/cpufeature.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/include/asm/cpufeature.h
> +++ b/arch/x86/include/asm/cpufeature.h
> @@ -51,7 +51,7 @@ extern const char * const x86_power_flag
> extern const char * const x86_bug_flags[NBUGINTS*32];
>
> #define test_cpu_cap(c, bit) \
> - test_bit(bit, (unsigned long *)((c)->x86_capability))
> + arch_test_bit(bit, (unsigned long *)((c)->x86_capability))
>
> /*
> * There are 32 bits/features in each mask word. The high bits
>
>
--
Josh
next prev parent reply other threads:[~2022-05-02 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 11:07 [PATCH 0/3] x86: Address various objtool complaints Peter Zijlstra
2022-05-02 11:07 ` [PATCH 1/3] objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn Peter Zijlstra
2022-05-02 11:07 ` [PATCH 2/3] x86/cpu: Elide KCSAN for cpu_has() and friends Peter Zijlstra
2022-05-02 11:54 ` Marco Elver
2022-05-02 18:47 ` Josh Poimboeuf [this message]
2022-05-03 14:20 ` Mark Rutland
2022-05-30 10:38 ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-05-02 11:07 ` [PATCH 3/3] jump_label,noinstr: Avoid instrumentation for JUMP_LABEL=n builds Peter Zijlstra
2022-05-02 11:23 ` Marco Elver
2022-05-02 13:01 ` Peter Zijlstra
2022-05-02 13:09 ` [PATCH v2 " Peter Zijlstra
2022-05-02 13:25 ` Marco Elver
2022-05-02 14:54 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502184747.cr5ssem3g4mel4qq@treble \
--to=jpoimboe@redhat.com \
--cc=ardb@kernel.org \
--cc=elver@google.com \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).